From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0E2B1D52A; Wed, 20 Dec 2023 07:28:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="PMCPRzos" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=5Cp0brfPb+fyu6Yk+mtHotB5lP7dckOvawNH9gPrHx4=; b=PMCPRzosOokGKnRpAUl2VHGDKe 0uHl0/wFnM3dnK7qurriPilNY7TWfknpJwTn6If8YmdkdrfVyp4rGb3hmDqhXinKtUgmQgdWzw806 vYwWnpyB+9V2EPCJxyvIo+tRrnzZVPEyIUBgU/kloUGyZQr/gZAUJuVk5DG+3FDA/WMYGITKQe7t5 /gsyOg9qGrAA/Nnc3Xkre+Tq3AmH2Cl4EeyJhInPTsk1Yw0O+Fi5PuYVRa8+BSAwqFS1G7h6V+tTb 0PqDIxVBsxxTqh3mTYZERqWJ1o5/sJ6D0GswHlOXYTqPfHMGs5oHumPcLu9n8TJfCjHwARmZFnJcy mRm9ESzw==; Received: from [50.53.46.231] (helo=[192.168.254.15]) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1rFr0X-00GQZN-0z; Wed, 20 Dec 2023 07:28:45 +0000 Message-ID: Date: Tue, 19 Dec 2023 23:28:44 -0800 Precedence: bulk X-Mailing-List: linux-nilfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] nilfs2: cpfile: fix some kernel-doc warnings Content-Language: en-US To: Ryusuke Konishi Cc: linux-kernel@vger.kernel.org, linux-nilfs@vger.kernel.org References: <20231220065931.2372-1-rdunlap@infradead.org> From: Randy Dunlap In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 12/19/23 23:25, Ryusuke Konishi wrote: > On Wed, Dec 20, 2023 at 3:59 PM Randy Dunlap wrote: >> >> Correct the function parameter names for nilfs_cpfile_get_info(): >> >> cpfile.c:564: warning: Function parameter or member 'cnop' not described in 'nilfs_cpfile_get_cpinfo' >> cpfile.c:564: warning: Function parameter or member 'mode' not described in 'nilfs_cpfile_get_cpinfo' >> cpfile.c:564: warning: Function parameter or member 'buf' not described in 'nilfs_cpfile_get_cpinfo' >> cpfile.c:564: warning: Function parameter or member 'cisz' not described in 'nilfs_cpfile_get_cpinfo' >> cpfile.c:564: warning: Excess function parameter 'cno' description in 'nilfs_cpfile_get_cpinfo' >> cpfile.c:564: warning: Excess function parameter 'ci' description in 'nilfs_cpfile_get_cpinfo' >> >> This still leaves a few kernel-doc warnings. >> Also, the function parameters should have descriptions after them. >> >> Signed-off-by: Randy Dunlap >> Cc: Ryusuke Konishi >> Cc: linux-nilfs@vger.kernel.org >> --- >> fs/nilfs2/cpfile.c | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff -- a/fs/nilfs2/cpfile.c b/fs/nilfs2/cpfile.c >> --- a/fs/nilfs2/cpfile.c >> +++ b/fs/nilfs2/cpfile.c >> @@ -554,8 +554,10 @@ static ssize_t nilfs_cpfile_do_get_ssinf >> /** >> * nilfs_cpfile_get_cpinfo - >> * @cpfile: >> - * @cno: >> - * @ci: >> + * @cnop: >> + * @mode: >> + * @buf: >> + * @cisz: >> * @nci: >> */ >> > > Ah, thank you for pointing it out. > > I would like to fill in the missing descriptions and send it upstream. Yes, please do. Thanks. -- #Randy https://people.kernel.org/tglx/notes-about-netiquette https://subspace.kernel.org/etiquette.html