linux-numa.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Cliff Wickman <cpw@sgi.com>,
	Kornilios Kourtis <kkourt@cslab.ece.ntua.gr>,
	Brice Goglin <Brice.Goglin@inria.fr>,
	linux-numa@vger.kernel.org, eric.whitney@hp.com
Subject: Re: [PATCH 7/8] numactl/Makefile - Generalize Makefile .so Version
Date: Tue, 28 Apr 2009 13:01:57 -0400	[thread overview]
Message-ID: <1240938117.6998.85.camel@lts-notebook> (raw)
In-Reply-To: <20090428164616.GN27382@one.firstfloor.org>

On Tue, 2009-04-28 at 18:46 +0200, Andi Kleen wrote:
> On Tue, Apr 28, 2009 at 12:37:02PM -0400, Lee Schermerhorn wrote:
> > [PATCH 07/08] Generalize Makefile .so Version
> > 
> > Against:  numactl-2.0.3-rc2
> > 
> > When building "upstream" libnuma on a system with, e.g., a distro-supplied
> > numactl package installed, I find it useful to build a different version of
> > libnuma.so, so that both versions of the library can co-exist.  
> 
> Sorry I don't think that's a good idea. If that ever escapes from
> your system we have a binary incompatibility mess, which was 
> always one of the goals of libnuma to avoid.
> 
> I just use LD_LIBRARY_PATH for testing newer libnumas. It's not too
> bad.

Yeah, I use LD_LIBRARY_PATH when testing in the numactl build directory,
[make test], but I also install the tools on the test servers and like
to be able to use both version.  But, that's just for my convenience, so
I'm fine with not including this patch.  It's easy enough to rebase for
my own use.

I do wonder, tho', why we don't/didn't bump the library version when we
added the v2 API.  One can't tell from looking at the libnuma.so.1
whether it supports the new APIs or not.  [I know.  objdump will tell
me.] Given that the v2 lib still supports the v1 APIs and we install the
libnuma.so sym link, seems it would be nice to have the library version
match the API version.

Later,
Lee


  reply	other threads:[~2009-04-28 17:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-28 16:36 [PATCH 0/8] numactl/libnuma - Fixes and Cleanup Lee Schermerhorn
2009-04-28 16:36 ` [PATCH 1/8] numactl/libnuma - Possibly already fixed leaks and cleanup Lee Schermerhorn
2009-04-28 16:36 ` [PATCH 2/8] numactl/libnuma - Simple bitmask leak fixes Lee Schermerhorn
2009-04-28 16:36 ` [PATCH 3/8] numactl/libnuma - more " Lee Schermerhorn
2009-04-28 16:36 ` [PATCH 4/8] numactl/libnuma - return freeable bitmasks Lee Schermerhorn
2009-04-28 16:36 ` [PATCH 5/8] numactl/libnuma - fix parsing of cpu, node mask Lee Schermerhorn
2009-04-28 16:36 ` [PATCH 6/8] numactl/numademo - eliminate page allocation overhead from memtest measurements Lee Schermerhorn
2009-04-28 16:37 ` [PATCH 7/8] numactl/Makefile - Generalize Makefile .so Version Lee Schermerhorn
2009-04-28 16:46   ` Andi Kleen
2009-04-28 17:01     ` Lee Schermerhorn [this message]
2009-04-28 17:10       ` Andi Kleen
2009-04-28 16:37 ` [PATCH 8/8] numactl/test - Make checkaffinity more robust Lee Schermerhorn
2009-04-28 19:38 ` [PATCH 0/8] numactl/libnuma - Fixes and Cleanup Cliff Wickman
2009-04-28 20:08   ` Lee Schermerhorn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1240938117.6998.85.camel@lts-notebook \
    --to=lee.schermerhorn@hp.com \
    --cc=Brice.Goglin@inria.fr \
    --cc=andi@firstfloor.org \
    --cc=cpw@sgi.com \
    --cc=eric.whitney@hp.com \
    --cc=kkourt@cslab.ece.ntua.gr \
    --cc=linux-numa@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).