From: Peter Zijlstra <peterz@infradead.org>
To: Tang Chen <tangchen@cn.fujitsu.com>
Cc: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, x86@kernel.org,
linux-numa@vger.kernel.org, wency@cn.fujitsu.com,
mingo@kernel.org, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] Update sched_domains_numa_masks when new cpus are onlined.
Date: Tue, 25 Sep 2012 13:50:06 +0200 [thread overview]
Message-ID: <1348573806.3881.35.camel@twins> (raw)
In-Reply-To: <5061996E.8070301@cn.fujitsu.com>
On Tue, 2012-09-25 at 19:45 +0800, Tang Chen wrote:
> Let's have an example here.
>
> sched_init_numa()
> {
> ...
> // A loop set sched_domains_numa_levels to level.-------------1
>
> // I set sched_domains_numa_levels to 0.
> sched_domains_numa_levels = 0;--------------------------------2
Ah, ok, so this 'idiot in a hurry' (aka. me) placed the hunk wrong and
thought it was at the start of the function.
> // A loop allocating memory for sched_domains_numa_masks[][]
> for (i = 0; i < level; i++) {
> ......
> // Allocate memory for sched_domains_numa_masks[i]----3
> ......
> }
> ......
>
> // I reset sched_domains_numa_levels to level.
> sched_domains_numa_levels = level;----------------------------4
> }
Yes this makes sense, it might be best to have this as a separate patch.
next prev parent reply other threads:[~2012-09-25 11:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 10:12 [PATCH] Update sched_domains_numa_masks when new cpus are onlined Tang Chen
2012-09-24 5:52 ` Tang Chen
2012-09-24 9:38 ` Peter Zijlstra
2012-09-24 9:57 ` Srivatsa S. Bhat
2012-09-24 10:12 ` Peter Zijlstra
2012-09-24 10:17 ` Srivatsa S. Bhat
2012-09-25 2:39 ` Tang Chen
2012-09-25 2:39 ` Tang Chen
2012-09-25 10:33 ` Peter Zijlstra
2012-09-25 11:45 ` Tang Chen
2012-09-25 11:50 ` Peter Zijlstra [this message]
2012-09-25 12:02 ` Tang Chen
2012-09-25 11:07 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348573806.3881.35.camel@twins \
--to=peterz@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-numa@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=tangchen@cn.fujitsu.com \
--cc=tglx@linutronix.de \
--cc=wency@cn.fujitsu.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).