From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] Update sched_domains_numa_masks when new cpus are
 onlined.
Date: Tue, 25 Sep 2012 13:50:06 +0200
Message-ID: <1348573806.3881.35.camel@twins>
References: <1347963128-25942-1-git-send-email-tangchen@cn.fujitsu.com>
	  <1348479536.11847.25.camel@twins> <50611946.9080601@cn.fujitsu.com>
	 <1348569232.3881.1.camel@twins> <5061996E.8070301@cn.fujitsu.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7BIT
Return-path: <linux-numa-owner@vger.kernel.org>
In-Reply-To: <5061996E.8070301@cn.fujitsu.com>
Sender: linux-numa-owner@vger.kernel.org
List-ID: <linux-numa.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"
To: Tang Chen <tangchen@cn.fujitsu.com>
Cc: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>, linux-kernel@vger.kernel.org, x86@kernel.org, linux-numa@vger.kernel.org, wency@cn.fujitsu.com, mingo@kernel.org, Thomas Gleixner <tglx@linutronix.de>

On Tue, 2012-09-25 at 19:45 +0800, Tang Chen wrote:


> Let's have an example here.
> 
> sched_init_numa()
> {
> 	...
> 	// A loop set sched_domains_numa_levels to level.-------------1
> 
> 	// I set sched_domains_numa_levels to 0.
> 	sched_domains_numa_levels = 0;--------------------------------2

Ah, ok, so this 'idiot in a hurry' (aka. me) placed the hunk wrong and
thought it was at the start of the function.

> 	// A loop allocating memory for sched_domains_numa_masks[][]
> 	for (i = 0; i < level; i++) {
> 		......
> 		// Allocate memory for sched_domains_numa_masks[i]----3
> 		......
> 	}
> 	......
> 
> 	// I reset sched_domains_numa_levels to level.
> 	sched_domains_numa_levels = level;----------------------------4
> }

Yes this makes sense, it might be best to have this as a separate patch.