From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH] Do not use cpu_to_node() to find an offlined cpu's node. Date: Fri, 19 Oct 2012 13:18:04 +0200 Message-ID: <1350645484.30157.3.camel@twins> References: <1349665183-11718-1-git-send-email-tangchen@cn.fujitsu.com> <1349780256.7880.12.camel@twins> <1349815676.7880.85.camel@twins> <1349860216.7880.105.camel@twins> <20121010133709.7eaefcdb.akpm@linux-foundation.org> <507F6EB3.7030705@cn.fujitsu.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7BIT Return-path: In-Reply-To: Sender: linux-numa-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: David Rientjes Cc: Tang Chen , Andrew Morton , mingo@redhat.com, miaox@cn.fujitsu.com, wency@cn.fujitsu.com, linux-kernel@vger.kernel.org, linux-numa@vger.kernel.org On Wed, 2012-10-17 at 20:29 -0700, David Rientjes wrote: > > Ok, thanks for the update. I agree that we should be clearing the mapping > at node hot-remove since any cpu that would subsequently get onlined and > assume one of the previous cpu's ids is not guaranteed to have the same > affinity. Would this mean we have to remap (and memcpy) per-cpu memory on node-plug? > I'm just really hoping that we don't touch the acpi code and that we can > remove both cpu_hotplug-unmap-cpu2node-when-the-cpu-is-hotremoved.patch > and cpu_hotplug-unmap-cpu2node-when-the-cpu-is-hotremoved-fix.patch from > -mm. Yeah, none of this should be anywhere near ACPI, its got nothing to do with ACPI. Furthermore it should be be same across all archs, not just be weird and wonderful for x86.