From: Daniel J Blueman <daniel@numascale.com>
To: linux-numa@vger.kernel.org
Cc: Daniel J Blueman <daniel@numascale.com>,
Steffen Persvold <sp@numascale.com>
Subject: [PATCH] Fix a SEGV due to uninitialised mask
Date: Tue, 17 Feb 2015 12:06:51 +0800 [thread overview]
Message-ID: <1424146011-28317-1-git-send-email-daniel@numascale.com> (raw)
As node_cpu_mask_v2 is not defined as local to the compilation unit with
'static', it is not guaranteed to be initialised to zero (ie in the .bss).
This was leading to some SEGVs we've seen.
Also mark another internal function local to the compilation unit.
Signed-off-by: Daniel J Blueman <daniel@numascale.com>
---
libnuma.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libnuma.c b/libnuma.c
index 8d7bf13..3717d5b 100644
--- a/libnuma.c
+++ b/libnuma.c
@@ -58,7 +58,7 @@ struct bitmask *numa_possible_cpus_ptr = NULL;
struct bitmask *numa_nodes_ptr = NULL;
static struct bitmask *numa_memnode_ptr = NULL;
static unsigned long *node_cpu_mask_v1[NUMA_NUM_NODES];
-struct bitmask **node_cpu_mask_v2;
+static struct bitmask **node_cpu_mask_v2;
WEAK void numa_error(char *where);
@@ -1234,7 +1234,7 @@ numa_parse_bitmap_v2(char *line, struct bitmask *mask)
__asm__(".symver numa_parse_bitmap_v2,numa_parse_bitmap@@libnuma_1.2");
void
-init_node_cpu_mask_v2(void)
+static init_node_cpu_mask_v2(void)
{
int nnodes = numa_max_possible_node_v2_int() + 1;
node_cpu_mask_v2 = calloc (nnodes, sizeof(struct bitmask *));
--
1.9.1
next reply other threads:[~2015-02-17 4:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-17 4:06 Daniel J Blueman [this message]
2015-02-18 21:39 ` [PATCH] Fix a SEGV due to uninitialised mask Filipe Brandenburger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424146011-28317-1-git-send-email-daniel@numascale.com \
--to=daniel@numascale.com \
--cc=linux-numa@vger.kernel.org \
--cc=sp@numascale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).