From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Holasek Subject: [PATCH] libnuma: checking of sucessfull allocations in numademo Date: Thu, 18 Aug 2011 07:01:33 -0400 (EDT) Message-ID: <1777371722.2768004.1313665293333.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> References: <193444186.2767974.1313665001288.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <193444186.2767974.1313665001288.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> Sender: linux-numa-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: linux-numa@vger.kernel.org Cc: cpw@sgi.com From: Petr Holasek This patch is based on BZ https://bugzilla.redhat.com/show_bug.cgi?id=707138 where too big argument for numademo caused segfault. Only simple check of returned pointer from numa_alloc* calls was added. Signed-off-by: Petr Holasek -- diff -up numactl-2.0.7/numademo.c.origin numactl-2.0.7/numademo.c --- numactl-2.0.7/numademo.c.origin 2011-08-18 06:40:56.617884667 -0400 +++ numactl-2.0.7/numademo.c 2011-08-18 06:38:15.783759565 -0400 @@ -156,6 +156,11 @@ void memtest(char *name, unsigned char * int i; char title[128], result[128]; + if (!mem) { + fprintf(stderr,"Failed to allocate %lu bytes of memory. Test \"%s\" exits.\n", msize, name); + return; + } + #ifdef HAVE_STREAM_LIB if (thistest == STREAM) { do_stream(name, mem);