linux-numa.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Cliff Wickman <cpw@sgi.com>
Cc: andi@firstfloor.org, linux-numa@vger.kernel.org
Subject: Re: [PATCH] Fix test/prefered v2
Date: Fri, 16 Jan 2009 02:44:22 +0100	[thread overview]
Message-ID: <20090116014422.GA1475@one.firstfloor.org> (raw)
In-Reply-To: <E1LNTzS-0001v1-Rf@eag09.americas.sgi.com>

> There is numa_num_possible_nodes(). It determines the size of

Ah that's better.

> the kernel nodemask_t (MAX_NUMNODES) by counting the size of Mems_allowed:
> in /proc/self/status. (And if that is not available, falls back to a
> procedure very similar to your max_numnode().)
> The patch, but using numa_num_possible_nodes() is below.
> It returns the same results, in my tests.
> 
> Is there some subtle difference between numa_num_possible_nodes() and
> your function that I'm missing?

No your patch should be ok.

-Andi

  reply	other threads:[~2009-01-16  1:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-15 15:18 [PATCH] Fix test/prefered v2 Cliff Wickman
2009-01-16  1:44 ` Andi Kleen [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-01-10  5:54 [PATCH] Fix test/prefered Andi Kleen
2009-01-10  6:18 ` [PATCH] Fix test/prefered v2 Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090116014422.GA1475@one.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=cpw@sgi.com \
    --cc=linux-numa@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).