* [PATCH 1/4] hugetlb: rework hstate_next_node_* functions
2009-07-29 17:54 [PATCH 0/4] hugetlb: V3 constrain allocation/free based on task mempolicy Lee Schermerhorn
@ 2009-07-29 17:54 ` Lee Schermerhorn
2009-07-30 10:40 ` Mel Gorman
2009-07-29 17:55 ` [PATCH 2/4] hugetlb: add nodemask arg to huge page alloc, free and surplus adjust fcns Lee Schermerhorn
` (3 subsequent siblings)
4 siblings, 1 reply; 12+ messages in thread
From: Lee Schermerhorn @ 2009-07-29 17:54 UTC (permalink / raw)
To: linux-mm, linux-numa
Cc: akpm, Mel Gorman, Nishanth Aravamudan, andi, David Rientjes,
Adam Litke, Andy Whitcroft, eric.whitney
[PATCH 1/4] hugetlb: rework hstate_next_node* functions
Against: 2.6.31-rc3-mmotm-090716-1432
atop the alloc_bootmem_huge_page() fix patch
[http://marc.info/?l=linux-mm&m=124775468226290&w=4]
V2:
+ cleaned up comments, removed some deemed unnecessary,
add some suggested by review
+ removed check for !current in huge_mpol_nodes_allowed().
+ added 'current->comm' to warning message in huge_mpol_nodes_allowed().
+ added VM_BUG_ON() assertion in hugetlb.c next_node_allowed() to
catch out of range node id.
+ add examples to patch description
V3:
+ factored this "cleanup" patch out of V2 patch 2/3
+ moved ahead of patch to add nodes_allowed mask to alloc funcs
as this patch is somewhat independent from using task mempolicy
to control huge page allocation and freeing.
Modify the hstate_next_node* functions to allow them to be called to
obtain the "start_nid". Then, whereas prior to this patch we
unconditionally called hstate_next_node_to_{alloc|free}(), whether
or not we successfully allocated/freed a huge page on the node,
now we only call these functions on failure to alloc/free.
Factor out the next_node_allowed() function to handle wrap at end
of node_online_map. In this version, the allowed nodes are all
of the online nodes.
Signed-off-by: Lee Schermerhorn <lee.schermerhorn@hp.com>
mm/hugetlb.c | 70 +++++++++++++++++++++++++++++++++++++----------------------
1 file changed, 45 insertions(+), 25 deletions(-)
Index: linux-2.6.31-rc3-mmotm-090716-1432/mm/hugetlb.c
===================================================================
--- linux-2.6.31-rc3-mmotm-090716-1432.orig/mm/hugetlb.c 2009-07-22 15:42:46.000000000 -0400
+++ linux-2.6.31-rc3-mmotm-090716-1432/mm/hugetlb.c 2009-07-22 15:42:48.000000000 -0400
@@ -622,6 +622,20 @@ static struct page *alloc_fresh_huge_pag
}
/*
+ * common helper function for hstate_next_node_to_{alloc|free}.
+ * return next node in node_online_map, wrapping at end.
+ */
+static int next_node_allowed(int nid)
+{
+ nid = next_node(nid, node_online_map);
+ if (nid == MAX_NUMNODES)
+ nid = first_node(node_online_map);
+ VM_BUG_ON(nid >= MAX_NUMNODES);
+
+ return nid;
+}
+
+/*
* Use a helper variable to find the next node and then
* copy it back to next_nid_to_alloc afterwards:
* otherwise there's a window in which a racer might
@@ -634,12 +648,12 @@ static struct page *alloc_fresh_huge_pag
*/
static int hstate_next_node_to_alloc(struct hstate *h)
{
- int next_nid;
- next_nid = next_node(h->next_nid_to_alloc, node_online_map);
- if (next_nid == MAX_NUMNODES)
- next_nid = first_node(node_online_map);
+ int nid, next_nid;
+
+ nid = h->next_nid_to_alloc;
+ next_nid = next_node_allowed(nid);
h->next_nid_to_alloc = next_nid;
- return next_nid;
+ return nid;
}
static int alloc_fresh_huge_page(struct hstate *h)
@@ -649,15 +663,17 @@ static int alloc_fresh_huge_page(struct
int next_nid;
int ret = 0;
- start_nid = h->next_nid_to_alloc;
+ start_nid = hstate_next_node_to_alloc(h);
next_nid = start_nid;
do {
page = alloc_fresh_huge_page_node(h, next_nid);
- if (page)
+ if (page) {
ret = 1;
+ break;
+ }
next_nid = hstate_next_node_to_alloc(h);
- } while (!page && next_nid != start_nid);
+ } while (next_nid != start_nid);
if (ret)
count_vm_event(HTLB_BUDDY_PGALLOC);
@@ -668,17 +684,19 @@ static int alloc_fresh_huge_page(struct
}
/*
- * helper for free_pool_huge_page() - find next node
- * from which to free a huge page
+ * helper for free_pool_huge_page() - return the next node
+ * from which to free a huge page. Advance the next node id
+ * whether or not we find a free huge page to free so that the
+ * next attempt to free addresses the next node.
*/
static int hstate_next_node_to_free(struct hstate *h)
{
- int next_nid;
- next_nid = next_node(h->next_nid_to_free, node_online_map);
- if (next_nid == MAX_NUMNODES)
- next_nid = first_node(node_online_map);
+ int nid, next_nid;
+
+ nid = h->next_nid_to_free;
+ next_nid = next_node_allowed(nid);
h->next_nid_to_free = next_nid;
- return next_nid;
+ return nid;
}
/*
@@ -693,7 +711,7 @@ static int free_pool_huge_page(struct hs
int next_nid;
int ret = 0;
- start_nid = h->next_nid_to_free;
+ start_nid = hstate_next_node_to_free(h);
next_nid = start_nid;
do {
@@ -715,9 +733,10 @@ static int free_pool_huge_page(struct hs
}
update_and_free_page(h, page);
ret = 1;
+ break;
}
next_nid = hstate_next_node_to_free(h);
- } while (!ret && next_nid != start_nid);
+ } while (next_nid != start_nid);
return ret;
}
@@ -1028,10 +1047,9 @@ int __weak alloc_bootmem_huge_page(struc
void *addr;
addr = __alloc_bootmem_node_nopanic(
- NODE_DATA(h->next_nid_to_alloc),
+ NODE_DATA(hstate_next_node_to_alloc(h)),
huge_page_size(h), huge_page_size(h), 0);
- hstate_next_node_to_alloc(h);
if (addr) {
/*
* Use the beginning of the huge page to store the
@@ -1167,29 +1185,31 @@ static int adjust_pool_surplus(struct hs
VM_BUG_ON(delta != -1 && delta != 1);
if (delta < 0)
- start_nid = h->next_nid_to_alloc;
+ start_nid = hstate_next_node_to_alloc(h);
else
- start_nid = h->next_nid_to_free;
+ start_nid = hstate_next_node_to_free(h);
next_nid = start_nid;
do {
int nid = next_nid;
if (delta < 0) {
- next_nid = hstate_next_node_to_alloc(h);
/*
* To shrink on this node, there must be a surplus page
*/
- if (!h->surplus_huge_pages_node[nid])
+ if (!h->surplus_huge_pages_node[nid]) {
+ next_nid = hstate_next_node_to_alloc(h);
continue;
+ }
}
if (delta > 0) {
- next_nid = hstate_next_node_to_free(h);
/*
* Surplus cannot exceed the total number of pages
*/
if (h->surplus_huge_pages_node[nid] >=
- h->nr_huge_pages_node[nid])
+ h->nr_huge_pages_node[nid]) {
+ next_nid = hstate_next_node_to_free(h);
continue;
+ }
}
h->surplus_huge_pages += delta;
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 1/4] hugetlb: rework hstate_next_node_* functions
2009-07-29 17:54 ` [PATCH 1/4] hugetlb: rework hstate_next_node_* functions Lee Schermerhorn
@ 2009-07-30 10:40 ` Mel Gorman
0 siblings, 0 replies; 12+ messages in thread
From: Mel Gorman @ 2009-07-30 10:40 UTC (permalink / raw)
To: Lee Schermerhorn
Cc: linux-mm, linux-numa, akpm, Nishanth Aravamudan, andi,
David Rientjes, Adam Litke, Andy Whitcroft, eric.whitney
On Wed, Jul 29, 2009 at 01:54:58PM -0400, Lee Schermerhorn wrote:
> [PATCH 1/4] hugetlb: rework hstate_next_node* functions
>
> Against: 2.6.31-rc3-mmotm-090716-1432
> atop the alloc_bootmem_huge_page() fix patch
> [http://marc.info/?l=linux-mm&m=124775468226290&w=4]
>
> V2:
> + cleaned up comments, removed some deemed unnecessary,
> add some suggested by review
> + removed check for !current in huge_mpol_nodes_allowed().
> + added 'current->comm' to warning message in huge_mpol_nodes_allowed().
> + added VM_BUG_ON() assertion in hugetlb.c next_node_allowed() to
> catch out of range node id.
> + add examples to patch description
>
> V3:
> + factored this "cleanup" patch out of V2 patch 2/3
> + moved ahead of patch to add nodes_allowed mask to alloc funcs
> as this patch is somewhat independent from using task mempolicy
> to control huge page allocation and freeing.
>
> Modify the hstate_next_node* functions to allow them to be called to
> obtain the "start_nid". Then, whereas prior to this patch we
> unconditionally called hstate_next_node_to_{alloc|free}(), whether
> or not we successfully allocated/freed a huge page on the node,
> now we only call these functions on failure to alloc/free.
>
> Factor out the next_node_allowed() function to handle wrap at end
> of node_online_map. In this version, the allowed nodes are all
> of the online nodes.
>
> Signed-off-by: Lee Schermerhorn <lee.schermerhorn@hp.com>
>
Reviewed-by: Mel Gorman <mel@csn.ul.ie>
> mm/hugetlb.c | 70 +++++++++++++++++++++++++++++++++++++----------------------
> 1 file changed, 45 insertions(+), 25 deletions(-)
>
> Index: linux-2.6.31-rc3-mmotm-090716-1432/mm/hugetlb.c
> ===================================================================
> --- linux-2.6.31-rc3-mmotm-090716-1432.orig/mm/hugetlb.c 2009-07-22 15:42:46.000000000 -0400
> +++ linux-2.6.31-rc3-mmotm-090716-1432/mm/hugetlb.c 2009-07-22 15:42:48.000000000 -0400
> @@ -622,6 +622,20 @@ static struct page *alloc_fresh_huge_pag
> }
>
> /*
> + * common helper function for hstate_next_node_to_{alloc|free}.
> + * return next node in node_online_map, wrapping at end.
> + */
> +static int next_node_allowed(int nid)
> +{
> + nid = next_node(nid, node_online_map);
> + if (nid == MAX_NUMNODES)
> + nid = first_node(node_online_map);
> + VM_BUG_ON(nid >= MAX_NUMNODES);
> +
> + return nid;
> +}
> +
> +/*
> * Use a helper variable to find the next node and then
> * copy it back to next_nid_to_alloc afterwards:
> * otherwise there's a window in which a racer might
> @@ -634,12 +648,12 @@ static struct page *alloc_fresh_huge_pag
> */
> static int hstate_next_node_to_alloc(struct hstate *h)
> {
> - int next_nid;
> - next_nid = next_node(h->next_nid_to_alloc, node_online_map);
> - if (next_nid == MAX_NUMNODES)
> - next_nid = first_node(node_online_map);
> + int nid, next_nid;
> +
> + nid = h->next_nid_to_alloc;
> + next_nid = next_node_allowed(nid);
> h->next_nid_to_alloc = next_nid;
> - return next_nid;
> + return nid;
> }
>
> static int alloc_fresh_huge_page(struct hstate *h)
> @@ -649,15 +663,17 @@ static int alloc_fresh_huge_page(struct
> int next_nid;
> int ret = 0;
>
> - start_nid = h->next_nid_to_alloc;
> + start_nid = hstate_next_node_to_alloc(h);
> next_nid = start_nid;
>
> do {
> page = alloc_fresh_huge_page_node(h, next_nid);
> - if (page)
> + if (page) {
> ret = 1;
> + break;
> + }
> next_nid = hstate_next_node_to_alloc(h);
> - } while (!page && next_nid != start_nid);
> + } while (next_nid != start_nid);
>
> if (ret)
> count_vm_event(HTLB_BUDDY_PGALLOC);
> @@ -668,17 +684,19 @@ static int alloc_fresh_huge_page(struct
> }
>
> /*
> - * helper for free_pool_huge_page() - find next node
> - * from which to free a huge page
> + * helper for free_pool_huge_page() - return the next node
> + * from which to free a huge page. Advance the next node id
> + * whether or not we find a free huge page to free so that the
> + * next attempt to free addresses the next node.
> */
> static int hstate_next_node_to_free(struct hstate *h)
> {
> - int next_nid;
> - next_nid = next_node(h->next_nid_to_free, node_online_map);
> - if (next_nid == MAX_NUMNODES)
> - next_nid = first_node(node_online_map);
> + int nid, next_nid;
> +
> + nid = h->next_nid_to_free;
> + next_nid = next_node_allowed(nid);
> h->next_nid_to_free = next_nid;
> - return next_nid;
> + return nid;
> }
>
> /*
> @@ -693,7 +711,7 @@ static int free_pool_huge_page(struct hs
> int next_nid;
> int ret = 0;
>
> - start_nid = h->next_nid_to_free;
> + start_nid = hstate_next_node_to_free(h);
> next_nid = start_nid;
>
> do {
> @@ -715,9 +733,10 @@ static int free_pool_huge_page(struct hs
> }
> update_and_free_page(h, page);
> ret = 1;
> + break;
> }
> next_nid = hstate_next_node_to_free(h);
> - } while (!ret && next_nid != start_nid);
> + } while (next_nid != start_nid);
>
> return ret;
> }
> @@ -1028,10 +1047,9 @@ int __weak alloc_bootmem_huge_page(struc
> void *addr;
>
> addr = __alloc_bootmem_node_nopanic(
> - NODE_DATA(h->next_nid_to_alloc),
> + NODE_DATA(hstate_next_node_to_alloc(h)),
> huge_page_size(h), huge_page_size(h), 0);
>
> - hstate_next_node_to_alloc(h);
> if (addr) {
> /*
> * Use the beginning of the huge page to store the
> @@ -1167,29 +1185,31 @@ static int adjust_pool_surplus(struct hs
> VM_BUG_ON(delta != -1 && delta != 1);
>
> if (delta < 0)
> - start_nid = h->next_nid_to_alloc;
> + start_nid = hstate_next_node_to_alloc(h);
> else
> - start_nid = h->next_nid_to_free;
> + start_nid = hstate_next_node_to_free(h);
> next_nid = start_nid;
>
> do {
> int nid = next_nid;
> if (delta < 0) {
> - next_nid = hstate_next_node_to_alloc(h);
> /*
> * To shrink on this node, there must be a surplus page
> */
> - if (!h->surplus_huge_pages_node[nid])
> + if (!h->surplus_huge_pages_node[nid]) {
> + next_nid = hstate_next_node_to_alloc(h);
> continue;
> + }
> }
> if (delta > 0) {
> - next_nid = hstate_next_node_to_free(h);
> /*
> * Surplus cannot exceed the total number of pages
> */
> if (h->surplus_huge_pages_node[nid] >=
> - h->nr_huge_pages_node[nid])
> + h->nr_huge_pages_node[nid]) {
> + next_nid = hstate_next_node_to_free(h);
> continue;
> + }
> }
>
> h->surplus_huge_pages += delta;
>
--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 2/4] hugetlb: add nodemask arg to huge page alloc, free and surplus adjust fcns
2009-07-29 17:54 [PATCH 0/4] hugetlb: V3 constrain allocation/free based on task mempolicy Lee Schermerhorn
2009-07-29 17:54 ` [PATCH 1/4] hugetlb: rework hstate_next_node_* functions Lee Schermerhorn
@ 2009-07-29 17:55 ` Lee Schermerhorn
2009-07-30 10:49 ` Mel Gorman
2009-07-29 17:55 ` [PATCH 3/4] hugetlb: derive huge pages nodes allowed from task mempolicy Lee Schermerhorn
` (2 subsequent siblings)
4 siblings, 1 reply; 12+ messages in thread
From: Lee Schermerhorn @ 2009-07-29 17:55 UTC (permalink / raw)
To: linux-mm, linux-numa
Cc: akpm, Mel Gorman, Nishanth Aravamudan, andi, David Rientjes,
Adam Litke, Andy Whitcroft, eric.whitney
[PATCH 2/4] hugetlb: add nodemask arg to huge page alloc, free and surplus adjust fcns
Against: 2.6.31-rc3-mmotm-090716-1432
atop the alloc_bootmem_huge_page() fix patch
[http://marc.info/?l=linux-mm&m=124775468226290&w=4]
V3:
+ moved this patch to after the "rework" of hstate_next_node_to_...
functions as this patch is more specific to using task mempolicy
to control huge page allocation and freeing.
In preparation for constraining huge page allocation and freeing by the
controlling task's numa mempolicy, add a "nodes_allowed" nodemask pointer
to the allocate, free and surplus adjustment functions. For now, pass
NULL to indicate default behavior--i.e., use node_online_map. A
subsqeuent patch will derive a non-default mask from the controlling
task's numa mempolicy.
Signed-off-by: Lee Schermerhorn <lee.schermerhorn@hp.com>
mm/hugetlb.c | 102 ++++++++++++++++++++++++++++++++++++++---------------------
1 file changed, 67 insertions(+), 35 deletions(-)
Index: linux-2.6.31-rc3-mmotm-090716-1432/mm/hugetlb.c
===================================================================
--- linux-2.6.31-rc3-mmotm-090716-1432.orig/mm/hugetlb.c 2009-07-28 11:14:58.000000000 -0400
+++ linux-2.6.31-rc3-mmotm-090716-1432/mm/hugetlb.c 2009-07-28 11:23:18.000000000 -0400
@@ -622,19 +622,29 @@ static struct page *alloc_fresh_huge_pag
}
/*
- * common helper function for hstate_next_node_to_{alloc|free}.
- * return next node in node_online_map, wrapping at end.
+ * common helper functions for hstate_next_node_to_{alloc|free}.
+ * We may have allocated or freed a huge pages based on a different
+ * nodes_allowed, previously, so h->next_node_to_{alloc|free} might
+ * be outside of *nodes_allowed. Ensure that we use the next
+ * allowed node for alloc or free.
*/
-static int next_node_allowed(int nid)
+static int next_node_allowed(int nid, nodemask_t *nodes_allowed)
{
- nid = next_node(nid, node_online_map);
+ nid = next_node(nid, *nodes_allowed);
if (nid == MAX_NUMNODES)
- nid = first_node(node_online_map);
+ nid = first_node(*nodes_allowed);
VM_BUG_ON(nid >= MAX_NUMNODES);
return nid;
}
+static int this_node_allowed(int nid, nodemask_t *nodes_allowed)
+{
+ if (!node_isset(nid, *nodes_allowed))
+ nid = next_node_allowed(nid, nodes_allowed);
+ return nid;
+}
+
/*
* Use a helper variable to find the next node and then
* copy it back to next_nid_to_alloc afterwards:
@@ -642,28 +652,34 @@ static int next_node_allowed(int nid)
* pass invalid nid MAX_NUMNODES to alloc_pages_exact_node.
* But we don't need to use a spin_lock here: it really
* doesn't matter if occasionally a racer chooses the
- * same nid as we do. Move nid forward in the mask even
- * if we just successfully allocated a hugepage so that
- * the next caller gets hugepages on the next node.
+ * same nid as we do. Move nid forward in the mask whether
+ * or not we just successfully allocated a hugepage so that
+ * the next allocation addresses the next node.
*/
-static int hstate_next_node_to_alloc(struct hstate *h)
+static int hstate_next_node_to_alloc(struct hstate *h,
+ nodemask_t *nodes_allowed)
{
int nid, next_nid;
- nid = h->next_nid_to_alloc;
- next_nid = next_node_allowed(nid);
+ if (!nodes_allowed)
+ nodes_allowed = &node_online_map;
+
+ nid = this_node_allowed(h->next_nid_to_alloc, nodes_allowed);
+
+ next_nid = next_node_allowed(nid, nodes_allowed);
h->next_nid_to_alloc = next_nid;
+
return nid;
}
-static int alloc_fresh_huge_page(struct hstate *h)
+static int alloc_fresh_huge_page(struct hstate *h, nodemask_t *nodes_allowed)
{
struct page *page;
int start_nid;
int next_nid;
int ret = 0;
- start_nid = hstate_next_node_to_alloc(h);
+ start_nid = hstate_next_node_to_alloc(h, nodes_allowed);
next_nid = start_nid;
do {
@@ -672,7 +688,7 @@ static int alloc_fresh_huge_page(struct
ret = 1;
break;
}
- next_nid = hstate_next_node_to_alloc(h);
+ next_nid = hstate_next_node_to_alloc(h, nodes_allowed);
} while (next_nid != start_nid);
if (ret)
@@ -689,13 +705,18 @@ static int alloc_fresh_huge_page(struct
* whether or not we find a free huge page to free so that the
* next attempt to free addresses the next node.
*/
-static int hstate_next_node_to_free(struct hstate *h)
+static int hstate_next_node_to_free(struct hstate *h, nodemask_t *nodes_allowed)
{
int nid, next_nid;
- nid = h->next_nid_to_free;
- next_nid = next_node_allowed(nid);
+ if (!nodes_allowed)
+ nodes_allowed = &node_online_map;
+
+ nid = this_node_allowed(h->next_nid_to_free, nodes_allowed);
+
+ next_nid = next_node_allowed(nid, nodes_allowed);
h->next_nid_to_free = next_nid;
+
return nid;
}
@@ -705,13 +726,14 @@ static int hstate_next_node_to_free(stru
* balanced over allowed nodes.
* Called with hugetlb_lock locked.
*/
-static int free_pool_huge_page(struct hstate *h, bool acct_surplus)
+static int free_pool_huge_page(struct hstate *h, nodemask_t *nodes_allowed,
+ bool acct_surplus)
{
int start_nid;
int next_nid;
int ret = 0;
- start_nid = hstate_next_node_to_free(h);
+ start_nid = hstate_next_node_to_free(h, nodes_allowed);
next_nid = start_nid;
do {
@@ -735,7 +757,7 @@ static int free_pool_huge_page(struct hs
ret = 1;
break;
}
- next_nid = hstate_next_node_to_free(h);
+ next_nid = hstate_next_node_to_free(h, nodes_allowed);
} while (next_nid != start_nid);
return ret;
@@ -937,7 +959,7 @@ static void return_unused_surplus_pages(
* on-line nodes for us and will handle the hstate accounting.
*/
while (nr_pages--) {
- if (!free_pool_huge_page(h, 1))
+ if (!free_pool_huge_page(h, NULL, 1))
break;
}
}
@@ -1047,7 +1069,7 @@ int __weak alloc_bootmem_huge_page(struc
void *addr;
addr = __alloc_bootmem_node_nopanic(
- NODE_DATA(hstate_next_node_to_alloc(h)),
+ NODE_DATA(hstate_next_node_to_alloc(h, NULL)),
huge_page_size(h), huge_page_size(h), 0);
if (addr) {
@@ -1102,7 +1124,7 @@ static void __init hugetlb_hstate_alloc_
if (h->order >= MAX_ORDER) {
if (!alloc_bootmem_huge_page(h))
break;
- } else if (!alloc_fresh_huge_page(h))
+ } else if (!alloc_fresh_huge_page(h, NULL))
break;
}
h->max_huge_pages = i;
@@ -1144,16 +1166,22 @@ static void __init report_hugepages(void
}
#ifdef CONFIG_HIGHMEM
-static void try_to_free_low(struct hstate *h, unsigned long count)
+static void try_to_free_low(struct hstate *h, unsigned long count,
+ nodemask_t *nodes_allowed)
{
int i;
if (h->order >= MAX_ORDER)
return;
+ if (!nodes_allowed)
+ nodes_allowed = &node_online_map;
+
for (i = 0; i < MAX_NUMNODES; ++i) {
struct page *page, *next;
struct list_head *freel = &h->hugepage_freelists[i];
+ if (!node_isset(i, *nodes_allowed))
+ continue;
list_for_each_entry_safe(page, next, freel, lru) {
if (count >= h->nr_huge_pages)
return;
@@ -1167,7 +1195,8 @@ static void try_to_free_low(struct hstat
}
}
#else
-static inline void try_to_free_low(struct hstate *h, unsigned long count)
+static inline void try_to_free_low(struct hstate *h, unsigned long count,
+ nodemask_t *nodes_allowed)
{
}
#endif
@@ -1177,7 +1206,8 @@ static inline void try_to_free_low(struc
* balanced by operating on them in a round-robin fashion.
* Returns 1 if an adjustment was made.
*/
-static int adjust_pool_surplus(struct hstate *h, int delta)
+static int adjust_pool_surplus(struct hstate *h, nodemask_t *nodes_allowed,
+ int delta)
{
int start_nid, next_nid;
int ret = 0;
@@ -1185,9 +1215,9 @@ static int adjust_pool_surplus(struct hs
VM_BUG_ON(delta != -1 && delta != 1);
if (delta < 0)
- start_nid = hstate_next_node_to_alloc(h);
+ start_nid = hstate_next_node_to_alloc(h, nodes_allowed);
else
- start_nid = hstate_next_node_to_free(h);
+ start_nid = hstate_next_node_to_free(h, nodes_allowed);
next_nid = start_nid;
do {
@@ -1197,7 +1227,8 @@ static int adjust_pool_surplus(struct hs
* To shrink on this node, there must be a surplus page
*/
if (!h->surplus_huge_pages_node[nid]) {
- next_nid = hstate_next_node_to_alloc(h);
+ next_nid = hstate_next_node_to_alloc(h,
+ nodes_allowed);
continue;
}
}
@@ -1207,7 +1238,8 @@ static int adjust_pool_surplus(struct hs
*/
if (h->surplus_huge_pages_node[nid] >=
h->nr_huge_pages_node[nid]) {
- next_nid = hstate_next_node_to_free(h);
+ next_nid = hstate_next_node_to_free(h,
+ nodes_allowed);
continue;
}
}
@@ -1242,7 +1274,7 @@ static unsigned long set_max_huge_pages(
*/
spin_lock(&hugetlb_lock);
while (h->surplus_huge_pages && count > persistent_huge_pages(h)) {
- if (!adjust_pool_surplus(h, -1))
+ if (!adjust_pool_surplus(h, NULL, -1))
break;
}
@@ -1253,7 +1285,7 @@ static unsigned long set_max_huge_pages(
* and reducing the surplus.
*/
spin_unlock(&hugetlb_lock);
- ret = alloc_fresh_huge_page(h);
+ ret = alloc_fresh_huge_page(h, NULL);
spin_lock(&hugetlb_lock);
if (!ret)
goto out;
@@ -1277,13 +1309,13 @@ static unsigned long set_max_huge_pages(
*/
min_count = h->resv_huge_pages + h->nr_huge_pages - h->free_huge_pages;
min_count = max(count, min_count);
- try_to_free_low(h, min_count);
+ try_to_free_low(h, min_count, NULL);
while (min_count < persistent_huge_pages(h)) {
- if (!free_pool_huge_page(h, 0))
+ if (!free_pool_huge_page(h, NULL, 0))
break;
}
while (count < persistent_huge_pages(h)) {
- if (!adjust_pool_surplus(h, 1))
+ if (!adjust_pool_surplus(h, NULL, 1))
break;
}
out:
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 2/4] hugetlb: add nodemask arg to huge page alloc, free and surplus adjust fcns
2009-07-29 17:55 ` [PATCH 2/4] hugetlb: add nodemask arg to huge page alloc, free and surplus adjust fcns Lee Schermerhorn
@ 2009-07-30 10:49 ` Mel Gorman
0 siblings, 0 replies; 12+ messages in thread
From: Mel Gorman @ 2009-07-30 10:49 UTC (permalink / raw)
To: Lee Schermerhorn
Cc: linux-mm, linux-numa, akpm, Nishanth Aravamudan, andi,
David Rientjes, Adam Litke, Andy Whitcroft, eric.whitney
On Wed, Jul 29, 2009 at 01:55:05PM -0400, Lee Schermerhorn wrote:
> [PATCH 2/4] hugetlb: add nodemask arg to huge page alloc, free and surplus adjust fcns
>
> Against: 2.6.31-rc3-mmotm-090716-1432
> atop the alloc_bootmem_huge_page() fix patch
> [http://marc.info/?l=linux-mm&m=124775468226290&w=4]
>
> V3:
> + moved this patch to after the "rework" of hstate_next_node_to_...
> functions as this patch is more specific to using task mempolicy
> to control huge page allocation and freeing.
>
> In preparation for constraining huge page allocation and freeing by the
> controlling task's numa mempolicy, add a "nodes_allowed" nodemask pointer
> to the allocate, free and surplus adjustment functions. For now, pass
> NULL to indicate default behavior--i.e., use node_online_map. A
> subsqeuent patch will derive a non-default mask from the controlling
> task's numa mempolicy.
>
> Signed-off-by: Lee Schermerhorn <lee.schermerhorn@hp.com>
>
Reviewed-by: Mel Gorman <mel@csn.ul.ie>
> mm/hugetlb.c | 102 ++++++++++++++++++++++++++++++++++++++---------------------
> 1 file changed, 67 insertions(+), 35 deletions(-)
>
> Index: linux-2.6.31-rc3-mmotm-090716-1432/mm/hugetlb.c
> ===================================================================
> --- linux-2.6.31-rc3-mmotm-090716-1432.orig/mm/hugetlb.c 2009-07-28 11:14:58.000000000 -0400
> +++ linux-2.6.31-rc3-mmotm-090716-1432/mm/hugetlb.c 2009-07-28 11:23:18.000000000 -0400
> @@ -622,19 +622,29 @@ static struct page *alloc_fresh_huge_pag
> }
>
> /*
> - * common helper function for hstate_next_node_to_{alloc|free}.
> - * return next node in node_online_map, wrapping at end.
> + * common helper functions for hstate_next_node_to_{alloc|free}.
> + * We may have allocated or freed a huge pages based on a different
> + * nodes_allowed, previously, so h->next_node_to_{alloc|free} might
> + * be outside of *nodes_allowed. Ensure that we use the next
> + * allowed node for alloc or free.
> */
> -static int next_node_allowed(int nid)
> +static int next_node_allowed(int nid, nodemask_t *nodes_allowed)
> {
> - nid = next_node(nid, node_online_map);
> + nid = next_node(nid, *nodes_allowed);
> if (nid == MAX_NUMNODES)
> - nid = first_node(node_online_map);
> + nid = first_node(*nodes_allowed);
> VM_BUG_ON(nid >= MAX_NUMNODES);
>
> return nid;
> }
>
> +static int this_node_allowed(int nid, nodemask_t *nodes_allowed)
> +{
> + if (!node_isset(nid, *nodes_allowed))
> + nid = next_node_allowed(nid, nodes_allowed);
> + return nid;
> +}
> +
> /*
> * Use a helper variable to find the next node and then
> * copy it back to next_nid_to_alloc afterwards:
> @@ -642,28 +652,34 @@ static int next_node_allowed(int nid)
> * pass invalid nid MAX_NUMNODES to alloc_pages_exact_node.
> * But we don't need to use a spin_lock here: it really
> * doesn't matter if occasionally a racer chooses the
> - * same nid as we do. Move nid forward in the mask even
> - * if we just successfully allocated a hugepage so that
> - * the next caller gets hugepages on the next node.
> + * same nid as we do. Move nid forward in the mask whether
> + * or not we just successfully allocated a hugepage so that
> + * the next allocation addresses the next node.
> */
> -static int hstate_next_node_to_alloc(struct hstate *h)
> +static int hstate_next_node_to_alloc(struct hstate *h,
> + nodemask_t *nodes_allowed)
> {
> int nid, next_nid;
>
> - nid = h->next_nid_to_alloc;
> - next_nid = next_node_allowed(nid);
> + if (!nodes_allowed)
> + nodes_allowed = &node_online_map;
> +
> + nid = this_node_allowed(h->next_nid_to_alloc, nodes_allowed);
> +
> + next_nid = next_node_allowed(nid, nodes_allowed);
> h->next_nid_to_alloc = next_nid;
> +
> return nid;
> }
>
> -static int alloc_fresh_huge_page(struct hstate *h)
> +static int alloc_fresh_huge_page(struct hstate *h, nodemask_t *nodes_allowed)
> {
> struct page *page;
> int start_nid;
> int next_nid;
> int ret = 0;
>
> - start_nid = hstate_next_node_to_alloc(h);
> + start_nid = hstate_next_node_to_alloc(h, nodes_allowed);
> next_nid = start_nid;
>
> do {
> @@ -672,7 +688,7 @@ static int alloc_fresh_huge_page(struct
> ret = 1;
> break;
> }
> - next_nid = hstate_next_node_to_alloc(h);
> + next_nid = hstate_next_node_to_alloc(h, nodes_allowed);
> } while (next_nid != start_nid);
>
> if (ret)
> @@ -689,13 +705,18 @@ static int alloc_fresh_huge_page(struct
> * whether or not we find a free huge page to free so that the
> * next attempt to free addresses the next node.
> */
> -static int hstate_next_node_to_free(struct hstate *h)
> +static int hstate_next_node_to_free(struct hstate *h, nodemask_t *nodes_allowed)
> {
> int nid, next_nid;
>
> - nid = h->next_nid_to_free;
> - next_nid = next_node_allowed(nid);
> + if (!nodes_allowed)
> + nodes_allowed = &node_online_map;
> +
> + nid = this_node_allowed(h->next_nid_to_free, nodes_allowed);
> +
> + next_nid = next_node_allowed(nid, nodes_allowed);
> h->next_nid_to_free = next_nid;
> +
> return nid;
> }
>
> @@ -705,13 +726,14 @@ static int hstate_next_node_to_free(stru
> * balanced over allowed nodes.
> * Called with hugetlb_lock locked.
> */
> -static int free_pool_huge_page(struct hstate *h, bool acct_surplus)
> +static int free_pool_huge_page(struct hstate *h, nodemask_t *nodes_allowed,
> + bool acct_surplus)
> {
> int start_nid;
> int next_nid;
> int ret = 0;
>
> - start_nid = hstate_next_node_to_free(h);
> + start_nid = hstate_next_node_to_free(h, nodes_allowed);
> next_nid = start_nid;
>
> do {
> @@ -735,7 +757,7 @@ static int free_pool_huge_page(struct hs
> ret = 1;
> break;
> }
> - next_nid = hstate_next_node_to_free(h);
> + next_nid = hstate_next_node_to_free(h, nodes_allowed);
> } while (next_nid != start_nid);
>
> return ret;
> @@ -937,7 +959,7 @@ static void return_unused_surplus_pages(
> * on-line nodes for us and will handle the hstate accounting.
> */
> while (nr_pages--) {
> - if (!free_pool_huge_page(h, 1))
> + if (!free_pool_huge_page(h, NULL, 1))
> break;
> }
> }
> @@ -1047,7 +1069,7 @@ int __weak alloc_bootmem_huge_page(struc
> void *addr;
>
> addr = __alloc_bootmem_node_nopanic(
> - NODE_DATA(hstate_next_node_to_alloc(h)),
> + NODE_DATA(hstate_next_node_to_alloc(h, NULL)),
> huge_page_size(h), huge_page_size(h), 0);
>
> if (addr) {
> @@ -1102,7 +1124,7 @@ static void __init hugetlb_hstate_alloc_
> if (h->order >= MAX_ORDER) {
> if (!alloc_bootmem_huge_page(h))
> break;
> - } else if (!alloc_fresh_huge_page(h))
> + } else if (!alloc_fresh_huge_page(h, NULL))
> break;
> }
> h->max_huge_pages = i;
> @@ -1144,16 +1166,22 @@ static void __init report_hugepages(void
> }
>
> #ifdef CONFIG_HIGHMEM
> -static void try_to_free_low(struct hstate *h, unsigned long count)
> +static void try_to_free_low(struct hstate *h, unsigned long count,
> + nodemask_t *nodes_allowed)
> {
> int i;
>
> if (h->order >= MAX_ORDER)
> return;
>
> + if (!nodes_allowed)
> + nodes_allowed = &node_online_map;
> +
> for (i = 0; i < MAX_NUMNODES; ++i) {
> struct page *page, *next;
> struct list_head *freel = &h->hugepage_freelists[i];
> + if (!node_isset(i, *nodes_allowed))
> + continue;
> list_for_each_entry_safe(page, next, freel, lru) {
> if (count >= h->nr_huge_pages)
> return;
> @@ -1167,7 +1195,8 @@ static void try_to_free_low(struct hstat
> }
> }
> #else
> -static inline void try_to_free_low(struct hstate *h, unsigned long count)
> +static inline void try_to_free_low(struct hstate *h, unsigned long count,
> + nodemask_t *nodes_allowed)
> {
> }
> #endif
> @@ -1177,7 +1206,8 @@ static inline void try_to_free_low(struc
> * balanced by operating on them in a round-robin fashion.
> * Returns 1 if an adjustment was made.
> */
> -static int adjust_pool_surplus(struct hstate *h, int delta)
> +static int adjust_pool_surplus(struct hstate *h, nodemask_t *nodes_allowed,
> + int delta)
> {
> int start_nid, next_nid;
> int ret = 0;
> @@ -1185,9 +1215,9 @@ static int adjust_pool_surplus(struct hs
> VM_BUG_ON(delta != -1 && delta != 1);
>
> if (delta < 0)
> - start_nid = hstate_next_node_to_alloc(h);
> + start_nid = hstate_next_node_to_alloc(h, nodes_allowed);
> else
> - start_nid = hstate_next_node_to_free(h);
> + start_nid = hstate_next_node_to_free(h, nodes_allowed);
> next_nid = start_nid;
>
> do {
> @@ -1197,7 +1227,8 @@ static int adjust_pool_surplus(struct hs
> * To shrink on this node, there must be a surplus page
> */
> if (!h->surplus_huge_pages_node[nid]) {
> - next_nid = hstate_next_node_to_alloc(h);
> + next_nid = hstate_next_node_to_alloc(h,
> + nodes_allowed);
> continue;
> }
> }
> @@ -1207,7 +1238,8 @@ static int adjust_pool_surplus(struct hs
> */
> if (h->surplus_huge_pages_node[nid] >=
> h->nr_huge_pages_node[nid]) {
> - next_nid = hstate_next_node_to_free(h);
> + next_nid = hstate_next_node_to_free(h,
> + nodes_allowed);
> continue;
> }
> }
> @@ -1242,7 +1274,7 @@ static unsigned long set_max_huge_pages(
> */
> spin_lock(&hugetlb_lock);
> while (h->surplus_huge_pages && count > persistent_huge_pages(h)) {
> - if (!adjust_pool_surplus(h, -1))
> + if (!adjust_pool_surplus(h, NULL, -1))
> break;
> }
>
> @@ -1253,7 +1285,7 @@ static unsigned long set_max_huge_pages(
> * and reducing the surplus.
> */
> spin_unlock(&hugetlb_lock);
> - ret = alloc_fresh_huge_page(h);
> + ret = alloc_fresh_huge_page(h, NULL);
> spin_lock(&hugetlb_lock);
> if (!ret)
> goto out;
> @@ -1277,13 +1309,13 @@ static unsigned long set_max_huge_pages(
> */
> min_count = h->resv_huge_pages + h->nr_huge_pages - h->free_huge_pages;
> min_count = max(count, min_count);
> - try_to_free_low(h, min_count);
> + try_to_free_low(h, min_count, NULL);
> while (min_count < persistent_huge_pages(h)) {
> - if (!free_pool_huge_page(h, 0))
> + if (!free_pool_huge_page(h, NULL, 0))
> break;
> }
> while (count < persistent_huge_pages(h)) {
> - if (!adjust_pool_surplus(h, 1))
> + if (!adjust_pool_surplus(h, NULL, 1))
> break;
> }
> out:
>
--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 3/4] hugetlb: derive huge pages nodes allowed from task mempolicy
2009-07-29 17:54 [PATCH 0/4] hugetlb: V3 constrain allocation/free based on task mempolicy Lee Schermerhorn
2009-07-29 17:54 ` [PATCH 1/4] hugetlb: rework hstate_next_node_* functions Lee Schermerhorn
2009-07-29 17:55 ` [PATCH 2/4] hugetlb: add nodemask arg to huge page alloc, free and surplus adjust fcns Lee Schermerhorn
@ 2009-07-29 17:55 ` Lee Schermerhorn
2009-07-30 11:15 ` Mel Gorman
2009-07-29 17:55 ` [PATCH 4/4] hugetlb: update hugetlb documentation for mempolicy based management Lee Schermerhorn
2009-07-30 11:18 ` [PATCH 0/4] hugetlb: V3 constrain allocation/free based on task mempolicy Mel Gorman
4 siblings, 1 reply; 12+ messages in thread
From: Lee Schermerhorn @ 2009-07-29 17:55 UTC (permalink / raw)
To: linux-mm, linux-numa
Cc: akpm, Mel Gorman, Nishanth Aravamudan, andi, David Rientjes,
Adam Litke, Andy Whitcroft, eric.whitney
[PATCH 3/4] hugetlb: derive huge pages nodes allowed from task mempolicy
Against: 2.6.31-rc3-mmotm-090716-1432
atop the alloc_bootmem_huge_page() fix patch
[http://marc.info/?l=linux-mm&m=124775468226290&w=4]
V2:
+ cleaned up comments, removed some deemed unnecessary,
add some suggested by review
+ removed check for !current in huge_mpol_nodes_allowed().
+ added 'current->comm' to warning message in huge_mpol_nodes_allowed().
+ added VM_BUG_ON() assertion in hugetlb.c next_node_allowed() to
catch out of range node id.
+ add examples to patch description
V3: Factored this patch from V2 patch 2/3
This patch derives a "nodes_allowed" node mask from the numa
mempolicy of the task modifying the number of persistent huge
pages to control the allocation, freeing and adjusting of surplus
huge pages. This mask is derived as follows:
* For "default" [NULL] task mempolicy, a NULL nodemask_t pointer
is produced. This will cause the hugetlb subsystem to use
node_online_map as the "nodes_allowed". This preserves the
behavior before this patch.
* For "preferred" mempolicy, including explicit local allocation,
a nodemask with the single preferred node will be produced.
"local" policy will NOT track any internode migrations of the
task adjusting nr_hugepages.
* For "bind" and "interleave" policy, the mempolicy's nodemask
will be used.
* Other than to inform the construction of the nodes_allowed node
mask, the actual mempolicy mode is ignored. That is, all modes
behave like interleave over the resulting nodes_allowed mask
with no "fallback".
Notes:
1) This patch introduces a subtle change in behavior: huge page
allocation and freeing will be constrained by any mempolicy
that the task adjusting the huge page pool inherits from its
parent. This policy could come from a distant ancestor. The
adminstrator adjusting the huge page pool without explicitly
specifying a mempolicy via numactl might be surprised by this.
Additionaly, any mempolicy specified by numactl will be
constrained by the cpuset in which numactl is invoked.
2) Hugepages allocated at boot time use the node_online_map.
An additional patch could implement a temporary boot time
huge pages nodes_allowed command line parameter.
3) Using mempolicy to control persistent huge page allocation
and freeing requires no change to hugeadm when invoking
it via numactl, as shown in the examples below. However,
hugeadm could be enhanced to take the allowed nodes as an
argument and set its task mempolicy itself. This would allow
it to detect and warn about any non-default mempolicy that it
inherited from its parent, thus alleviating the issue described
in Note 1 above.
See the updated documentation [next patch] for more information
about the implications of this patch.
Examples:
Starting with:
Node 0 HugePages_Total: 0
Node 1 HugePages_Total: 0
Node 2 HugePages_Total: 0
Node 3 HugePages_Total: 0
Default behavior [with or without this patch] balances persistent
hugepage allocation across nodes [with sufficient contiguous memory]:
hugeadm --pool-pages-min=2048Kb:32
yields:
Node 0 HugePages_Total: 8
Node 1 HugePages_Total: 8
Node 2 HugePages_Total: 8
Node 3 HugePages_Total: 8
Applying mempolicy--e.g., with numactl [using '-m' a.k.a.
'--membind' because it allows multiple nodes to be specified
and it's easy to type]--we can allocate huge pages on
individual nodes or sets of nodes. So, starting from the
condition above, with 8 huge pages per node:
numactl -m 2 hugeadm --pool-pages-min=2048Kb:+8
yields:
Node 0 HugePages_Total: 8
Node 1 HugePages_Total: 8
Node 2 HugePages_Total: 16
Node 3 HugePages_Total: 8
The incremental 8 huge pages were restricted to node 2 by the
specified mempolicy.
Similarly, we can use mempolicy to free persistent huge pages
from specified nodes:
numactl -m 0,1 hugeadm --pool-pages-min=2048Kb:-8
yields:
Node 0 HugePages_Total: 4
Node 1 HugePages_Total: 4
Node 2 HugePages_Total: 16
Node 3 HugePages_Total: 8
The 8 huge pages freed were balanced over nodes 0 and 1.
Signed-off-by: Lee Schermerhorn <lee.schermerhorn@hp.com>
include/linux/mempolicy.h | 3 ++
mm/hugetlb.c | 13 ++++++---
mm/mempolicy.c | 61 ++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 72 insertions(+), 5 deletions(-)
Index: linux-2.6.31-rc3-mmotm-090716-1432/mm/mempolicy.c
===================================================================
--- linux-2.6.31-rc3-mmotm-090716-1432.orig/mm/mempolicy.c 2009-07-28 11:15:10.000000000 -0400
+++ linux-2.6.31-rc3-mmotm-090716-1432/mm/mempolicy.c 2009-07-28 11:23:43.000000000 -0400
@@ -1544,6 +1544,67 @@ struct zonelist *huge_zonelist(struct vm
}
return zl;
}
+
+/*
+ * huge_mpol_nodes_allowed -- mempolicy extension for huge pages.
+ *
+ * Returns a [pointer to a] nodelist based on the current task's mempolicy
+ * to constraing the allocation and freeing of persistent huge pages
+ * 'Preferred', 'local' and 'interleave' mempolicy will behave more like
+ * 'bind' policy in this context. An attempt to allocate a persistent huge
+ * page will never "fallback" to another node inside the buddy system
+ * allocator.
+ *
+ * If the task's mempolicy is "default" [NULL], just return NULL for
+ * default behavior. Otherwise, extract the policy nodemask for 'bind'
+ * or 'interleave' policy or construct a nodemask for 'preferred' or
+ * 'local' policy and return a pointer to a kmalloc()ed nodemask_t.
+ *
+ * N.B., it is the caller's responsibility to free a returned nodemask.
+ */
+nodemask_t *huge_mpol_nodes_allowed(void)
+{
+ nodemask_t *nodes_allowed = NULL;
+ struct mempolicy *mempolicy;
+ int nid;
+
+ if (!current->mempolicy)
+ return NULL;
+
+ mpol_get(current->mempolicy);
+ nodes_allowed = kmalloc(sizeof(*nodes_allowed), GFP_KERNEL);
+ if (!nodes_allowed) {
+ printk(KERN_WARNING "%s unable to allocate nodes allowed mask "
+ "for huge page allocation.\nFalling back to default.\n",
+ current->comm);
+ goto out;
+ }
+ nodes_clear(*nodes_allowed);
+
+ mempolicy = current->mempolicy;
+ switch (mempolicy->mode) {
+ case MPOL_PREFERRED:
+ if (mempolicy->flags & MPOL_F_LOCAL)
+ nid = numa_node_id();
+ else
+ nid = mempolicy->v.preferred_node;
+ node_set(nid, *nodes_allowed);
+ break;
+
+ case MPOL_BIND:
+ /* Fall through */
+ case MPOL_INTERLEAVE:
+ *nodes_allowed = mempolicy->v.nodes;
+ break;
+
+ default:
+ BUG();
+ }
+
+out:
+ mpol_put(current->mempolicy);
+ return nodes_allowed;
+}
#endif
/* Allocate a page in interleaved policy.
Index: linux-2.6.31-rc3-mmotm-090716-1432/include/linux/mempolicy.h
===================================================================
--- linux-2.6.31-rc3-mmotm-090716-1432.orig/include/linux/mempolicy.h 2009-07-28 11:15:10.000000000 -0400
+++ linux-2.6.31-rc3-mmotm-090716-1432/include/linux/mempolicy.h 2009-07-28 11:23:43.000000000 -0400
@@ -201,6 +201,7 @@ extern void mpol_fix_fork_child_flag(str
extern struct zonelist *huge_zonelist(struct vm_area_struct *vma,
unsigned long addr, gfp_t gfp_flags,
struct mempolicy **mpol, nodemask_t **nodemask);
+extern nodemask_t *huge_mpol_nodes_allowed(void);
extern unsigned slab_node(struct mempolicy *policy);
extern enum zone_type policy_zone;
@@ -328,6 +329,8 @@ static inline struct zonelist *huge_zone
return node_zonelist(0, gfp_flags);
}
+static inline nodemask_t *huge_mpol_nodes_allowed(void) { return NULL; }
+
static inline int do_migrate_pages(struct mm_struct *mm,
const nodemask_t *from_nodes,
const nodemask_t *to_nodes, int flags)
Index: linux-2.6.31-rc3-mmotm-090716-1432/mm/hugetlb.c
===================================================================
--- linux-2.6.31-rc3-mmotm-090716-1432.orig/mm/hugetlb.c 2009-07-28 11:23:18.000000000 -0400
+++ linux-2.6.31-rc3-mmotm-090716-1432/mm/hugetlb.c 2009-07-28 11:24:43.000000000 -0400
@@ -1257,10 +1257,13 @@ static int adjust_pool_surplus(struct hs
static unsigned long set_max_huge_pages(struct hstate *h, unsigned long count)
{
unsigned long min_count, ret;
+ nodemask_t *nodes_allowed;
if (h->order >= MAX_ORDER)
return h->max_huge_pages;
+ nodes_allowed = huge_mpol_nodes_allowed();
+
/*
* Increase the pool size
* First take pages out of surplus state. Then make up the
@@ -1274,7 +1277,7 @@ static unsigned long set_max_huge_pages(
*/
spin_lock(&hugetlb_lock);
while (h->surplus_huge_pages && count > persistent_huge_pages(h)) {
- if (!adjust_pool_surplus(h, NULL, -1))
+ if (!adjust_pool_surplus(h, nodes_allowed, -1))
break;
}
@@ -1285,7 +1288,7 @@ static unsigned long set_max_huge_pages(
* and reducing the surplus.
*/
spin_unlock(&hugetlb_lock);
- ret = alloc_fresh_huge_page(h, NULL);
+ ret = alloc_fresh_huge_page(h, nodes_allowed);
spin_lock(&hugetlb_lock);
if (!ret)
goto out;
@@ -1309,13 +1312,13 @@ static unsigned long set_max_huge_pages(
*/
min_count = h->resv_huge_pages + h->nr_huge_pages - h->free_huge_pages;
min_count = max(count, min_count);
- try_to_free_low(h, min_count, NULL);
+ try_to_free_low(h, min_count, nodes_allowed);
while (min_count < persistent_huge_pages(h)) {
- if (!free_pool_huge_page(h, NULL, 0))
+ if (!free_pool_huge_page(h, nodes_allowed, 0))
break;
}
while (count < persistent_huge_pages(h)) {
- if (!adjust_pool_surplus(h, NULL, 1))
+ if (!adjust_pool_surplus(h, nodes_allowed, 1))
break;
}
out:
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 3/4] hugetlb: derive huge pages nodes allowed from task mempolicy
2009-07-29 17:55 ` [PATCH 3/4] hugetlb: derive huge pages nodes allowed from task mempolicy Lee Schermerhorn
@ 2009-07-30 11:15 ` Mel Gorman
2009-07-31 18:49 ` Lee Schermerhorn
0 siblings, 1 reply; 12+ messages in thread
From: Mel Gorman @ 2009-07-30 11:15 UTC (permalink / raw)
To: Lee Schermerhorn
Cc: linux-mm, linux-numa, akpm, Nishanth Aravamudan, andi,
David Rientjes, Adam Litke, Andy Whitcroft, eric.whitney
On Wed, Jul 29, 2009 at 01:55:11PM -0400, Lee Schermerhorn wrote:
> [PATCH 3/4] hugetlb: derive huge pages nodes allowed from task mempolicy
>
> Against: 2.6.31-rc3-mmotm-090716-1432
> atop the alloc_bootmem_huge_page() fix patch
> [http://marc.info/?l=linux-mm&m=124775468226290&w=4]
>
> V2:
> + cleaned up comments, removed some deemed unnecessary,
> add some suggested by review
> + removed check for !current in huge_mpol_nodes_allowed().
> + added 'current->comm' to warning message in huge_mpol_nodes_allowed().
> + added VM_BUG_ON() assertion in hugetlb.c next_node_allowed() to
> catch out of range node id.
> + add examples to patch description
>
> V3: Factored this patch from V2 patch 2/3
>
> This patch derives a "nodes_allowed" node mask from the numa
> mempolicy of the task modifying the number of persistent huge
> pages to control the allocation, freeing and adjusting of surplus
> huge pages. This mask is derived as follows:
>
> * For "default" [NULL] task mempolicy, a NULL nodemask_t pointer
> is produced. This will cause the hugetlb subsystem to use
> node_online_map as the "nodes_allowed". This preserves the
> behavior before this patch.
> * For "preferred" mempolicy, including explicit local allocation,
> a nodemask with the single preferred node will be produced.
> "local" policy will NOT track any internode migrations of the
> task adjusting nr_hugepages.
> * For "bind" and "interleave" policy, the mempolicy's nodemask
> will be used.
> * Other than to inform the construction of the nodes_allowed node
> mask, the actual mempolicy mode is ignored. That is, all modes
> behave like interleave over the resulting nodes_allowed mask
> with no "fallback".
>
> Notes:
>
> 1) This patch introduces a subtle change in behavior: huge page
> allocation and freeing will be constrained by any mempolicy
> that the task adjusting the huge page pool inherits from its
> parent. This policy could come from a distant ancestor. The
> adminstrator adjusting the huge page pool without explicitly
> specifying a mempolicy via numactl might be surprised by this.
> Additionaly, any mempolicy specified by numactl will be
> constrained by the cpuset in which numactl is invoked.
>
> 2) Hugepages allocated at boot time use the node_online_map.
> An additional patch could implement a temporary boot time
> huge pages nodes_allowed command line parameter.
>
> 3) Using mempolicy to control persistent huge page allocation
> and freeing requires no change to hugeadm when invoking
> it via numactl, as shown in the examples below. However,
> hugeadm could be enhanced to take the allowed nodes as an
> argument and set its task mempolicy itself. This would allow
> it to detect and warn about any non-default mempolicy that it
> inherited from its parent, thus alleviating the issue described
> in Note 1 above.
>
> See the updated documentation [next patch] for more information
> about the implications of this patch.
>
> Examples:
>
> Starting with:
>
> Node 0 HugePages_Total: 0
> Node 1 HugePages_Total: 0
> Node 2 HugePages_Total: 0
> Node 3 HugePages_Total: 0
>
> Default behavior [with or without this patch] balances persistent
> hugepage allocation across nodes [with sufficient contiguous memory]:
>
> hugeadm --pool-pages-min=2048Kb:32
>
> yields:
>
> Node 0 HugePages_Total: 8
> Node 1 HugePages_Total: 8
> Node 2 HugePages_Total: 8
> Node 3 HugePages_Total: 8
>
> Applying mempolicy--e.g., with numactl [using '-m' a.k.a.
> '--membind' because it allows multiple nodes to be specified
> and it's easy to type]--we can allocate huge pages on
> individual nodes or sets of nodes. So, starting from the
> condition above, with 8 huge pages per node:
>
> numactl -m 2 hugeadm --pool-pages-min=2048Kb:+8
>
> yields:
>
> Node 0 HugePages_Total: 8
> Node 1 HugePages_Total: 8
> Node 2 HugePages_Total: 16
> Node 3 HugePages_Total: 8
>
> The incremental 8 huge pages were restricted to node 2 by the
> specified mempolicy.
>
> Similarly, we can use mempolicy to free persistent huge pages
> from specified nodes:
>
> numactl -m 0,1 hugeadm --pool-pages-min=2048Kb:-8
>
> yields:
>
> Node 0 HugePages_Total: 4
> Node 1 HugePages_Total: 4
> Node 2 HugePages_Total: 16
> Node 3 HugePages_Total: 8
>
> The 8 huge pages freed were balanced over nodes 0 and 1.
>
> Signed-off-by: Lee Schermerhorn <lee.schermerhorn@hp.com>
>
> include/linux/mempolicy.h | 3 ++
> mm/hugetlb.c | 13 ++++++---
> mm/mempolicy.c | 61 ++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 72 insertions(+), 5 deletions(-)
>
> Index: linux-2.6.31-rc3-mmotm-090716-1432/mm/mempolicy.c
> ===================================================================
> --- linux-2.6.31-rc3-mmotm-090716-1432.orig/mm/mempolicy.c 2009-07-28 11:15:10.000000000 -0400
> +++ linux-2.6.31-rc3-mmotm-090716-1432/mm/mempolicy.c 2009-07-28 11:23:43.000000000 -0400
> @@ -1544,6 +1544,67 @@ struct zonelist *huge_zonelist(struct vm
> }
> return zl;
> }
> +
> +/*
> + * huge_mpol_nodes_allowed -- mempolicy extension for huge pages.
> + *
> + * Returns a [pointer to a] nodelist based on the current task's mempolicy
> + * to constraing the allocation and freeing of persistent huge pages
> + * 'Preferred', 'local' and 'interleave' mempolicy will behave more like
> + * 'bind' policy in this context. An attempt to allocate a persistent huge
> + * page will never "fallback" to another node inside the buddy system
> + * allocator.
> + *
> + * If the task's mempolicy is "default" [NULL], just return NULL for
> + * default behavior. Otherwise, extract the policy nodemask for 'bind'
> + * or 'interleave' policy or construct a nodemask for 'preferred' or
> + * 'local' policy and return a pointer to a kmalloc()ed nodemask_t.
> + *
> + * N.B., it is the caller's responsibility to free a returned nodemask.
> + */
> +nodemask_t *huge_mpol_nodes_allowed(void)
> +{
> + nodemask_t *nodes_allowed = NULL;
> + struct mempolicy *mempolicy;
> + int nid;
> +
> + if (!current->mempolicy)
> + return NULL;
> +
> + mpol_get(current->mempolicy);
> + nodes_allowed = kmalloc(sizeof(*nodes_allowed), GFP_KERNEL);
> + if (!nodes_allowed) {
> + printk(KERN_WARNING "%s unable to allocate nodes allowed mask "
> + "for huge page allocation.\nFalling back to default.\n",
> + current->comm);
> + goto out;
> + }
> + nodes_clear(*nodes_allowed);
> +
> + mempolicy = current->mempolicy;
> + switch (mempolicy->mode) {
> + case MPOL_PREFERRED:
> + if (mempolicy->flags & MPOL_F_LOCAL)
> + nid = numa_node_id();
> + else
> + nid = mempolicy->v.preferred_node;
> + node_set(nid, *nodes_allowed);
> + break;
> +
> + case MPOL_BIND:
> + /* Fall through */
> + case MPOL_INTERLEAVE:
> + *nodes_allowed = mempolicy->v.nodes;
> + break;
> +
> + default:
> + BUG();
> + }
> +
> +out:
> + mpol_put(current->mempolicy);
> + return nodes_allowed;
> +}
> #endif
>
> /* Allocate a page in interleaved policy.
> Index: linux-2.6.31-rc3-mmotm-090716-1432/include/linux/mempolicy.h
> ===================================================================
> --- linux-2.6.31-rc3-mmotm-090716-1432.orig/include/linux/mempolicy.h 2009-07-28 11:15:10.000000000 -0400
> +++ linux-2.6.31-rc3-mmotm-090716-1432/include/linux/mempolicy.h 2009-07-28 11:23:43.000000000 -0400
> @@ -201,6 +201,7 @@ extern void mpol_fix_fork_child_flag(str
> extern struct zonelist *huge_zonelist(struct vm_area_struct *vma,
> unsigned long addr, gfp_t gfp_flags,
> struct mempolicy **mpol, nodemask_t **nodemask);
> +extern nodemask_t *huge_mpol_nodes_allowed(void);
> extern unsigned slab_node(struct mempolicy *policy);
>
> extern enum zone_type policy_zone;
> @@ -328,6 +329,8 @@ static inline struct zonelist *huge_zone
> return node_zonelist(0, gfp_flags);
> }
>
> +static inline nodemask_t *huge_mpol_nodes_allowed(void) { return NULL; }
> +
> static inline int do_migrate_pages(struct mm_struct *mm,
> const nodemask_t *from_nodes,
> const nodemask_t *to_nodes, int flags)
> Index: linux-2.6.31-rc3-mmotm-090716-1432/mm/hugetlb.c
> ===================================================================
> --- linux-2.6.31-rc3-mmotm-090716-1432.orig/mm/hugetlb.c 2009-07-28 11:23:18.000000000 -0400
> +++ linux-2.6.31-rc3-mmotm-090716-1432/mm/hugetlb.c 2009-07-28 11:24:43.000000000 -0400
> @@ -1257,10 +1257,13 @@ static int adjust_pool_surplus(struct hs
> static unsigned long set_max_huge_pages(struct hstate *h, unsigned long count)
> {
> unsigned long min_count, ret;
> + nodemask_t *nodes_allowed;
>
> if (h->order >= MAX_ORDER)
> return h->max_huge_pages;
>
> + nodes_allowed = huge_mpol_nodes_allowed();
> +
> /*
> * Increase the pool size
> * First take pages out of surplus state. Then make up the
> @@ -1274,7 +1277,7 @@ static unsigned long set_max_huge_pages(
> */
> spin_lock(&hugetlb_lock);
> while (h->surplus_huge_pages && count > persistent_huge_pages(h)) {
> - if (!adjust_pool_surplus(h, NULL, -1))
> + if (!adjust_pool_surplus(h, nodes_allowed, -1))
> break;
> }
>
> @@ -1285,7 +1288,7 @@ static unsigned long set_max_huge_pages(
> * and reducing the surplus.
> */
> spin_unlock(&hugetlb_lock);
> - ret = alloc_fresh_huge_page(h, NULL);
> + ret = alloc_fresh_huge_page(h, nodes_allowed);
> spin_lock(&hugetlb_lock);
> if (!ret)
> goto out;
> @@ -1309,13 +1312,13 @@ static unsigned long set_max_huge_pages(
> */
> min_count = h->resv_huge_pages + h->nr_huge_pages - h->free_huge_pages;
> min_count = max(count, min_count);
> - try_to_free_low(h, min_count, NULL);
> + try_to_free_low(h, min_count, nodes_allowed);
> while (min_count < persistent_huge_pages(h)) {
> - if (!free_pool_huge_page(h, NULL, 0))
> + if (!free_pool_huge_page(h, nodes_allowed, 0))
> break;
> }
> while (count < persistent_huge_pages(h)) {
> - if (!adjust_pool_surplus(h, NULL, 1))
> + if (!adjust_pool_surplus(h, nodes_allowed, 1))
> break;
> }
> out:
Where did the hunk go that calls kfree(nodes_allowed)? I think we might
be leaking in this version.
Otherwise it looks good.
--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 3/4] hugetlb: derive huge pages nodes allowed from task mempolicy
2009-07-30 11:15 ` Mel Gorman
@ 2009-07-31 18:49 ` Lee Schermerhorn
0 siblings, 0 replies; 12+ messages in thread
From: Lee Schermerhorn @ 2009-07-31 18:49 UTC (permalink / raw)
To: Mel Gorman
Cc: linux-mm, linux-numa, akpm, Nishanth Aravamudan, andi,
David Rientjes, Adam Litke, Andy Whitcroft, eric.whitney
Incremental patch for missing kfree() at end. Will roll into next
respin of the series.
On Thu, 2009-07-30 at 12:15 +0100, Mel Gorman wrote:
> On Wed, Jul 29, 2009 at 01:55:11PM -0400, Lee Schermerhorn wrote:
> > [PATCH 3/4] hugetlb: derive huge pages nodes allowed from task mempolicy
> >
> > Against: 2.6.31-rc3-mmotm-090716-1432
> > atop the alloc_bootmem_huge_page() fix patch
> > [http://marc.info/?l=linux-mm&m=124775468226290&w=4]
> >
> > V2:
> > + cleaned up comments, removed some deemed unnecessary,
> > add some suggested by review
> > + removed check for !current in huge_mpol_nodes_allowed().
> > + added 'current->comm' to warning message in huge_mpol_nodes_allowed().
> > + added VM_BUG_ON() assertion in hugetlb.c next_node_allowed() to
> > catch out of range node id.
> > + add examples to patch description
> >
> > V3: Factored this patch from V2 patch 2/3
> >
> > This patch derives a "nodes_allowed" node mask from the numa
> > mempolicy of the task modifying the number of persistent huge
> > pages to control the allocation, freeing and adjusting of surplus
> > huge pages. This mask is derived as follows:
> >
> > * For "default" [NULL] task mempolicy, a NULL nodemask_t pointer
> > is produced. This will cause the hugetlb subsystem to use
> > node_online_map as the "nodes_allowed". This preserves the
> > behavior before this patch.
> > * For "preferred" mempolicy, including explicit local allocation,
> > a nodemask with the single preferred node will be produced.
> > "local" policy will NOT track any internode migrations of the
> > task adjusting nr_hugepages.
> > * For "bind" and "interleave" policy, the mempolicy's nodemask
> > will be used.
> > * Other than to inform the construction of the nodes_allowed node
> > mask, the actual mempolicy mode is ignored. That is, all modes
> > behave like interleave over the resulting nodes_allowed mask
> > with no "fallback".
> >
> > Notes:
> >
> > 1) This patch introduces a subtle change in behavior: huge page
> > allocation and freeing will be constrained by any mempolicy
> > that the task adjusting the huge page pool inherits from its
> > parent. This policy could come from a distant ancestor. The
> > adminstrator adjusting the huge page pool without explicitly
> > specifying a mempolicy via numactl might be surprised by this.
> > Additionaly, any mempolicy specified by numactl will be
> > constrained by the cpuset in which numactl is invoked.
> >
> > 2) Hugepages allocated at boot time use the node_online_map.
> > An additional patch could implement a temporary boot time
> > huge pages nodes_allowed command line parameter.
> >
> > 3) Using mempolicy to control persistent huge page allocation
> > and freeing requires no change to hugeadm when invoking
> > it via numactl, as shown in the examples below. However,
> > hugeadm could be enhanced to take the allowed nodes as an
> > argument and set its task mempolicy itself. This would allow
> > it to detect and warn about any non-default mempolicy that it
> > inherited from its parent, thus alleviating the issue described
> > in Note 1 above.
> >
> > See the updated documentation [next patch] for more information
> > about the implications of this patch.
> >
> > Examples:
> >
> > Starting with:
> >
> > Node 0 HugePages_Total: 0
> > Node 1 HugePages_Total: 0
> > Node 2 HugePages_Total: 0
> > Node 3 HugePages_Total: 0
> >
> > Default behavior [with or without this patch] balances persistent
> > hugepage allocation across nodes [with sufficient contiguous memory]:
> >
> > hugeadm --pool-pages-min=2048Kb:32
> >
> > yields:
> >
> > Node 0 HugePages_Total: 8
> > Node 1 HugePages_Total: 8
> > Node 2 HugePages_Total: 8
> > Node 3 HugePages_Total: 8
> >
> > Applying mempolicy--e.g., with numactl [using '-m' a.k.a.
> > '--membind' because it allows multiple nodes to be specified
> > and it's easy to type]--we can allocate huge pages on
> > individual nodes or sets of nodes. So, starting from the
> > condition above, with 8 huge pages per node:
> >
> > numactl -m 2 hugeadm --pool-pages-min=2048Kb:+8
> >
> > yields:
> >
> > Node 0 HugePages_Total: 8
> > Node 1 HugePages_Total: 8
> > Node 2 HugePages_Total: 16
> > Node 3 HugePages_Total: 8
> >
> > The incremental 8 huge pages were restricted to node 2 by the
> > specified mempolicy.
> >
> > Similarly, we can use mempolicy to free persistent huge pages
> > from specified nodes:
> >
> > numactl -m 0,1 hugeadm --pool-pages-min=2048Kb:-8
> >
> > yields:
> >
> > Node 0 HugePages_Total: 4
> > Node 1 HugePages_Total: 4
> > Node 2 HugePages_Total: 16
> > Node 3 HugePages_Total: 8
> >
> > The 8 huge pages freed were balanced over nodes 0 and 1.
> >
> > Signed-off-by: Lee Schermerhorn <lee.schermerhorn@hp.com>
> >
> > include/linux/mempolicy.h | 3 ++
> > mm/hugetlb.c | 13 ++++++---
> > mm/mempolicy.c | 61 ++++++++++++++++++++++++++++++++++++++++++++++
> > 3 files changed, 72 insertions(+), 5 deletions(-)
> >
> > Index: linux-2.6.31-rc3-mmotm-090716-1432/mm/mempolicy.c
> > ===================================================================
> > --- linux-2.6.31-rc3-mmotm-090716-1432.orig/mm/mempolicy.c 2009-07-28 11:15:10.000000000 -0400
> > +++ linux-2.6.31-rc3-mmotm-090716-1432/mm/mempolicy.c 2009-07-28 11:23:43.000000000 -0400
> > @@ -1544,6 +1544,67 @@ struct zonelist *huge_zonelist(struct vm
> > }
> > return zl;
> > }
> > +
> > +/*
> > + * huge_mpol_nodes_allowed -- mempolicy extension for huge pages.
> > + *
> > + * Returns a [pointer to a] nodelist based on the current task's mempolicy
> > + * to constraing the allocation and freeing of persistent huge pages
> > + * 'Preferred', 'local' and 'interleave' mempolicy will behave more like
> > + * 'bind' policy in this context. An attempt to allocate a persistent huge
> > + * page will never "fallback" to another node inside the buddy system
> > + * allocator.
> > + *
> > + * If the task's mempolicy is "default" [NULL], just return NULL for
> > + * default behavior. Otherwise, extract the policy nodemask for 'bind'
> > + * or 'interleave' policy or construct a nodemask for 'preferred' or
> > + * 'local' policy and return a pointer to a kmalloc()ed nodemask_t.
> > + *
> > + * N.B., it is the caller's responsibility to free a returned nodemask.
> > + */
> > +nodemask_t *huge_mpol_nodes_allowed(void)
> > +{
> > + nodemask_t *nodes_allowed = NULL;
> > + struct mempolicy *mempolicy;
> > + int nid;
> > +
> > + if (!current->mempolicy)
> > + return NULL;
> > +
> > + mpol_get(current->mempolicy);
> > + nodes_allowed = kmalloc(sizeof(*nodes_allowed), GFP_KERNEL);
> > + if (!nodes_allowed) {
> > + printk(KERN_WARNING "%s unable to allocate nodes allowed mask "
> > + "for huge page allocation.\nFalling back to default.\n",
> > + current->comm);
> > + goto out;
> > + }
> > + nodes_clear(*nodes_allowed);
> > +
> > + mempolicy = current->mempolicy;
> > + switch (mempolicy->mode) {
> > + case MPOL_PREFERRED:
> > + if (mempolicy->flags & MPOL_F_LOCAL)
> > + nid = numa_node_id();
> > + else
> > + nid = mempolicy->v.preferred_node;
> > + node_set(nid, *nodes_allowed);
> > + break;
> > +
> > + case MPOL_BIND:
> > + /* Fall through */
> > + case MPOL_INTERLEAVE:
> > + *nodes_allowed = mempolicy->v.nodes;
> > + break;
> > +
> > + default:
> > + BUG();
> > + }
> > +
> > +out:
> > + mpol_put(current->mempolicy);
> > + return nodes_allowed;
> > +}
> > #endif
> >
> > /* Allocate a page in interleaved policy.
> > Index: linux-2.6.31-rc3-mmotm-090716-1432/include/linux/mempolicy.h
> > ===================================================================
> > --- linux-2.6.31-rc3-mmotm-090716-1432.orig/include/linux/mempolicy.h 2009-07-28 11:15:10.000000000 -0400
> > +++ linux-2.6.31-rc3-mmotm-090716-1432/include/linux/mempolicy.h 2009-07-28 11:23:43.000000000 -0400
> > @@ -201,6 +201,7 @@ extern void mpol_fix_fork_child_flag(str
> > extern struct zonelist *huge_zonelist(struct vm_area_struct *vma,
> > unsigned long addr, gfp_t gfp_flags,
> > struct mempolicy **mpol, nodemask_t **nodemask);
> > +extern nodemask_t *huge_mpol_nodes_allowed(void);
> > extern unsigned slab_node(struct mempolicy *policy);
> >
> > extern enum zone_type policy_zone;
> > @@ -328,6 +329,8 @@ static inline struct zonelist *huge_zone
> > return node_zonelist(0, gfp_flags);
> > }
> >
> > +static inline nodemask_t *huge_mpol_nodes_allowed(void) { return NULL; }
> > +
> > static inline int do_migrate_pages(struct mm_struct *mm,
> > const nodemask_t *from_nodes,
> > const nodemask_t *to_nodes, int flags)
> > Index: linux-2.6.31-rc3-mmotm-090716-1432/mm/hugetlb.c
> > ===================================================================
> > --- linux-2.6.31-rc3-mmotm-090716-1432.orig/mm/hugetlb.c 2009-07-28 11:23:18.000000000 -0400
> > +++ linux-2.6.31-rc3-mmotm-090716-1432/mm/hugetlb.c 2009-07-28 11:24:43.000000000 -0400
> > @@ -1257,10 +1257,13 @@ static int adjust_pool_surplus(struct hs
> > static unsigned long set_max_huge_pages(struct hstate *h, unsigned long count)
> > {
> > unsigned long min_count, ret;
> > + nodemask_t *nodes_allowed;
> >
> > if (h->order >= MAX_ORDER)
> > return h->max_huge_pages;
> >
> > + nodes_allowed = huge_mpol_nodes_allowed();
> > +
> > /*
> > * Increase the pool size
> > * First take pages out of surplus state. Then make up the
> > @@ -1274,7 +1277,7 @@ static unsigned long set_max_huge_pages(
> > */
> > spin_lock(&hugetlb_lock);
> > while (h->surplus_huge_pages && count > persistent_huge_pages(h)) {
> > - if (!adjust_pool_surplus(h, NULL, -1))
> > + if (!adjust_pool_surplus(h, nodes_allowed, -1))
> > break;
> > }
> >
> > @@ -1285,7 +1288,7 @@ static unsigned long set_max_huge_pages(
> > * and reducing the surplus.
> > */
> > spin_unlock(&hugetlb_lock);
> > - ret = alloc_fresh_huge_page(h, NULL);
> > + ret = alloc_fresh_huge_page(h, nodes_allowed);
> > spin_lock(&hugetlb_lock);
> > if (!ret)
> > goto out;
> > @@ -1309,13 +1312,13 @@ static unsigned long set_max_huge_pages(
> > */
> > min_count = h->resv_huge_pages + h->nr_huge_pages - h->free_huge_pages;
> > min_count = max(count, min_count);
> > - try_to_free_low(h, min_count, NULL);
> > + try_to_free_low(h, min_count, nodes_allowed);
> > while (min_count < persistent_huge_pages(h)) {
> > - if (!free_pool_huge_page(h, NULL, 0))
> > + if (!free_pool_huge_page(h, nodes_allowed, 0))
> > break;
> > }
> > while (count < persistent_huge_pages(h)) {
> > - if (!adjust_pool_surplus(h, NULL, 1))
> > + if (!adjust_pool_surplus(h, nodes_allowed, 1))
> > break;
> > }
> > out:
>
> Where did the hunk go that calls kfree(nodes_allowed)? I think we might
> be leaking in this version.
>
> Otherwise it looks good.
>
[PATCH] hugetlb: derive huge pages nodes allowed from task mempolicy FIX
Against: 2.6.31-rc3-mmotm-090716-1432 with
hugetlb: derive huge pages nodes allowed from task mempolicy
restore kfree() of dynamically allocated nodes_allowed nodemask
dropped during refactoring of patches. Caught by Mel Gorman.
Signed-off-by: Lee Schermerhorn <lee.schermerhorn@hp.com>
---
mm/hugetlb.c | 1 +
1 file changed, 1 insertion(+)
Index: linux-2.6.31-rc4-mmotm-090730-0501/mm/hugetlb.c
===================================================================
--- linux-2.6.31-rc4-mmotm-090730-0501.orig/mm/hugetlb.c 2009-07-30 09:09:28.000000000 -0400
+++ linux-2.6.31-rc4-mmotm-090730-0501/mm/hugetlb.c 2009-07-30 09:11:07.000000000 -0400
@@ -1324,6 +1324,7 @@ static unsigned long set_max_huge_pages(
out:
ret = persistent_huge_pages(h);
spin_unlock(&hugetlb_lock);
+ kfree(nodes_allowed);
return ret;
}
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 4/4] hugetlb: update hugetlb documentation for mempolicy based management.
2009-07-29 17:54 [PATCH 0/4] hugetlb: V3 constrain allocation/free based on task mempolicy Lee Schermerhorn
` (2 preceding siblings ...)
2009-07-29 17:55 ` [PATCH 3/4] hugetlb: derive huge pages nodes allowed from task mempolicy Lee Schermerhorn
@ 2009-07-29 17:55 ` Lee Schermerhorn
2009-07-30 11:18 ` [PATCH 0/4] hugetlb: V3 constrain allocation/free based on task mempolicy Mel Gorman
4 siblings, 0 replies; 12+ messages in thread
From: Lee Schermerhorn @ 2009-07-29 17:55 UTC (permalink / raw)
To: linux-mm, linux-numa
Cc: akpm, Mel Gorman, Nishanth Aravamudan, andi, David Rientjes,
Adam Litke, Andy Whitcroft, eric.whitney
PATCH 4/4 hugetlb: update hugetlb documentation for mempolicy based management.
Against: 2.6.31-rc3-mmotm-090716-1432
atop the alloc_bootmem_huge_page() fix patch
[http://marc.info/?l=linux-mm&m=124775468226290&w=4]
This patch updates the kernel huge tlb documentation to describe the
numa memory policy based huge page management. Additionaly, the patch
includes a fair amount of rework to improve consistency, eliminate
duplication and set the context for documenting the memory policy
interaction.
Signed-off-by: Lee Schermerhorn <lee.schermerhorn@hp.com>
Documentation/vm/hugetlbpage.txt | 228 ++++++++++++++++++++++++---------------
1 file changed, 143 insertions(+), 85 deletions(-)
Index: linux-2.6.31-rc3-mmotm-090715-2057/Documentation/vm/hugetlbpage.txt
===================================================================
--- linux-2.6.31-rc3-mmotm-090715-2057.orig/Documentation/vm/hugetlbpage.txt 2009-07-16 12:44:11.000000000 -0400
+++ linux-2.6.31-rc3-mmotm-090715-2057/Documentation/vm/hugetlbpage.txt 2009-07-16 12:44:20.000000000 -0400
@@ -11,23 +11,21 @@ This optimization is more critical now a
(several GBs) are more readily available.
Users can use the huge page support in Linux kernel by either using the mmap
-system call or standard SYSv shared memory system calls (shmget, shmat).
+system call or standard SYSV shared memory system calls (shmget, shmat).
First the Linux kernel needs to be built with the CONFIG_HUGETLBFS
(present under "File systems") and CONFIG_HUGETLB_PAGE (selected
automatically when CONFIG_HUGETLBFS is selected) configuration
options.
-The kernel built with huge page support should show the number of configured
-huge pages in the system by running the "cat /proc/meminfo" command.
+The /proc/meminfo file provides information about the total number of hugetlb
+pages preallocated in the kernel's huge page pool. It also displays
+information about the number of free, reserved and surplus huge pages and the
+[default] huge page size. The huge page size is needed for generating the
+proper alignment and size of the arguments to system calls that map huge page
+regions.
-/proc/meminfo also provides information about the total number of hugetlb
-pages configured in the kernel. It also displays information about the
-number of free hugetlb pages at any time. It also displays information about
-the configured huge page size - this is needed for generating the proper
-alignment and size of the arguments to the above system calls.
-
-The output of "cat /proc/meminfo" will have lines like:
+The output of "cat /proc/meminfo" will include lines like:
.....
HugePages_Total: vvv
@@ -53,26 +51,25 @@ HugePages_Surp is short for "surplus,"
/proc/filesystems should also show a filesystem of type "hugetlbfs" configured
in the kernel.
-/proc/sys/vm/nr_hugepages indicates the current number of configured hugetlb
-pages in the kernel. Super user can dynamically request more (or free some
-pre-configured) huge pages.
-The allocation (or deallocation) of hugetlb pages is possible only if there are
-enough physically contiguous free pages in system (freeing of huge pages is
-possible only if there are enough hugetlb pages free that can be transferred
-back to regular memory pool).
-
-Pages that are used as hugetlb pages are reserved inside the kernel and cannot
-be used for other purposes.
-
-Once the kernel with Hugetlb page support is built and running, a user can
-use either the mmap system call or shared memory system calls to start using
-the huge pages. It is required that the system administrator preallocate
-enough memory for huge page purposes.
-
-The administrator can preallocate huge pages on the kernel boot command line by
-specifying the "hugepages=N" parameter, where 'N' = the number of huge pages
-requested. This is the most reliable method for preallocating huge pages as
-memory has not yet become fragmented.
+/proc/sys/vm/nr_hugepages indicates the current number of huge pages pre-
+allocated in the kernel's huge page pool. These are called "persistent"
+huge pages. A user with root privileges can dynamically allocate more or
+free some persistent huge pages by increasing or decreasing the value of
+'nr_hugepages'.
+
+Pages that are used as huge pages are reserved inside the kernel and cannot
+be used for other purposes. Huge pages can not be swapped out under
+memory pressure.
+
+Once a number of huge pages have been pre-allocated to the kernel huge page
+pool, a user with appropriate privilege can use either the mmap system call
+or shared memory system calls to use the huge pages. See the discussion of
+Using Huge Pages, below
+
+The administrator can preallocate persistent huge pages on the kernel boot
+command line by specifying the "hugepages=N" parameter, where 'N' = the
+number of requested huge pages requested. This is the most reliable method
+or preallocating huge pages as memory has not yet become fragmented.
Some platforms support multiple huge page sizes. To preallocate huge pages
of a specific size, one must preceed the huge pages boot command parameters
@@ -80,19 +77,23 @@ with a huge page size selection paramete
be specified in bytes with optional scale suffix [kKmMgG]. The default huge
page size may be selected with the "default_hugepagesz=<size>" boot parameter.
-/proc/sys/vm/nr_hugepages indicates the current number of configured [default
-size] hugetlb pages in the kernel. Super user can dynamically request more
-(or free some pre-configured) huge pages.
-
-Use the following command to dynamically allocate/deallocate default sized
-huge pages:
+When multiple huge page sizes are supported, /proc/sys/vm/nr_hugepages
+indicates the current number of pre-allocated huge pages of the default size.
+Thus, one can use the following command to dynamically allocate/deallocate
+default sized persistent huge pages:
echo 20 > /proc/sys/vm/nr_hugepages
-This command will try to configure 20 default sized huge pages in the system.
+This command will try to adjust the number of default sized huge pages in the
+huge page pool to 20, allocating or freeing huge pages, as required.
+
On a NUMA platform, the kernel will attempt to distribute the huge page pool
-over the all on-line nodes. These huge pages, allocated when nr_hugepages
-is increased, are called "persistent huge pages".
+over the all the nodes specified by the NUMA memory policy of the task that
+modifies nr_hugepages that contain sufficient available contiguous memory.
+These nodes are called the huge pages "allowed nodes". The default for the
+huge pages allowed nodes--when the task has default memory policy--is all
+on-line nodes. See the discussion below of the interaction of task memory
+policy, cpusets and persistent huge page allocation and freeing.
The success or failure of huge page allocation depends on the amount of
physically contiguous memory that is preset in system at the time of the
@@ -101,11 +102,11 @@ some nodes in a NUMA system, it will att
allocating extra pages on other nodes with sufficient available contiguous
memory, if any.
-System administrators may want to put this command in one of the local rc init
-files. This will enable the kernel to request huge pages early in the boot
-process when the possibility of getting physical contiguous pages is still
-very high. Administrators can verify the number of huge pages actually
-allocated by checking the sysctl or meminfo. To check the per node
+System administrators may want to put this command in one of the local rc
+init files. This will enable the kernel to preallocate huge pages early in
+the boot process when the possibility of getting physical contiguous pages
+is still very high. Administrators can verify the number of huge pages
+actually allocated by checking the sysctl or meminfo. To check the per node
distribution of huge pages in a NUMA system, use:
cat /sys/devices/system/node/node*/meminfo | fgrep Huge
@@ -113,39 +114,40 @@ distribution of huge pages in a NUMA sys
/proc/sys/vm/nr_overcommit_hugepages specifies how large the pool of
huge pages can grow, if more huge pages than /proc/sys/vm/nr_hugepages are
requested by applications. Writing any non-zero value into this file
-indicates that the hugetlb subsystem is allowed to try to obtain "surplus"
-huge pages from the buddy allocator, when the normal pool is exhausted. As
-these surplus huge pages go out of use, they are freed back to the buddy
-allocator.
+indicates that the hugetlb subsystem is allowed to try to obtain that
+number of "surplus" huge pages from the kernel's normal page pool, when the
+persistent huge page pool is exhausted. As these surplus huge pages become
+unused, they are freed back to the kernel's normal page pool.
-When increasing the huge page pool size via nr_hugepages, any surplus
+When increasing the huge page pool size via nr_hugepages, any existing surplus
pages will first be promoted to persistent huge pages. Then, additional
huge pages will be allocated, if necessary and if possible, to fulfill
-the new huge page pool size.
+the new persistent huge page pool size.
The administrator may shrink the pool of preallocated huge pages for
the default huge page size by setting the nr_hugepages sysctl to a
smaller value. The kernel will attempt to balance the freeing of huge pages
-across all on-line nodes. Any free huge pages on the selected nodes will
-be freed back to the buddy allocator.
-
-Caveat: Shrinking the pool via nr_hugepages such that it becomes less
-than the number of huge pages in use will convert the balance to surplus
-huge pages even if it would exceed the overcommit value. As long as
-this condition holds, however, no more surplus huge pages will be
-allowed on the system until one of the two sysctls are increased
-sufficiently, or the surplus huge pages go out of use and are freed.
+across all nodes in the memory policy of the task modifying nr_hugepages.
+Any free huge pages on the selected nodes will be freed back to the kernel's
+normal page pool.
+
+Caveat: Shrinking the persistent huge page pool via nr_hugepages such that
+it becomes less than the number of huge pages in use will convert the balance
+of the in-use huge pages to surplus huge pages. This will occur even if
+the number of surplus pages it would exceed the overcommit value. As long as
+this condition holds--that is, until nr_hugepages+nr_overcommit_hugepages is
+increased sufficiently, or the surplus huge pages go out of use and are freed--
+no more surplus huge pages will be allowed to be allocated.
With support for multiple huge page pools at run-time available, much of
-the huge page userspace interface has been duplicated in sysfs. The above
-information applies to the default huge page size which will be
-controlled by the /proc interfaces for backwards compatibility. The root
-huge page control directory in sysfs is:
+the huge page userspace interface in /proc/sys/vm has been duplicated in sysfs.
+The /proc interfaces discussed above have been retained for backwards
+compatibility. The root huge page control directory in sysfs is:
/sys/kernel/mm/hugepages
For each huge page size supported by the running kernel, a subdirectory
-will exist, of the form
+will exist, of the form:
hugepages-${size}kB
@@ -159,6 +161,70 @@ Inside each of these directories, the sa
which function as described above for the default huge page-sized case.
+
+Interaction of Task Memory Policy with Huge Page Allocation/Freeing:
+
+Whether huge pages are allocated and freed via the /proc interface or
+the /sysfs interface, the NUMA nodes from which huge pages are allocated
+or freed are controlled by the NUMA memory policy of the task that modifies
+the nr_hugepages parameter. [nr_overcommit_hugepages is a global limit.]
+
+The recommended method to allocate or free huge pages to/from the kernel
+huge page pool, using the nr_hugepages example above, is:
+
+ numactl --interleave <node-list> echo 20 >/proc/sys/vm/nr_hugepages.
+
+or, more succinctly:
+
+ numactl -m <node-list> echo 20 >/proc/sys/vm/nr_hugepages.
+
+This will allocate or free abs(20 - nr_hugepages) to or from the nodes
+specified in <node-list>, depending on whether nr_hugepages is initially
+less than or greater than 20, respectively. No huge pages will be
+allocated nor freed on any node not included in the specified <node-list>.
+
+Any memory policy mode--bind, preferred, local or interleave--may be
+used. The effect on persistent huge page allocation will be as follows:
+
+1) Regardless of mempolicy mode [see Documentation/vm/numa_memory_policy.txt],
+ persistent huge pages will be distributed across the node or nodes
+ specified in the mempolicy as if "interleave" had been specified.
+ However, if a node in the policy does not contain sufficient contiguous
+ memory for a huge page, the allocation will not "fallback" to the nearest
+ neighbor node with sufficient contiguous memory. To do this would cause
+ undesirable imbalance in the distribution of the huge page pool, or
+ possibly, allocation of persistent huge pages on nodes not allowed by
+ the task's memory policy.
+
+2) One or more nodes may be specified with the bind or interleave policy.
+ If more than one node is specified with the preferred policy, only the
+ lowest numeric id will be used. Local policy will select the node where
+ the task is running at the time the nodes_allowed mask is constructed.
+
+3) For local policy to be deterministic, the task must be bound to a cpu or
+ cpus in a single node. Otherwise, the task could be migrated to some
+ other node at any time after launch and the resulting node will be
+ indeterminate. Thus, local policy is not very useful for this purpose.
+ Any of the other mempolicy modes may be used to specify a single node.
+
+4) The nodes allowed mask will be derived from any non-default task mempolicy,
+ whether this policy was set explicitly by the task itself or one of its
+ ancestors, such as numactl. This means that if the task is invoked from a
+ shell with non-default policy, that policy will be used. One can specify a
+ node list of "all" with numactl --interleave or --membind [-m] to achieve
+ interleaving over all nodes in the system or cpuset.
+
+5) Any task mempolicy specifed--e.g., using numactl--will be constrained by
+ the resource limits of any cpuset in which the task runs. Thus, there will
+ be no way for a task with non-default policy running in a cpuset with a
+ subset of the system nodes to allocate huge pages outside the cpuset
+ without first moving to a cpuset that contains all of the desired nodes.
+
+6) Hugepages allocated at boot time always use the node_online_map.
+
+
+Using Huge Pages:
+
If the user applications are going to request huge pages using mmap system
call, then it is required that system administrator mount a file system of
type hugetlbfs:
@@ -204,9 +270,11 @@ mount of filesystem will be required for
* requesting huge pages.
*
* For the ia64 architecture, the Linux kernel reserves Region number 4 for
- * huge pages. That means the addresses starting with 0x800000... will need
- * to be specified. Specifying a fixed address is not required on ppc64,
- * i386 or x86_64.
+ * huge pages. That means that if one requires a fixed address, a huge page
+ * aligned address starting with 0x800000... will be required. If a fixed
+ * address is not required, the kernel will select an address in the proper
+ * range.
+ * Other architectures, such as ppc64, i386 or x86_64 are not so constrained.
*
* Note: The default shared memory limit is quite low on many kernels,
* you may need to increase it via:
@@ -235,14 +303,8 @@ mount of filesystem will be required for
#define dprintf(x) printf(x)
-/* Only ia64 requires this */
-#ifdef __ia64__
-#define ADDR (void *)(0x8000000000000000UL)
-#define SHMAT_FLAGS (SHM_RND)
-#else
-#define ADDR (void *)(0x0UL)
+#define ADDR (void *)(0x0UL) /* let kernel choose address */
#define SHMAT_FLAGS (0)
-#endif
int main(void)
{
@@ -300,10 +362,12 @@ int main(void)
* example, the app is requesting memory of size 256MB that is backed by
* huge pages.
*
- * For ia64 architecture, Linux kernel reserves Region number 4 for huge pages.
- * That means the addresses starting with 0x800000... will need to be
- * specified. Specifying a fixed address is not required on ppc64, i386
- * or x86_64.
+ * For the ia64 architecture, the Linux kernel reserves Region number 4 for
+ * huge pages. That means that if one requires a fixed address, a huge page
+ * aligned address starting with 0x800000... will be required. If a fixed
+ * address is not required, the kernel will select an address in the proper
+ * range.
+ * Other architectures, such as ppc64, i386 or x86_64 are not so constrained.
*/
#include <stdlib.h>
#include <stdio.h>
@@ -315,14 +379,8 @@ int main(void)
#define LENGTH (256UL*1024*1024)
#define PROTECTION (PROT_READ | PROT_WRITE)
-/* Only ia64 requires this */
-#ifdef __ia64__
-#define ADDR (void *)(0x8000000000000000UL)
-#define FLAGS (MAP_SHARED | MAP_FIXED)
-#else
-#define ADDR (void *)(0x0UL)
+#define ADDR (void *)(0x0UL) /* let kernel choose address */
#define FLAGS (MAP_SHARED)
-#endif
void check_bytes(char *addr)
{
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/4] hugetlb: V3 constrain allocation/free based on task mempolicy
2009-07-29 17:54 [PATCH 0/4] hugetlb: V3 constrain allocation/free based on task mempolicy Lee Schermerhorn
` (3 preceding siblings ...)
2009-07-29 17:55 ` [PATCH 4/4] hugetlb: update hugetlb documentation for mempolicy based management Lee Schermerhorn
@ 2009-07-30 11:18 ` Mel Gorman
2009-07-30 14:07 ` Lee Schermerhorn
4 siblings, 1 reply; 12+ messages in thread
From: Mel Gorman @ 2009-07-30 11:18 UTC (permalink / raw)
To: Lee Schermerhorn
Cc: linux-mm, linux-numa, akpm, Nishanth Aravamudan, andi,
David Rientjes, Adam Litke, Andy Whitcroft, eric.whitney
On Wed, Jul 29, 2009 at 01:54:50PM -0400, Lee Schermerhorn wrote:
> PATCH 0/4 hugetlb: constrain allocation/free based on task mempolicy
>
> I'm sending these out again, slightly revised, for comparison
> with a 3rd alternative for controlling where persistent huge
> pages are allocated which I'll send out as a separate series.
>
> Against: 2.6.31-rc3-mmotm-090716-1432
> atop previously submitted "alloc_bootmem_huge_pages() fix"
> [http://marc.info/?l=linux-mm&m=124775468226290&w=4]
>
> This is V3 of a series of patches to constrain the allocation and
> freeing of persistent huge pages using the task NUMA mempolicy of
> the task modifying "nr_hugepages". This series is based on Mel
> Gorman's suggestion to use task mempolicy. One of the benefits
> of this method is that it does not *require* modification to
> hugeadm(8) to use this feature.
>
> V3 factors the "rework" of the hstate_next_node_to_{alloc|free}
> functions out of the patch to derive huge pages nodes_allowed
> from mempolicy, and moves it before the patch to add nodemasks
> to the alloc/free functions. See patch patch 1/4.
>
> A couple of limitations [still] in this version:
>
> 1) I haven't implemented a boot time parameter to constrain the
> boot time allocation of huge pages. This can be added if
> anyone feels strongly that it is required.
>
> 2) I have not implemented a per node nr_overcommit_hugepages as
> David Rientjes and I discussed earlier. Again, this can be
> added and specific nodes can be addressed using the mempolicy
> as this series does for allocation and free. However, after
> some experience with the libhugetlbfs test suite, specifically
> attempting to run the test suite constrained by mempolicy and
> a cpuset, I'm thinking that per node overcommit limits might
> not be such a good idea. This would require an application
> [or the library] to sum the per node limits over the allowed
> nodes and possibly compare to global limits to determine the
> available resources. Per cpuset limits might work better.
> This are requires more investigation, but this patch series
> doesn't seem to make things worse than they already are in
> this regard.
>
There needs to be a third limitation listed here and preferably added as a
note in the documentation or better yet, warned about explicitly at runtime.
3) hugetlb reservations are not mempolicy aware. If an application runs
that only has access to a subset of nodes with hugepages, it may encounter
stability problems as mmap() will return success and potentially fail a
page fault later
I'm ok with that for the moment but it'll be something that eventually
needs to be addressed. However, I don't consider it a prequisite for
this patchset because there is obvious utility for administrators that
want to run a limited number of hugepage applications all on the same
node that would be covered by this patch.
Other than the possible memory leak in patch 3 which I've commented on there,
I'm fine with the patchset.
--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/4] hugetlb: V3 constrain allocation/free based on task mempolicy
2009-07-30 11:18 ` [PATCH 0/4] hugetlb: V3 constrain allocation/free based on task mempolicy Mel Gorman
@ 2009-07-30 14:07 ` Lee Schermerhorn
2009-07-30 14:15 ` Mel Gorman
0 siblings, 1 reply; 12+ messages in thread
From: Lee Schermerhorn @ 2009-07-30 14:07 UTC (permalink / raw)
To: Mel Gorman
Cc: linux-mm, linux-numa, akpm, Nishanth Aravamudan, andi,
David Rientjes, Adam Litke, Andy Whitcroft, eric.whitney
On Thu, 2009-07-30 at 12:18 +0100, Mel Gorman wrote:
> On Wed, Jul 29, 2009 at 01:54:50PM -0400, Lee Schermerhorn wrote:
> > PATCH 0/4 hugetlb: constrain allocation/free based on task mempolicy
> >
> > I'm sending these out again, slightly revised, for comparison
> > with a 3rd alternative for controlling where persistent huge
> > pages are allocated which I'll send out as a separate series.
> >
> > Against: 2.6.31-rc3-mmotm-090716-1432
> > atop previously submitted "alloc_bootmem_huge_pages() fix"
> > [http://marc.info/?l=linux-mm&m=124775468226290&w=4]
> >
> > This is V3 of a series of patches to constrain the allocation and
> > freeing of persistent huge pages using the task NUMA mempolicy of
> > the task modifying "nr_hugepages". This series is based on Mel
> > Gorman's suggestion to use task mempolicy. One of the benefits
> > of this method is that it does not *require* modification to
> > hugeadm(8) to use this feature.
> >
> > V3 factors the "rework" of the hstate_next_node_to_{alloc|free}
> > functions out of the patch to derive huge pages nodes_allowed
> > from mempolicy, and moves it before the patch to add nodemasks
> > to the alloc/free functions. See patch patch 1/4.
> >
> > A couple of limitations [still] in this version:
> >
> > 1) I haven't implemented a boot time parameter to constrain the
> > boot time allocation of huge pages. This can be added if
> > anyone feels strongly that it is required.
> >
> > 2) I have not implemented a per node nr_overcommit_hugepages as
> > David Rientjes and I discussed earlier. Again, this can be
> > added and specific nodes can be addressed using the mempolicy
> > as this series does for allocation and free. However, after
> > some experience with the libhugetlbfs test suite, specifically
> > attempting to run the test suite constrained by mempolicy and
> > a cpuset, I'm thinking that per node overcommit limits might
> > not be such a good idea. This would require an application
> > [or the library] to sum the per node limits over the allowed
> > nodes and possibly compare to global limits to determine the
> > available resources. Per cpuset limits might work better.
> > This are requires more investigation, but this patch series
> > doesn't seem to make things worse than they already are in
> > this regard.
> >
>
> There needs to be a third limitation listed here and preferably added as a
> note in the documentation or better yet, warned about explicitly at runtime.
>
> 3) hugetlb reservations are not mempolicy aware. If an application runs
> that only has access to a subset of nodes with hugepages, it may encounter
> stability problems as mmap() will return success and potentially fail a
> page fault later
>
> I'm ok with that for the moment but it'll be something that eventually
> needs to be addressed. However, I don't consider it a prequisite for
> this patchset because there is obvious utility for administrators that
> want to run a limited number of hugepage applications all on the same
> node that would be covered by this patch.
Mel:
That's not exactly a limitation with this series. The fact that hugetlb
reservations are not mempolicy aware will bite you independent of this
patch series. I think we want reservations to be independent of
mempolicy, because unless the application is restricted to a single
node, we don't know from which node it will attempt to allocate a huge
page at fault time. As I recall, one of the purposes of reservations
was to guarantee successful allocation at fault time when we removed the
allocation at mmap/attach time. Since we don't know from which of the
allowed nodes a task will attempt to allocate at fault time, it's
difficult to charge a reserve against any given node. This will
continue to be a problem unless we have sufficient capacity in the
allowed nodes to satisfy the reserve count. Same problem exists for
overcommit huge pages.
>
> Other than the possible memory leak in patch 3 which I've commented on there,
> I'm fine with the patchset.
Yeah, I apparently dropped that while reworking the series. I'll post
an incremental fix.
I also need to ping David R about the "3rd alternative"--per node
attributes--as he was favoring that method. I'm hoping we can obtain
consensus on the approach and then focus on refining that one.
Later,
Lee
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/4] hugetlb: V3 constrain allocation/free based on task mempolicy
2009-07-30 14:07 ` Lee Schermerhorn
@ 2009-07-30 14:15 ` Mel Gorman
0 siblings, 0 replies; 12+ messages in thread
From: Mel Gorman @ 2009-07-30 14:15 UTC (permalink / raw)
To: Lee Schermerhorn
Cc: linux-mm, linux-numa, akpm, Nishanth Aravamudan, andi,
David Rientjes, Adam Litke, Andy Whitcroft, eric.whitney
On Thu, Jul 30, 2009 at 10:07:14AM -0400, Lee Schermerhorn wrote:
> On Thu, 2009-07-30 at 12:18 +0100, Mel Gorman wrote:
> > On Wed, Jul 29, 2009 at 01:54:50PM -0400, Lee Schermerhorn wrote:
> > > PATCH 0/4 hugetlb: constrain allocation/free based on task mempolicy
> > >
> > > I'm sending these out again, slightly revised, for comparison
> > > with a 3rd alternative for controlling where persistent huge
> > > pages are allocated which I'll send out as a separate series.
> > >
> > > Against: 2.6.31-rc3-mmotm-090716-1432
> > > atop previously submitted "alloc_bootmem_huge_pages() fix"
> > > [http://marc.info/?l=linux-mm&m=124775468226290&w=4]
> > >
> > > This is V3 of a series of patches to constrain the allocation and
> > > freeing of persistent huge pages using the task NUMA mempolicy of
> > > the task modifying "nr_hugepages". This series is based on Mel
> > > Gorman's suggestion to use task mempolicy. One of the benefits
> > > of this method is that it does not *require* modification to
> > > hugeadm(8) to use this feature.
> > >
> > > V3 factors the "rework" of the hstate_next_node_to_{alloc|free}
> > > functions out of the patch to derive huge pages nodes_allowed
> > > from mempolicy, and moves it before the patch to add nodemasks
> > > to the alloc/free functions. See patch patch 1/4.
> > >
> > > A couple of limitations [still] in this version:
> > >
> > > 1) I haven't implemented a boot time parameter to constrain the
> > > boot time allocation of huge pages. This can be added if
> > > anyone feels strongly that it is required.
> > >
> > > 2) I have not implemented a per node nr_overcommit_hugepages as
> > > David Rientjes and I discussed earlier. Again, this can be
> > > added and specific nodes can be addressed using the mempolicy
> > > as this series does for allocation and free. However, after
> > > some experience with the libhugetlbfs test suite, specifically
> > > attempting to run the test suite constrained by mempolicy and
> > > a cpuset, I'm thinking that per node overcommit limits might
> > > not be such a good idea. This would require an application
> > > [or the library] to sum the per node limits over the allowed
> > > nodes and possibly compare to global limits to determine the
> > > available resources. Per cpuset limits might work better.
> > > This are requires more investigation, but this patch series
> > > doesn't seem to make things worse than they already are in
> > > this regard.
> > >
> >
> > There needs to be a third limitation listed here and preferably added as a
> > note in the documentation or better yet, warned about explicitly at runtime.
> >
> > 3) hugetlb reservations are not mempolicy aware. If an application runs
> > that only has access to a subset of nodes with hugepages, it may encounter
> > stability problems as mmap() will return success and potentially fail a
> > page fault later
> >
> > I'm ok with that for the moment but it'll be something that eventually
> > needs to be addressed. However, I don't consider it a prequisite for
> > this patchset because there is obvious utility for administrators that
> > want to run a limited number of hugepage applications all on the same
> > node that would be covered by this patch.
>
> Mel:
>
> That's not exactly a limitation with this series. The fact that hugetlb
> reservations are not mempolicy aware will bite you independent of this
> patch series. I think we want reservations to be independent of
> mempolicy, because unless the application is restricted to a single
> node, we don't know from which node it will attempt to allocate a huge
> page at fault time. As I recall, one of the purposes of reservations
> was to guarantee successful allocation at fault time when we removed the
> allocation at mmap/attach time. Since we don't know from which of the
> allowed nodes a task will attempt to allocate at fault time, it's
> difficult to charge a reserve against any given node. This will
> continue to be a problem unless we have sufficient capacity in the
> allowed nodes to satisfy the reserve count.
That's a fair point. The lack of policy awareness in the pool allocation
code has meant that reservations are nowhere near policy aware. I
suspect that reservations can be made work with policy awareness as long
as the list of nodes that can be accessed at fault time matches those at
mmap() time. I can think more about how something like this could be
implemented.
For the moment, to get stability, the restriction is that the memory policies
used at mmap() and fault time must encompass all nodes with hugepages
configured.
I'm ok visiting this as a problem independant of this patchset.
> Same problem exists for overcommit huge pages.
>
> >
> > Other than the possible memory leak in patch 3 which I've commented on there,
> > I'm fine with the patchset.
>
>
> Yeah, I apparently dropped that while reworking the series. I'll post
> an incremental fix.
>
> I also need to ping David R about the "3rd alternative"--per node
> attributes--as he was favoring that method. I'm hoping we can obtain
> consensus on the approach and then focus on refining that one.
>
Right. It's no surprise, but I'm pro-memory-policies largely because
it's more in line with how everything else behaves rather than adding a
hugetlbfs-specific interface. Will see what happens.
--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab
^ permalink raw reply [flat|nested] 12+ messages in thread