Re: [PATCH 4/4] hugetlb: add per node hstate attributes

[Mel Gorman <mel@csn.ul.ie>]

On Fri, Aug 14, 2009 at 03:38:43PM -0700, David Rientjes wrote:
> On Fri, 31 Jul 2009, Lee Schermerhorn wrote:
> 
> > PATCH/RFC 5/4 hugetlb:  register per node hugepages attributes
> > 
> > Against: 2.6.31-rc4-mmotm-090730-0510
> > and the hugetlb rework and mempolicy-based nodes_allowed
> > series
> > 
> 
> Andrew, Lee, what's the status of this patchset?  I don't see it, or the 
> mempolicy support version, in mmotm-2009-08-12-13-55.
> 

Lee went on holidays and I dropped the ball somewhat in that I didn't review
the combined set he posted just before he left. As the two approaches are
not mutually exclusive, my expectation was that at at least one more patchset
would be posted combining both approaches before merging to -mm.

> I think there are use cases for both the per-node hstate attributes and 
> the mempolicy restricted hugepage allocation support and both features can 
> co-exist in the kernel.
> 

Agreed.

> My particular interest is in the per-node hstate attributes because it 
> allows job schedulers to preallocate hugepages in nodes attached to a 
> cpuset with ease and allows node-targeted hugepage freeing for balanced 
> allocations, which is a prerequisite for effective interleave 
> optimizations.
> 
> I'd encourage the addition of the per-node hstate attributes to mmotm.  
> Thanks Lee for implementing this feature.
> 

I'd like to see at least one patchset without the RFCs attached and have
one more read-through before it's merged.

-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab