From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cliff Wickman Subject: Re: [PATCH] libnuma: checking of sucessfull allocations in numademo Date: Thu, 18 Aug 2011 07:01:28 -0500 Message-ID: <20110818120128.GA28575@sgi.com> References: <193444186.2767974.1313665001288.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> <1777371722.2768004.1313665293333.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <1777371722.2768004.1313665293333.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> Sender: linux-numa-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Petr Holasek Cc: linux-numa@vger.kernel.org On Thu, Aug 18, 2011 at 07:01:33AM -0400, Petr Holasek wrote: > From: Petr Holasek > > This patch is based on BZ > https://bugzilla.redhat.com/show_bug.cgi?id=707138 > where too big argument for numademo caused segfault. > > Only simple check of returned pointer from numa_alloc* > calls was added. > > Signed-off-by: Petr Holasek > > -- > diff -up numactl-2.0.7/numademo.c.origin numactl-2.0.7/numademo.c > --- numactl-2.0.7/numademo.c.origin 2011-08-18 06:40:56.617884667 -0400 > +++ numactl-2.0.7/numademo.c 2011-08-18 06:38:15.783759565 -0400 > @@ -156,6 +156,11 @@ void memtest(char *name, unsigned char * > int i; > char title[128], result[128]; > > + if (!mem) { > + fprintf(stderr,"Failed to allocate %lu bytes of memory. Test \"%s\" exits.\n", msize, name); > + return; > + } > + > #ifdef HAVE_STREAM_LIB > if (thistest == STREAM) { > do_stream(name, mem); Thanks, Petr. Yours is now the first patch in 2.0.8-rc1. -Cliff -- Cliff Wickman SGI cpw@sgi.com (651) 683-3824