From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH] Do not use cpu_to_node() to find an offlined cpu's node. Date: Wed, 10 Oct 2012 13:37:09 -0700 Message-ID: <20121010133709.7eaefcdb.akpm@linux-foundation.org> References: <1349665183-11718-1-git-send-email-tangchen@cn.fujitsu.com> <1349780256.7880.12.camel@twins> <1349815676.7880.85.camel@twins> <1349860216.7880.105.camel@twins> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-numa-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: David Rientjes Cc: Peter Zijlstra , Tang Chen , mingo@redhat.com, miaox@cn.fujitsu.com, wency@cn.fujitsu.com, linux-kernel@vger.kernel.org, linux-numa@vger.kernel.org On Wed, 10 Oct 2012 13:30:29 -0700 (PDT) David Rientjes wrote: > > So for now, let me NACK that patch. You cannot go change stuff like > > that. > > > > Agreed, that makes the nack-count up to 2 now. Andrew, please remove > cpu_hotplug-unmap-cpu2node-when-the-cpu-is-hotremoved.patch > cpu_hotplug-unmap-cpu2node-when-the-cpu-is-hotremoved-fix.patch > from -mm. Nope. It fixes a BUG() and so I'll be keeping it around until I see a better fix. It's one of the ways in which I prevent things from falling through cracks.