From: Andi Kleen <andi@firstfloor.org>
To: Vasileios Karakasis <bkk@cslab.ece.ntua.gr>
Cc: linux-numa@vger.kernel.org,
"Θοδωρής Γκούντουβας" <thgoud@cslab.ece.ntua.gr>
Subject: Re: [PATCH] Custom interleaved allocation
Date: Mon, 26 Nov 2012 21:21:06 +0100 [thread overview]
Message-ID: <20121126202106.GO16230@one.firstfloor.org> (raw)
In-Reply-To: <50AD2380.4010506@cslab.ece.ntua.gr>
> +{
> + int i;
> + int nr_nodes = numa_num_configured_nodes();
> + int pagesize = numa_pagesize();
> + size_t *node_scores = calloc(nr_nodes, sizeof(*node_scores));
> + if (!node_scores) {
> + perror("malloc");
> + exit(1);
You cannot handle errors like this in the library.
It's not fully clear to me what the interface of your proposed new function
is. Can you send a spec of the new user interface in a manpage like format?
Also it would be good to have some more information on the use case.
My first reaction is that you can create any interleaving scheme you
want anyways using the low level functions.
-Andi
next prev parent reply other threads:[~2012-11-26 20:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 18:54 [PATCH] Custom interleaved allocation Vasileios Karakasis
2012-11-26 20:21 ` Andi Kleen [this message]
2012-11-27 16:39 ` Vasileios Karakasis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121126202106.GO16230@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=bkk@cslab.ece.ntua.gr \
--cc=linux-numa@vger.kernel.org \
--cc=thgoud@cslab.ece.ntua.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).