linux-numa.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: numactl problems with -C option specifying cpus outside of cpus_allowed
       [not found] <00000141799702db-dbec8157-ae1f-43b6-8a30-ec1653be5d31-000000@email.amazonses.com>
@ 2013-10-02 19:01 ` Andi Kleen
  2013-10-03 13:48   ` Christoph Lameter
  0 siblings, 1 reply; 6+ messages in thread
From: Andi Kleen @ 2013-10-02 19:01 UTC (permalink / raw)
  To: Christoph Lameter; +Cc: pholasek, linux-numa

On Wed, Oct 02, 2013 at 02:34:01PM +0000, Christoph Lameter wrote:
> It seems that the check for processors specified with C is always done
> regardless of CAP_SYS_NICE or the possibility that root may be calling
> numactl.
> 
> taskset does not have that problem. Nor did releases of numactl before
> 2.0.8.

The recently added --all option may help?

Copying linux-numa and Petr.

-Andi


-- 
ak@linux.intel.com -- Speaking for myself only.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: numactl problems with -C option specifying cpus outside of cpus_allowed
  2013-10-02 19:01 ` numactl problems with -C option specifying cpus outside of cpus_allowed Andi Kleen
@ 2013-10-03 13:48   ` Christoph Lameter
  2013-10-03 15:56     ` Petr Holasek
  0 siblings, 1 reply; 6+ messages in thread
From: Christoph Lameter @ 2013-10-03 13:48 UTC (permalink / raw)
  To: Andi Kleen; +Cc: pholasek, linux-numa

On Wed, 2 Oct 2013, Andi Kleen wrote:

> On Wed, Oct 02, 2013 at 02:34:01PM +0000, Christoph Lameter wrote:
> > It seems that the check for processors specified with C is always done
> > regardless of CAP_SYS_NICE or the possibility that root may be calling
> > numactl.
> >
> > taskset does not have that problem. Nor did releases of numactl before
> > 2.0.8.
>
> The recently added --all option may help?

Which version added --all? Would the correct approach not be to check if
its root runninng numactl or if CAP_SYS_NICE is set?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: numactl problems with -C option specifying cpus outside of cpus_allowed
  2013-10-03 13:48   ` Christoph Lameter
@ 2013-10-03 15:56     ` Petr Holasek
  2013-10-03 17:37       ` Christoph Lameter
  0 siblings, 1 reply; 6+ messages in thread
From: Petr Holasek @ 2013-10-03 15:56 UTC (permalink / raw)
  To: Christoph Lameter; +Cc: Andi Kleen, linux-numa

On Thu, 03 Oct 2013, Christoph Lameter wrote:
> On Wed, 2 Oct 2013, Andi Kleen wrote:
> 
> > On Wed, Oct 02, 2013 at 02:34:01PM +0000, Christoph Lameter wrote:
> > > It seems that the check for processors specified with C is always done
> > > regardless of CAP_SYS_NICE or the possibility that root may be calling
> > > numactl.
> > >
> > > taskset does not have that problem. Nor did releases of numactl before
> > > 2.0.8.
> >
> > The recently added --all option may help?
> 
> Which version added --all? Would the correct approach not be to check if
> its root runninng numactl or if CAP_SYS_NICE is set?

--all option was added in version 2.0.9-rc5. When CAP_SYS_NICE is not set,
numactl will fail in sched_setaffinity() call even so.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: numactl problems with -C option specifying cpus outside of cpus_allowed
  2013-10-03 15:56     ` Petr Holasek
@ 2013-10-03 17:37       ` Christoph Lameter
  2013-10-03 22:33         ` Andi Kleen
  0 siblings, 1 reply; 6+ messages in thread
From: Christoph Lameter @ 2013-10-03 17:37 UTC (permalink / raw)
  To: Petr Holasek; +Cc: Andi Kleen, linux-numa

On Thu, 3 Oct 2013, Petr Holasek wrote:

> On Thu, 03 Oct 2013, Christoph Lameter wrote:
> > On Wed, 2 Oct 2013, Andi Kleen wrote:
> >
> > > On Wed, Oct 02, 2013 at 02:34:01PM +0000, Christoph Lameter wrote:
> > > > It seems that the check for processors specified with C is always done
> > > > regardless of CAP_SYS_NICE or the possibility that root may be calling
> > > > numactl.
> > > >
> > > > taskset does not have that problem. Nor did releases of numactl before
> > > > 2.0.8.
> > >
> > > The recently added --all option may help?
> >
> > Which version added --all? Would the correct approach not be to check if
> > its root runninng numactl or if CAP_SYS_NICE is set?
>
> --all option was added in version 2.0.9-rc5. When CAP_SYS_NICE is not set,
> numactl will fail in sched_setaffinity() call even so.

numactl should allow the setting of affinities if CAP_SYS_NICE is set.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: numactl problems with -C option specifying cpus outside of cpus_allowed
  2013-10-03 17:37       ` Christoph Lameter
@ 2013-10-03 22:33         ` Andi Kleen
  2013-10-03 22:46           ` Petr Holasek
  0 siblings, 1 reply; 6+ messages in thread
From: Andi Kleen @ 2013-10-03 22:33 UTC (permalink / raw)
  To: Christoph Lameter; +Cc: Petr Holasek, Andi Kleen, linux-numa

> > --all option was added in version 2.0.9-rc5. When CAP_SYS_NICE is not set,
> > numactl will fail in sched_setaffinity() call even so.
> 
> numactl should allow the setting of affinities if CAP_SYS_NICE is set.

It does if you pass --all, correct?

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: numactl problems with -C option specifying cpus outside of cpus_allowed
  2013-10-03 22:33         ` Andi Kleen
@ 2013-10-03 22:46           ` Petr Holasek
  0 siblings, 0 replies; 6+ messages in thread
From: Petr Holasek @ 2013-10-03 22:46 UTC (permalink / raw)
  To: Andi Kleen; +Cc: Christoph Lameter, linux-numa

On Fri, 04 Oct 2013, Andi Kleen wrote:
> > > --all option was added in version 2.0.9-rc5. When CAP_SYS_NICE is not set,
> > > numactl will fail in sched_setaffinity() call even so.
> > 
> > numactl should allow the setting of affinities if CAP_SYS_NICE is set.
> 
> It does if you pass --all, correct?
> 
> -Andi
> 

Yes, you're right.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2013-10-03 22:46 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <00000141799702db-dbec8157-ae1f-43b6-8a30-ec1653be5d31-000000@email.amazonses.com>
2013-10-02 19:01 ` numactl problems with -C option specifying cpus outside of cpus_allowed Andi Kleen
2013-10-03 13:48   ` Christoph Lameter
2013-10-03 15:56     ` Petr Holasek
2013-10-03 17:37       ` Christoph Lameter
2013-10-03 22:33         ` Andi Kleen
2013-10-03 22:46           ` Petr Holasek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).