From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cliff Wickman <cpw@sgi.com>
Subject: Re: [PATCH] build-sys: prevent warning about .depend when running
 make
Date: Wed, 23 Jul 2014 07:26:19 -0500
Message-ID: <20140723122619.GA23761@sgi.com>
References: <1406065795-30520-1-git-send-email-filbranden@google.com>
Mime-Version: 1.0
Return-path: <linux-numa-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <1406065795-30520-1-git-send-email-filbranden@google.com>
Sender: linux-numa-owner@vger.kernel.org
List-ID: <linux-numa.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Filipe Brandenburger <filbranden@google.com>
Cc: linux-numa@vger.kernel.org, Greg Thelen <gthelen@google.com>

Hi Filipe,

Applied.  (numactl-2.0.10-rc2)

Thanks.

-Cliff

On Tue, Jul 22, 2014 at 02:49:55PM -0700, Filipe Brandenburger wrote:
> This is the typical warning:
>   $ make clean >/dev/null
>   Makefile:200: .depend: No such file or directory
> 
> It happens because there is no rule to build .depend before executing
> the make action.
> 
> Ignoring errors when including generated dependency information seems to
> be the norm in Makefiles, so we might as well do it here.
> 
> Tested:
> - Checked that the warning is gone with the patch:
>   $ make clean >/dev/null
>   (empty)
> - Built libnuma and ran make test_numademo, confirmed it works.
> 
> Signed-off-by: Filipe Brandenburger <filbranden@google.com>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index fe42638fbca4..53191af58f8f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -197,7 +197,7 @@ depend: .depend
>  .depend:
>  	${CC} -MM -DDEPS_RUN -I. ${SOURCES} > .depend.X && mv .depend.X .depend
>  
> -include .depend
> +-include .depend
>  
>  Makefile: .depend
>  
> -- 
> 2.0.0.526.g5318336

-- 
Cliff Wickman
SGI
cpw@sgi.com
(651) 683-3824
(651) 482-9347h