* [PATCH] build-sys: prevent warning about .depend when running make
@ 2014-07-22 21:49 Filipe Brandenburger
2014-07-23 12:26 ` Cliff Wickman
0 siblings, 1 reply; 2+ messages in thread
From: Filipe Brandenburger @ 2014-07-22 21:49 UTC (permalink / raw)
To: Cliff Wickman, linux-numa; +Cc: Greg Thelen, Filipe Brandenburger
This is the typical warning:
$ make clean >/dev/null
Makefile:200: .depend: No such file or directory
It happens because there is no rule to build .depend before executing
the make action.
Ignoring errors when including generated dependency information seems to
be the norm in Makefiles, so we might as well do it here.
Tested:
- Checked that the warning is gone with the patch:
$ make clean >/dev/null
(empty)
- Built libnuma and ran make test_numademo, confirmed it works.
Signed-off-by: Filipe Brandenburger <filbranden@google.com>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index fe42638fbca4..53191af58f8f 100644
--- a/Makefile
+++ b/Makefile
@@ -197,7 +197,7 @@ depend: .depend
.depend:
${CC} -MM -DDEPS_RUN -I. ${SOURCES} > .depend.X && mv .depend.X .depend
-include .depend
+-include .depend
Makefile: .depend
--
2.0.0.526.g5318336
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] build-sys: prevent warning about .depend when running make
2014-07-22 21:49 [PATCH] build-sys: prevent warning about .depend when running make Filipe Brandenburger
@ 2014-07-23 12:26 ` Cliff Wickman
0 siblings, 0 replies; 2+ messages in thread
From: Cliff Wickman @ 2014-07-23 12:26 UTC (permalink / raw)
To: Filipe Brandenburger; +Cc: linux-numa, Greg Thelen
Hi Filipe,
Applied. (numactl-2.0.10-rc2)
Thanks.
-Cliff
On Tue, Jul 22, 2014 at 02:49:55PM -0700, Filipe Brandenburger wrote:
> This is the typical warning:
> $ make clean >/dev/null
> Makefile:200: .depend: No such file or directory
>
> It happens because there is no rule to build .depend before executing
> the make action.
>
> Ignoring errors when including generated dependency information seems to
> be the norm in Makefiles, so we might as well do it here.
>
> Tested:
> - Checked that the warning is gone with the patch:
> $ make clean >/dev/null
> (empty)
> - Built libnuma and ran make test_numademo, confirmed it works.
>
> Signed-off-by: Filipe Brandenburger <filbranden@google.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index fe42638fbca4..53191af58f8f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -197,7 +197,7 @@ depend: .depend
> .depend:
> ${CC} -MM -DDEPS_RUN -I. ${SOURCES} > .depend.X && mv .depend.X .depend
>
> -include .depend
> +-include .depend
>
> Makefile: .depend
>
> --
> 2.0.0.526.g5318336
--
Cliff Wickman
SGI
cpw@sgi.com
(651) 683-3824
(651) 482-9347h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-23 12:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-22 21:49 [PATCH] build-sys: prevent warning about .depend when running make Filipe Brandenburger
2014-07-23 12:26 ` Cliff Wickman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).