From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Lankes Subject: Re: [RFC PATCH 0/4]: affinity-on-next-touch Date: Mon, 22 Jun 2009 19:59:38 +0200 Message-ID: <4A3FC68A.2030104@lfbs.rwth-aachen.de> References: <000c01c9d212$4c244720$e46cd560$@rwth-aachen.de> <87zldjn597.fsf@basil.nowhere.org> <000001c9eac4$cb8b6690$62a233b0$@rwth-aachen.de> <20090612103251.GJ25568@one.firstfloor.org> <004001c9eb53$71991300$54cb3900$@rwth-aachen.de> <1245119977.6724.40.camel@lts-notebook> <003001c9ee8a$97e5b100$c7b11300$@rwth-aachen.de> <1245164395.15138.40.camel@lts-notebook> <000501c9ef1f$930fa330$b92ee990$@rwth-aachen.de> <1245299856.6431.30.camel@lts-notebook> <4A3F7A49.6070805@inria.fr> <1245680649.7799.54.camel@lts-notebook> <4A3FA326.8030802@inria.fr> <1245689724.7799.124.camel@lts-notebook> <4A3FBA11.8030304@inria.fr> Mime-Version: 1.0 Content-Transfer-Encoding: 7BIT Return-path: In-reply-to: <4A3FBA11.8030304@inria.fr> Sender: linux-numa-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Brice Goglin Cc: Lee Schermerhorn , 'Andi Kleen' , linux-kernel@vger.kernel.org, linux-numa@vger.kernel.org, Boris Bierbaum , KAMEZAWA Hiroyuki , Balbir Singh , KOSAKI Motohiro Brice Goglin wrote: > Lee Schermerhorn wrote: >> The primary difference should be at unmap time, right? In the fault >> path, I only update the pte of the faulting task. That's why I require >> the [anon] pages to be in the swap cache [or something similar]. I >> don't want to be fixing up other tasks' page tables in the context of >> the faulting task's fault handler. If, later, another task touches the >> page, it will take a minor fault and find the [possibly migrated] page >> in the cache. Hmmm, I guess all tasks WILL incur the minor fault if >> they touch the page after the unmap. That could be part of the >> difference if you compare on the same kernel version. >> > > Agreed. > >> Try booting with cgroup_disable=memory on the command line, if you have >> the memory resource controller configured in. See what that does to >> your measurements. >> > > It doesn't seem to help. I'll try to bisect and find where the > performance dropped. > I am not able to reconstruct any performance drawbacks on my system. Could you send me your low-level benchmark? Stefan