From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: "Christoph Hellwig" <hch@lst.de>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
linux-mips <linux-mips@linux-mips.org>,
"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>,
"David Howells" <dhowells@redhat.com>,
sparclinux@vger.kernel.org,
"Hans-Christian Egtvedt" <egtvedt@samfundet.no>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
linux-s390 <linux-s390@vger.kernel.org>,
"the arch/x86 maintainers" <x86@kernel.org>,
"David Woodhouse" <dwmw2@infradead.org>,
"Håvard Skinnemoen" <hskinnemoen@gmail.com>,
linux-xtensa@linux-xtensa.org, grundler@parisc-linux.org,
"Miao Steven" <realmz6@gmail.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
linux-metag@vger.kernel.org, "Jens Axboe" <axboe@kernel.dk>,
"Michal Simek" <monstr@monstr.eu>,
"Parisc List" <linux-parisc@vger.kernel.org>,
"Vineet Gupta" <vgupta@synopsys.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
linux-alpha@vger.kernel.org,
"Linux Media Mailing List" <linux-media@vger.kernel.org>,
ppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 29/31] parisc: handle page-less SG entries
Date: Thu, 13 Aug 2015 20:59:20 -0700 [thread overview]
Message-ID: <1439524760.8421.23.camel@HansenPartnership.com> (raw)
In-Reply-To: <CAA9_cmcNA__N_yVTKsEqLAKBuoL-hx73t6opdsmb7w-0qKXaWg@mail.gmail.com>
On Thu, 2015-08-13 at 20:30 -0700, Dan Williams wrote:
> On Thu, Aug 13, 2015 at 7:31 AM, Christoph Hellwig <hch@lst.de> wrote:
> > On Wed, Aug 12, 2015 at 09:01:02AM -0700, Linus Torvalds wrote:
> >> I'm assuming that anybody who wants to use the page-less
> >> scatter-gather lists always does so on memory that isn't actually
> >> virtually mapped at all, or only does so on sane architectures that
> >> are cache coherent at a physical level, but I'd like that assumption
> >> *documented* somewhere.
> >
> > It's temporarily mapped by kmap-like helpers. That code isn't in
> > this series. The most recent version of it is here:
> >
> > https://git.kernel.org/cgit/linux/kernel/git/djbw/nvdimm.git/commit/?h=pfn&id=de8237c99fdb4352be2193f3a7610e902b9bb2f0
> >
> > note that it's not doing the cache flushing it would have to do yet, but
> > it's also only enabled for x86 at the moment.
>
> For virtually tagged caches I assume we would temporarily map with
> kmap_atomic_pfn_t(), similar to how drm_clflush_pages() implements
> powerpc support. However with DAX we could end up with multiple
> virtual aliases for a page-less pfn.
At least on some PA architectures, you have to be very careful.
Improperly managed, multiple aliases will cause the system to crash
(actually a machine check in the cache chequerboard). For the most
temperamental systems, we need the cache line flushed and the alias
mapping ejected from the TLB cache before we access the same page at an
inequivalent alias.
James
next prev parent reply other threads:[~2015-08-14 3:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1439363150-8661-1-git-send-email-hch@lst.de>
[not found] ` <1439363150-8661-30-git-send-email-hch@lst.de>
2015-08-12 16:01 ` [PATCH 29/31] parisc: handle page-less SG entries Linus Torvalds
2015-08-13 14:31 ` Christoph Hellwig
2015-08-14 3:30 ` Dan Williams
2015-08-14 3:59 ` James Bottomley [this message]
[not found] ` <1439363150-8661-32-git-send-email-hch@lst.de>
2015-08-12 16:05 ` [PATCH 31/31] dma-mapping-common: skip kmemleak checks for " Linus Torvalds
2015-08-13 14:33 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439524760.8421.23.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=alex.williamson@redhat.com \
--cc=axboe@kernel.dk \
--cc=dan.j.williams@intel.com \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=egtvedt@samfundet.no \
--cc=grundler@parisc-linux.org \
--cc=hch@lst.de \
--cc=hskinnemoen@gmail.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-metag@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=monstr@monstr.eu \
--cc=realmz6@gmail.com \
--cc=sparclinux@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vgupta@synopsys.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox