From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [ndctl PATCH 3/3] ndctl: add 'clear error' command support
Date: Fri, 11 Mar 2016 01:19:39 +0000 [thread overview]
Message-ID: <1457659174.4525.39.camel@intel.com> (raw)
In-Reply-To: <20160311004526.27582.46416.stgit@dwillia2-desk3.jf.intel.com>
On Thu, 2016-03-10 at 16:45 -0800, Dan Williams wrote:
> Import the clear error command definition from the latest kernel, wire
> it up with a new ndctl_bus_cmd_new_clear_error() api, and add an
> invocation to the unit test.
>
> Since, the unit test requires the ability to recall the range of an
> ars_cap command a new ndctl_cmd_ars_cap_get_range() api is added.
>
> Reported-by: Vishal Verma <vishal.l.verma@intel.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
> configure.ac | 19 +++++++
> lib/libndctl-ars.c | 125
> +++++++++++++++++++++++++++++++++++++++++++-----
> lib/libndctl-private.h | 5 ++
> lib/libndctl.c | 3 +
> lib/libndctl.sym | 3 +
> lib/ndctl/libndctl.h | 41 +++++++++++++++-
> ndctl.h | 13 +++++
> test/libndctl.c | 62 +++++++++++++++++++++++-
> 8 files changed, 253 insertions(+), 18 deletions(-)
>
>
<>
> diff --git a/ndctl.h b/ndctl.h
> index 0c50ff4dc3b1..11c4adf7f49c 100644
> --- a/ndctl.h
> +++ b/ndctl.h
> @@ -98,6 +98,14 @@ struct nd_cmd_ars_status {
> } __attribute__((packed)) records[0];
> } __attribute__((packed));
>
> +struct nd_cmd_clear_error {
> + __u64 address;
> + __u64 length;
> + __u32 status;
> + __u8 reserved[4];
> + __u64 cleared;
> +} __attribute__((packed));
> +
> enum {
> ND_CMD_IMPLEMENTED = 0,
>
> @@ -105,6 +113,7 @@ enum {
> ND_CMD_ARS_CAP = 1,
> ND_CMD_ARS_START = 2,
> ND_CMD_ARS_STATUS = 3,
> + ND_CMD_CLEAR_ERROR = 4,
>
> /* per-dimm commands */
> ND_CMD_SMART = 1,
> @@ -129,6 +138,7 @@ static __inline__ const char
> *nvdimm_bus_cmd_name(unsigned cmd)
> [ND_CMD_ARS_CAP] = "ars_cap",
> [ND_CMD_ARS_START] = "ars_start",
> [ND_CMD_ARS_STATUS] = "ars_status",
> + [ND_CMD_CLEAR_ERROR] = "clear_error",
> };
>
> if (cmd < ARRAY_SIZE(names) && names[cmd])
> @@ -187,6 +197,9 @@ static __inline__ const char
> *nvdimm_cmd_name(unsigned cmd)
> #define ND_IOCTL_ARS_STATUS _IOWR(ND_IOCTL,
> ND_CMD_ARS_STATUS,\
> struct nd_cmd_ars_status)
>
> +#define ND_IOCTL_CLEAR_ERROR _IOWR(ND_IOCTL,
> ND_CMD_CLEAR_ERROR,\
> + struct nd_cmd_ars_status)
> +
Did you copy from the old version of this kernel header with the copy-
paste error :)
Rest of it looks good,
Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2016-03-11 1:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 0:45 [ndctl PATCH 0/3] ndctl: clear error support for v52 Dan Williams
2016-03-11 0:45 ` [ndctl PATCH 1/3] ndctl: fix ndctl_bus_cmd_new_ars_status() input validation Dan Williams
2016-03-11 1:17 ` Verma, Vishal L
2016-03-11 0:45 ` [ndctl PATCH 2/3] ndctl: disable nfit_test regions after test Dan Williams
2016-03-11 0:45 ` [ndctl PATCH 3/3] ndctl: add 'clear error' command support Dan Williams
2016-03-11 1:19 ` Verma, Vishal L [this message]
2016-03-11 4:08 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457659174.4525.39.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox