From: Vishal Verma <vishal@kernel.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [RFC v6 2/8] nvdimm: Add wrapper for IOCTL pass thru
Date: Sun, 13 Mar 2016 21:15:31 -0600 [thread overview]
Message-ID: <1457925331.4102.1.camel@kernel.org> (raw)
In-Reply-To: <CAPcyv4itG0tyBLW7G1babYVd8UDyTG2Vg8xbwddz6n0z02LYdw@mail.gmail.com>
On Sat, 2016-03-12 at 09:50 -0800, Dan Williams wrote:
> On Sat, Mar 12, 2016 at 7:49 AM, Vishal Verma <vishal@kernel.org>
> wrote:
> >
> > On Fri, Mar 11, 2016 at 4:29 PM, Jerry Hoemann <jerry.hoemann@hpe.c
> > om> wrote:
> > >
> > > >
> > > > Also let's drop the ncp_
> > > > prefix,
> > > > it's non-idiomatic with the rest of the definitions in this
> > > > file.
> > >
> > > I like field names with prefixes that refer back to the structure
> > > they're
> > > defined in. It makes reading code easier. (e.g. how many times
> > > is
> > > "size" defined in a struct?)
> > >
> > > would you be okay with a prefix "nd_"? it doesn't quite tie as
> > > closely
> > > to the struct, but it should make them unique w/in the kernel.
> > Isn't this leaning towards the "Hungarian notation", and isn't that
> > discouraged in the kernel coding style..
> >
> > From Documentation/CodingStyle
> >
> > Encoding the type of a function into the name (so-called Hungarian
> > notation) is brain damaged - the compiler knows the types anyway
> > and can
> > check those, and it only confuses the programmer.
> I wouldn't go that far... look at "struct bio", "struct file", or
> "struct nd_region" that have a common prefix for (some) member
> fields.
> That's not Hungarian notation, that's making the code easier to grep.
Ah yes - agreed.
> _______________________________________________
> Linux-nvdimm mailing list
> Linux-nvdimm@lists.01.org
> https://lists.01.org/mailman/listinfo/linux-nvdimm
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2016-03-14 3:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1457730736.git.jerry.hoemann@hpe.com>
2016-03-11 21:16 ` [RFC v6 1/8] ACPI / util: Fix acpi_evaluate_dsm() argument type Jerry Hoemann
2016-03-11 21:16 ` [RFC v6 2/8] nvdimm: Add wrapper for IOCTL pass thru Jerry Hoemann
2016-03-11 22:04 ` Dan Williams
2016-03-11 23:29 ` Jerry Hoemann
2016-03-11 23:48 ` Dan Williams
2016-03-13 19:15 ` Jerry Hoemann
2016-03-13 19:43 ` Dan Williams
2016-03-12 15:49 ` Vishal Verma
2016-03-12 17:50 ` Dan Williams
2016-03-14 3:15 ` Vishal Verma [this message]
2016-03-11 21:16 ` [RFC v6 3/8] nvdimm: Increase max envelope size for IOCTL Jerry Hoemann
2016-03-11 21:16 ` [RFC v6 4/8] nvdimm: Add UUIDs Jerry Hoemann
2016-03-11 21:16 ` [RFC v6 5/8] nvdimm: data structure changes for dsm calls Jerry Hoemann
2016-03-11 21:16 ` [RFC v6 6/8] libnvdimm: advertise 'call_dsm' support Jerry Hoemann
2016-03-11 21:16 ` [RFC v6 7/8] nvdimm: Add IOCTL pass thru functions Jerry Hoemann
2016-03-11 21:16 ` [RFC v6 8/8] tools/testing/nvdimm: 'call_dsm' support Jerry Hoemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457925331.4102.1.camel@kernel.org \
--to=vishal@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox