From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 925D31A1ED5 for ; Fri, 7 Oct 2016 14:09:14 -0700 (PDT) From: Ross Zwisler Subject: [PATCH v5 05/17] ext2: return -EIO on ext2_iomap_end() failure Date: Fri, 7 Oct 2016 15:08:52 -0600 Message-Id: <1475874544-24842-6-git-send-email-ross.zwisler@linux.intel.com> In-Reply-To: <1475874544-24842-1-git-send-email-ross.zwisler@linux.intel.com> References: <1475874544-24842-1-git-send-email-ross.zwisler@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: linux-kernel@vger.kernel.org Cc: Theodore Ts'o , Matthew Wilcox , Dave Chinner , linux-nvdimm@lists.01.org, Christoph Hellwig , linux-xfs@vger.kernel.org, linux-mm@kvack.org, Andreas Dilger , Alexander Viro , Jan Kara , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, Andrew Morton List-ID: Right now we just return 0 for success, but we really want to let callers know about this failure. Signed-off-by: Ross Zwisler --- fs/ext2/inode.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c index c7dbb46..368913c 100644 --- a/fs/ext2/inode.c +++ b/fs/ext2/inode.c @@ -830,8 +830,10 @@ ext2_iomap_end(struct inode *inode, loff_t offset, loff_t length, { if (iomap->type == IOMAP_MAPPED && written < length && - (flags & IOMAP_WRITE)) + (flags & IOMAP_WRITE)) { ext2_write_failed(inode->i_mapping, offset + length); + return -EIO; + } return 0; } -- 2.7.4 _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm