From: "Kani, Toshimitsu" <toshi.kani@hpe.com>
To: "dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"dave.jiang@intel.com" <dave.jiang@intel.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH v4] ndctl: add clear error support for ndctl
Date: Tue, 2 May 2017 16:48:05 +0000 [thread overview]
Message-ID: <1493743683.30303.38.camel@hpe.com> (raw)
In-Reply-To: <dc1d6252-9c8c-5298-2823-2609db70ceb6@intel.com>
On Tue, 2017-05-02 at 09:18 -0700, Dave Jiang wrote:
>
> On 05/01/2017 05:16 PM, Kani, Toshimitsu wrote:
> > On Mon, 2017-05-01 at 16:33 -0700, Dave Jiang wrote:
> > :
> > > +EXAMPLES
> > > +--------
> > > +
> > > +Clear poison (bad blocks) for the provided device
> > > +[verse]
> > > +ndctl clear-error -f /dev/dax0.0 -s 0 -l 8
> > > +
> > > +Clear poison (bad blocks) at block offset 0 for 8 blocks on
> > > device
> > > /dev/dax0.0
> > > +
> > > +OPTIONS
> > > +-------
> > > +-f::
> > > +--file::
> > > +The device/file to be cleared of poison (bad blocks).
> > > +
> > > +-s::
> > > +--start::
> > > +The offset where the poison (bad block) starts for this
> > > device.
> > > +Typically this is acquired from the sysfs badblocks file.
> > > +
> > > +-l::
> > > +--len::
> > > +The number of badblocks to clear in size of 512 bytes
> > > increments. The
> > > +length must fit within the badblocks range. If the length
> > > exceeds the
> > > +badblock range or is 0, the command will fail.
> >
> > Actually, I am seeing '-l 0' works just like '-l 1'.
>
> Oh now I remembered that Vishal requested that no length does 1 block
> clear. Do you want me to correct documentation or behavior?
What is the reason behind of his request?
Thanks,
-Toshi
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2017-05-02 16:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-01 23:33 [PATCH v4] ndctl: add clear error support for ndctl Dave Jiang
2017-05-02 0:16 ` Kani, Toshimitsu
2017-05-02 16:18 ` Dave Jiang
2017-05-02 16:48 ` Kani, Toshimitsu [this message]
2017-05-02 18:43 ` Vishal Verma
2017-05-02 18:51 ` Dan Williams
2017-05-02 18:57 ` Kani, Toshimitsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493743683.30303.38.camel@hpe.com \
--to=toshi.kani@hpe.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox