From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Jiang, Dave" <dave.jiang@intel.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH v5] ndctl: add clear error support for ndctl
Date: Wed, 3 May 2017 00:11:44 +0000 [thread overview]
Message-ID: <1493770222.20330.0.camel@intel.com> (raw)
In-Reply-To: <252297ca-d163-2f53-f97f-a792725b05b6@intel.com>
On Tue, 2017-05-02 at 17:08 -0700, Dave Jiang wrote:
> On 05/02/2017 04:54 PM, Vishal Verma wrote:
> > On 05/02, Dave Jiang wrote:
> > >
> > > +
> > > + if (!S_ISCHR(stats.st_mode)) {
> > > + error("%s not DAX device\n", dev_name);
> > > + return -1;
> > > + }
> > > +
> >
> > A more general question, we're restricting the clear-error command
> > to
> > dax devs, but is there any reason to do that? Why not just allow
> > clearing errors for normal namespaces too using this?
>
> The thinking was to get the dax devs support in initially and then add
> everything else in the next iteration.
>
Ah ok, that's fine.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
prev parent reply other threads:[~2017-05-03 0:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-02 20:26 [PATCH v5] ndctl: add clear error support for ndctl Dave Jiang
2017-05-02 20:54 ` Dan Williams
2017-05-02 21:21 ` Kani, Toshimitsu
2017-05-02 21:24 ` Dan Williams
2017-05-02 23:54 ` Vishal Verma
2017-05-03 0:08 ` Dave Jiang
2017-05-03 0:11 ` Verma, Vishal L [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493770222.20330.0.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=dave.jiang@intel.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox