Linux-NVDIMM Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Vishal Verma <vishal@kernel.org>
To: Dan Williams <dan.j.williams@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH] libnvdimm: fix the clear-error check in nsio_rw_bytes
Date: Sat, 01 Jul 2017 23:22:03 -0600	[thread overview]
Message-ID: <1498972923.28685.1.camel@kernel.org> (raw)
In-Reply-To: <CAPcyv4jz_zOGieP+TeF0yPUMBgh1qDkFoms2W4g=+hN1-SZcBw@mail.gmail.com>

On Fri, 2017-06-30 at 18:39 -0700, Dan Williams wrote:
> On Fri, Jun 30, 2017 at 5:32 PM, Vishal Verma <vishal.l.verma@intel.c
> om> wrote:
> > A leftover from the 'bandaid' fix that disabled BTT error clearing
> > in
> > rw_bytes resulted in an incorrect check. After we converted these
> > checks
> > over to use the NVDIMM_IO_ATOMIC flag, the ndns->claim check was
> > both
> > redundant, and incorrect. Remove it.
> > 
> > Cc: Dave Jiang <dave.jiang@intel.com>
> > Cc: Dan Williams <dan.j.williams@intel.com>
> > Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
> > ---
> >  drivers/nvdimm/claim.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/drivers/nvdimm/claim.c b/drivers/nvdimm/claim.c
> > index 8d23f68..f8ad92b 100644
> > --- a/drivers/nvdimm/claim.c
> > +++ b/drivers/nvdimm/claim.c
> > @@ -289,8 +289,7 @@ static int nsio_rw_bytes(struct
> > nd_namespace_common *ndns,
> >                  * work around this collision.
> >                  */
> >                 if (IS_ALIGNED(offset, 512) && IS_ALIGNED(size,
> > 512)
> > -                               && !(flags & NVDIMM_IO_ATOMIC)
> > -                               && !ndns->claim) {
> > +                               && !(flags & NVDIMM_IO_ATOMIC)) {
> 
> Should this also go to -stable otherwise we won't clear errors on
> pmem
> devices claimed by 'pfn' instances, right?

Yes I think it should..
Should I just resend with stable CC'd?

> _______________________________________________
> Linux-nvdimm mailing list
> Linux-nvdimm@lists.01.org
> https://lists.01.org/mailman/listinfo/linux-nvdimm

_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

  reply	other threads:[~2017-07-02  5:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-01  0:32 [PATCH] libnvdimm, btt: convert some info messages to warn/err Vishal Verma
2017-07-01  0:32 ` [PATCH] libnvdimm: fix the clear-error check in nsio_rw_bytes Vishal Verma
2017-07-01  1:39   ` Dan Williams
2017-07-02  5:22     ` Vishal Verma [this message]
2017-07-01  2:20 ` [PATCH] libnvdimm, btt: convert some info messages to warn/err Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1498972923.28685.1.camel@kernel.org \
    --to=vishal@kernel.org \
    --cc=dan.j.williams@intel.com \
    --cc=linux-nvdimm@lists.01.org \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox