Re: [PATCH v1 2/6] fs: use on-stack-bio if backing device has BDI_CAP_SYNC capability

Matthew Wilcox
2017-08-08T13:29:04Z

On Tue, Aug 08, 2017 at 05:49:59AM -0700, Matthew Wilcox wrote:
> + struct bio sbio;
> + struct bio_vec sbvec;

... this needs to be sbvec[nr_pages], of course.

> - bio = mpage_alloc(bdev, blocks[0] << (blkbits - 9),
> + if (bdi_cap_synchronous_io(inode_to_bdi(inode))) {
> + bio = &sbio;
> + bio_init(bio, &sbvec, nr_pages);

... and this needs to be 'sbvec', not '&sbvec'.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: email@kvack.org