Re: [ndctl PATCH 7/7] ndctl: auto initialize labels

["Verma, Vishal L" <vishal.l.verma@intel.com>]

On Tue, 2017-08-29 at 14:48 -0700, Dan Williams wrote:
> On Tue, Aug 29, 2017 at 2:32 PM, Verma, Vishal L
> <vishal.l.verma@intel.com> wrote:
> > On Tue, 2017-08-29 at 13:02 -0700, Dan Williams wrote:
> > > If we are reconfiguring an ND_DEVICE_NAMESPACE_IO namespace take
> > > the
> > > opportunity to potentially initialize labels. DIMM capacity that
> > > is
> > > not
> > > aliased will surface as a label-less namespace by default. If
> > > every
> > > DIMM
> > > in the interleave set supports labels we can switch a more dynamic
> > > configuration, i.e. enable pmem sub-division.
> > > 
> > > The --no-autolabel option is added to disable this behavior if it
> > > is
> > > not
> > > wanted.
> > > 
> > > Cc: Vishal Verma <vishal.l.verma@intel.com>
> > > Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> > > ---
> > >  Documentation/ndctl/ndctl-create-namespace.txt |    7 ++
> > >  ndctl/namespace.c                              |   90
> > > +++++++++++++++++++++++-
> > >  2 files changed, 95 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/Documentation/ndctl/ndctl-create-namespace.txt
> > > b/Documentation/ndctl/ndctl-create-namespace.txt
> > > index 85d1f8db792f..3844ff74a9f1 100644
> > > --- a/Documentation/ndctl/ndctl-create-namespace.txt
> > > +++ b/Documentation/ndctl/ndctl-create-namespace.txt
> > > @@ -138,6 +138,13 @@ OPTIONS
> > >       active.  Specifying --force causes the namespace to be
> > > disabled
> > >       before reconfiguring.
> > > 
> > > +-L::
> > > +--autolabel::
> > 
> > Shouldn't this be --no-autolabel
> > 
> > > +     When ndctl encounters a label-less namespace while
> > > +     performing a reconfigure operation it will try to enable
> > > labels
> > > +     for the region. This behavior can be suppressed with
> > > +     "--no-autolabel".
> > 
> > And the text description matched to describe only the --no-autolabel
> > option instead of describing both a positive and negative
> 
> I'm using a side effect of the way ndctl (and git) implement
> OPT_BOOLEAN() options. They all automatically get a --no-<option>. So
> "--autolabel" is the default.
> 
Ah cool, I didn't know OPT_BOOLEAN does that for you.
Does the 'no' option then lack a short option? We'll end up providing a
short option for the default case, but nothing for the override..

I'm also wondering if there will be any bash completion implications.
I'll test whether the --no- option shows up automatically in --list-opts
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm