From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH 2/4] nfit_test: add error injection DSMs
Date: Mon, 9 Oct 2017 20:53:21 +0000 [thread overview]
Message-ID: <1507582277.23025.80.camel@intel.com> (raw)
In-Reply-To: <CAPcyv4gvvYGxJnkCJttEymi8NbqDZLvk0CKhdZ8x-x-P0Nb_0A@mail.gmail.com>
On Mon, 2017-10-09 at 13:40 -0700, Dan Williams wrote:
> On Mon, Oct 9, 2017 at 1:25 PM, Verma, Vishal L
> <vishal.l.verma@intel.com> wrote:
> > On Sat, 2017-10-07 at 10:07 -0700, Dan Williams wrote:
> > > On Thu, Oct 5, 2017 at 6:53 PM, Vishal Verma <vishal.l.verma@intel
> > > .com
> > > > wrote:
> >
> > []
> >
> > > > NFIT_ARS_TIMEOUT = 90,
> > > > + NFIT_ARS_INJECT_INVALID = 2,
> > >
> > > If there is no usage of this define outside of nfit_test then it
> > > should be defined in tools/testing/nvdimm/test/nfit.h.
> >
> > Yes moved.
> >
> > >
> > > > };
> > > >
> > > > enum nfit_root_notifiers {
> > > > diff --git a/tools/testing/nvdimm/Kbuild
> > > > b/tools/testing/nvdimm/Kbuild
> > > > index d870520..3272ab5 100644
> > > > --- a/tools/testing/nvdimm/Kbuild
> > > > +++ b/tools/testing/nvdimm/Kbuild
> > > > @@ -69,6 +69,7 @@ libnvdimm-y += $(NVDIMM_SRC)/region_devs.o
> > > > libnvdimm-y += $(NVDIMM_SRC)/region.o
> > > > libnvdimm-y += $(NVDIMM_SRC)/namespace_devs.o
> > > > libnvdimm-y += $(NVDIMM_SRC)/label.o
> > > > +libnvdimm-y += $(NVDIMM_SRC)/badrange.o
> > >
> > > This hunk should go in the same patch that changes
> > > drivers/nvdimm/Makefile to add badrange.o so we don't have an
> > > nfit_test compile breakage gap between commits.
> >
> > The kernel's normal usage already has the kbuild change in the right
> > place (patch 1). This adds the use of badrange functions to
> > nfit_test
> > for the first time, and hence the kbuild addition here.
>
> It's not the nfit_test usages I'm worried about. The internal calls in
> libnvdimm will break. Try building tools/testing/nvdimm/libnvdimm.ko
> with only patch1 applied.
Ah I see what the problem is, I'll send a v3
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2017-10-09 20:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-06 1:53 [PATCH 0/4] add error injection commands to nfit_test Vishal Verma
2017-10-06 1:53 ` [PATCH 1/4] libnvdimm: move poison list functions to a new 'badrange' file Vishal Verma
2017-10-06 18:52 ` Dan Williams
2017-10-09 20:23 ` Verma, Vishal L
2017-10-06 1:53 ` [PATCH 2/4] nfit_test: add error injection DSMs Vishal Verma
2017-10-07 17:07 ` Dan Williams
2017-10-09 20:25 ` Verma, Vishal L
2017-10-09 20:40 ` Dan Williams
2017-10-09 20:53 ` Verma, Vishal L [this message]
2017-10-06 1:53 ` [PATCH 3/4] libnvdimm, badrange: remove a WARN for list_empty Vishal Verma
2017-10-06 1:53 ` [PATCH 4/4] nfit_test: when clearing poison, also remove badrange entries Vishal Verma
2017-10-09 16:12 ` Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507582277.23025.80.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox