From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH v3] libnvdimm, testing: Add emulation for smart injection commands
Date: Thu, 8 Feb 2018 21:08:04 +0000 [thread overview]
Message-ID: <1518124082.8128.53.camel@intel.com> (raw)
In-Reply-To: <CAPcyv4jrtkoXH+pH1xDPatickpMpQLJqUciig1XaD=hqBw6u8Q@mail.gmail.com>
On Thu, 2018-02-08 at 12:54 -0800, Dan Williams wrote:
> On Thu, Feb 8, 2018 at 12:49 PM, Vishal Verma <vishal.l.verma@intel.c
> om> wrote:
> > Add support for the smart injection command in the nvdimm unit test
> > framework. This allows for directly injecting to smart fields and
> > flags
> > that are supported in the injection command. If the injected values
> > are
> > past the threshold, then an acpi notification is also triggered.
> >
> > Also update the default smart ctrl_temperature to start out below
> > the
> > default threshold instead of at it. This prevents arbitrary smart
> > injections from triggering an acpi notification
>
> Any sentence starting with "Also" in a changelog is almost always an
> indication to split the patch in 2 so the topics can be independently
> bisected.
True, I did read that advice somewhere, but I figured these are related
enough that they can go together. But I agree separating them for
bisectability can be useful, I'll send a new revision
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
prev parent reply other threads:[~2018-02-08 21:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 20:49 [PATCH v3] libnvdimm, testing: Add emulation for smart injection commands Vishal Verma
2018-02-08 20:54 ` Dan Williams
2018-02-08 21:08 ` Verma, Vishal L [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518124082.8128.53.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).