From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 55BA12096FACE for ; Tue, 26 Jun 2018 09:27:38 -0700 (PDT) From: "Verma, Vishal L" Subject: Re: [PATCH] ndctl: Use max_available_extent for creating namespaces Date: Tue, 26 Jun 2018 16:27:36 +0000 Message-ID: <1530030454.27147.23.camel@intel.com> References: <20180626153736.6770-1-keith.busch@intel.com> <20180626153736.6770-3-keith.busch@intel.com> <1530029963.27147.21.camel@intel.com> <20180626162924.GB6754@localhost.localdomain> In-Reply-To: <20180626162924.GB6754@localhost.localdomain> Content-Language: en-US Content-ID: MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "Busch, Keith" Cc: "y-goto@jp.fujitsu.com" , "linux-nvdimm@lists.01.org" List-ID: On Tue, 2018-06-26 at 10:29 -0600, Keith Busch wrote: > On Tue, Jun 26, 2018 at 09:19:28AM -0700, Verma, Vishal L wrote: > > On Tue, 2018-06-26 at 09:37 -0600, Keith Busch wrote: > > > The available_size attribute returns all the unused regions, but a > > > namespace has to use contiguous free regions. This patch uses the > > > attribute returning the largest capacity that can be created for > > > determining if the namespace can be created. > > > > > > Signed-off-by: Keith Busch > > > --- > > > ndctl/lib/libndctl.c | 30 ++++++++++++++++++++++++++++++ > > > ndctl/lib/libndctl.sym | 1 + > > > ndctl/libndctl.h | 2 ++ > > > ndctl/namespace.c | 2 +- > > > 4 files changed, 34 insertions(+), 1 deletion(-) > > > > Hi Keith, > > > > The patch looks good, but just a couple of 'meta' comments. > > 1. We typically send ndctl patches separately from kernel patches (i.e. > > not > > thraded together). > > 2. for ndctl patches, an 'ndctl PATCH' prefix is recommended. You can > > set a > > repo local config parameter for doing this automatically on git format- > > patch. > > git config format.subjectprefix "ndctl PATCH" > > > > I'm thinking the kernel changes will be queued for 4.19, which means > > the > > ndctl changes will go into v62. > > Thanks for the info. I'll make those changes for next time. > > I think I may need to send a v2 for this. Should we have this fall back > to > the available_size for the older kernels where the max_available_extents > attribute is not provided? I actually had that in my repo and used a > slightly older patch here, but I'm not sure if its okay to strongly > couple an ndctl release to a kernel version. I was thinking that too. Typically we don't guarantee ndctl to work with old kernels, but this does seem like a bit of an invasive change. Dan, thoughts? _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm