From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
"qi.fuli@jp.fujitsu.com" <qi.fuli@jp.fujitsu.com>
Subject: Re: [ndctl PATCH] ndctl, documentation: fix the manpage of inject-smart
Date: Thu, 12 Jul 2018 16:43:46 +0000 [thread overview]
Message-ID: <1531413824.7574.61.camel@intel.com> (raw)
In-Reply-To: <20180712054000.18519-1-qi.fuli@jp.fujitsu.com>
On Thu, 2018-07-12 at 14:40 +0900, QI Fuli wrote:
> The ndctl inject-smart doesn't have a [-H | --health] option.
> This patch replaces [-H | --health] in the manpage of inject-smart
> with [-f | --fatal].
>
> Signed-off-by: QI Fuli <qi.fuli@jp.fujitsu.com>
> ---
> Documentation/ndctl/ndctl-inject-smart.txt | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/ndctl/ndctl-inject-smart.txt
> b/Documentation/ndctl/ndctl-inject-smart.txt
> index 0dc6481..06710ec 100644
> --- a/Documentation/ndctl/ndctl-inject-smart.txt
> +++ b/Documentation/ndctl/ndctl-inject-smart.txt
> @@ -50,6 +50,7 @@ OPTIONS
> --media-temperature-threshold=::
> Set <value> for the smart media temperature threshold.
>
> +-x::
> --media-temperature-alarm=::
> Enable or disable the smart media temperature alarm. Options
> are
> 'on' or 'off'.
> @@ -62,6 +63,7 @@ OPTIONS
> --ctrl-temperature-threshold=::
> Set <value> for the smart controller temperature threshold.
>
> +-y::
> --ctrl-temperature-alarm=::
> Enable or disable the smart controller temperature alarm.
> Options are
> 'on' or 'off'.
> @@ -74,16 +76,16 @@ OPTIONS
> --spares-threshold=::
> Set <value> for the smart spares threshold.
>
> +-z::
> --spares-alarm=::
> Enable or disable the smart spares alarm. Options are 'on'
> or 'off'.
Hi Qi,
For the x, y, and z short options, I left them undocumented since they
don't exactly match the actual field being set.
>
> --H::
> ---health=::
> - Smart attribute for health status. Provide either 'fatal' or
> 'nominal'
> - to set the state of the attribute.
This was a leftover from a previous iteration, and does need to be
fixed. However, I am reworking this man page along with the smart
injection utility to also provide a way to 'uninject' or disable
injected values, and go back to reporting actual current status. I have
this fix in that series.
> +-f::
> +--fatal::
> + Inject fatal for the health state attribute.
>
> -U::
> ---unsafe-shutdown=::
> +--unsafe-shutdown::
> Set the flag to spoof an unsafe shutdown on the next power
> down.
>
> -v::
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
prev parent reply other threads:[~2018-07-12 16:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 5:40 [ndctl PATCH] ndctl, documentation: fix the manpage of inject-smart QI Fuli
2018-07-12 16:43 ` Verma, Vishal L [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1531413824.7574.61.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=linux-nvdimm@lists.01.org \
--cc=qi.fuli@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).