From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Jiang, Dave" <dave.jiang@intel.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH] acpi/nfit: queue issuing of ars when an uc error notification comes in
Date: Fri, 27 Jul 2018 18:41:56 +0000 [thread overview]
Message-ID: <1532716914.8557.39.camel@intel.com> (raw)
In-Reply-To: <153270745762.70694.3487924980141893382.stgit@djiang5-desk3.ch.intel.com>
On Fri, 2018-07-27 at 09:04 -0700, Dave Jiang wrote:
> When the ACPI UC error notifier gets called and ARS_REQ bit is set
> with the passed in flag, we can receive -EBUSY if ARS_REQ bit is already
> set for the nfit_spa->ars_state. When that happens, the ARS request is
> dropped. That can potentially cause us to miss the unreported errors that
> the on going ARS request does not receive. Add an ARS_REQ_REDO state that
> will request short ARS upon ARS completion to grab any errors we missed.
>
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/acpi/nfit/core.c | 12 +++++++++---
> drivers/acpi/nfit/nfit.h | 1 +
> 2 files changed, 10 insertions(+), 3 deletions(-)
Looks good to me, you can add:
Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
>
> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> index 274f636cd3d2..def64259f9a7 100644
> --- a/drivers/acpi/nfit/core.c
> +++ b/drivers/acpi/nfit/core.c
> @@ -2567,7 +2567,12 @@ static void ars_complete(struct acpi_nfit_desc *acpi_desc,
> test_bit(ARS_SHORT, &nfit_spa->ars_state)
> ? "short" : "long");
> clear_bit(ARS_SHORT, &nfit_spa->ars_state);
> - set_bit(ARS_DONE, &nfit_spa->ars_state);
> + if (test_and_clear_bit(ARS_REQ_REDO, &nfit_spa->ars_state)) {
> + set_bit(ARS_SHORT, &nfit_spa->ars_state);
> + set_bit(ARS_REQ, &nfit_spa->ars_state);
> + dev_dbg(dev, "ARS: processing scrub request received while in progress\n");
> + } else
> + set_bit(ARS_DONE, &nfit_spa->ars_state);
> }
>
> static int ars_status_process_records(struct acpi_nfit_desc *acpi_desc)
> @@ -3264,9 +3269,10 @@ int acpi_nfit_ars_rescan(struct acpi_nfit_desc *acpi_desc, unsigned long flags)
> if (test_bit(ARS_FAILED, &nfit_spa->ars_state))
> continue;
>
> - if (test_and_set_bit(ARS_REQ, &nfit_spa->ars_state))
> + if (test_and_set_bit(ARS_REQ, &nfit_spa->ars_state)) {
> busy++;
> - else {
> + set_bit(ARS_REQ_REDO, &nfit_spa->ars_state);
> + } else {
> if (test_bit(ARS_SHORT, &flags))
> set_bit(ARS_SHORT, &nfit_spa->ars_state);
> scheduled++;
> diff --git a/drivers/acpi/nfit/nfit.h b/drivers/acpi/nfit/nfit.h
> index a97ff42fe311..d1274ea2d251 100644
> --- a/drivers/acpi/nfit/nfit.h
> +++ b/drivers/acpi/nfit/nfit.h
> @@ -119,6 +119,7 @@ enum nfit_dimm_notifiers {
>
> enum nfit_ars_state {
> ARS_REQ,
> + ARS_REQ_REDO,
> ARS_DONE,
> ARS_SHORT,
> ARS_FAILED,
>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
prev parent reply other threads:[~2018-07-27 18:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 16:04 [PATCH] acpi/nfit: queue issuing of ars when an uc error notification comes in Dave Jiang
2018-07-27 18:41 ` Verma, Vishal L [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1532716914.8557.39.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=dave.jiang@intel.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox