From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 401552118A593 for ; Tue, 6 Nov 2018 16:24:15 -0800 (PST) Received: by mail-pf1-f195.google.com with SMTP id y18-v6so4502372pfn.1 for ; Tue, 06 Nov 2018 16:24:15 -0800 (PST) Message-ID: <1541550252.196084.200.camel@acm.org> Subject: Re: [driver-core PATCH v5 7/9] driver core: Attach devices on CPU local to device node From: Bart Van Assche Date: Tue, 06 Nov 2018 16:24:12 -0800 In-Reply-To: <154145233508.29224.9891071445860629874.stgit@ahduyck-desk1.jf.intel.com> References: <154145223352.29224.8912797012647157172.stgit@ahduyck-desk1.jf.intel.com> <154145233508.29224.9891071445860629874.stgit@ahduyck-desk1.jf.intel.com> Mime-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Alexander Duyck , linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org Cc: len.brown@intel.com, linux-pm@vger.kernel.org, rafael@kernel.org, jiangshanlai@gmail.com, linux-nvdimm@lists.01.org, pavel@ucw.cz, zwisler@kernel.org, tj@kernel.org, akpm@linux-foundation.org List-ID: On Mon, 2018-11-05 at 13:12 -0800, Alexander Duyck wrote: > This change makes it so that we call the asynchronous probe routines on a > CPU local to the device node. By doing this we should be able to improve > our initialization time significantly as we can avoid having to access the > device from a remote node which may introduce higher latency. > > For example, in the case of initializing memory for NVDIMM this can have a > significant impact as initialing 3TB on remote node can take up to 39 > seconds while initialing it on a local node only takes 23 seconds. It is > situations like this where we will see the biggest improvement. > > Signed-off-by: Alexander Duyck > --- > drivers/base/dd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/base/dd.c b/drivers/base/dd.c > index 2fdfe45bb6ea..cf7681309ee3 100644 > --- a/drivers/base/dd.c > +++ b/drivers/base/dd.c > @@ -834,7 +834,7 @@ static int __device_attach(struct device *dev, bool allow_async) > dev_dbg(dev, "scheduling asynchronous probe\n"); > get_device(dev); > dev->async_probe = true; > - async_schedule(__device_attach_async_helper, dev); > + async_schedule_dev(__device_attach_async_helper, dev); > } else { > pm_request_idle(dev); > } > @@ -992,7 +992,7 @@ static int __driver_attach(struct device *dev, void *data) > if (!dev->driver) { > get_device(dev); > dev_set_drv_async(dev, drv); > - async_schedule(__driver_attach_async_helper, dev); > + async_schedule_dev(__driver_attach_async_helper, dev); > } > device_unlock(dev); > return 0; Reviewed-by: Bart Van Assche _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm