From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AEBBD211546FA for ; Fri, 21 Sep 2018 12:29:05 -0700 (PDT) Subject: Re: [PATCH V5 4/4] kvm: add a check if pfn is from NVDIMM pmem. References: <4e8c2e0facd46cfaf4ab79e19c9115958ab6f218.1536342881.git.yi.z.zhang@linux.intel.com> <20180920224953.GA53363@tiger-server> <20180921224739.GA33892@tiger-server> From: David Hildenbrand Message-ID: <159bb198-a4a1-0fee-bf57-24c3c28788bd@redhat.com> Date: Fri, 21 Sep 2018 21:29:00 +0200 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Dan Williams Cc: KVM list , "Zhang, Yu C" , linux-nvdimm , Jan Kara , rkrcmar@redhat.com, Linux Kernel Mailing List , Linux MM , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Paolo Bonzini , Christoph Hellwig Zhang, List-ID: On 21/09/2018 20:17, Dan Williams wrote: > On Fri, Sep 21, 2018 at 7:24 AM David Hildenbrand wrote: > [..] >>> Remove the PageReserved flag sounds more reasonable. >>> And Could we still have a flag to identify it is a device private memory, or >>> where these pages coming from? >> >> We could use a page type for that or what you proposed. (as I said, we >> might have to change hibernation code to skip the pages once we drop the >> reserved flag). > > I think it would be reasonable to reject all ZONE_DEVICE pages in > saveable_page(). > Indeed, that sounds like the easiest solution - guess that answer was too easy for me to figure out :) . -- Thanks, David / dhildenb _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm