From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EF0A2212108FE for ; Tue, 21 May 2019 09:24:40 -0700 (PDT) Date: Tue, 21 May 2019 12:24:14 -0400 (EDT) From: Pankaj Gupta Message-ID: <176786650.30122184.1558455854322.JavaMail.zimbra@redhat.com> In-Reply-To: <20190521094543-mutt-send-email-mst@kernel.org> References: <20190521133713.31653-1-pagupta@redhat.com> <20190521133713.31653-3-pagupta@redhat.com> <20190521094543-mutt-send-email-mst@kernel.org> Subject: Re: [Qemu-devel] [PATCH v10 2/7] virtio-pmem: Add virtio pmem driver MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "Michael S. Tsirkin" Cc: rdunlap@infradead.org, jack@suse.cz, kvm@vger.kernel.org, david@redhat.com, jasowang@redhat.com, david@fromorbit.com, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, dm-devel@redhat.com, adilger kernel , zwisler@kernel.org, aarcange@redhat.com, jstaron@google.com, linux-nvdimm@lists.01.org, willy@infradead.org, hch@infradead.org, linux-acpi@vger.kernel.org, linux-ext4@vger.kernel.org, lenb@kernel.org, kilobyte@angband.pl, riel@surriel.com, yuval shaia , stefanha@redhat.com, imammedo@redhat.com, lcapitulino@redhat.com, kwolf@redhat.com, nilal@redhat.com, tytso@mit.edu, xiaoguangrong eric , snitzer@redhat.com, cohuck@redhat.com, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, pbonzini@redhat.com, darrick wong List-ID: > > diff --git a/include/uapi/linux/virtio_pmem.h > > b/include/uapi/linux/virtio_pmem.h > > new file mode 100644 > > index 000000000000..7a3e2fe52415 > > --- /dev/null > > +++ b/include/uapi/linux/virtio_pmem.h > > @@ -0,0 +1,35 @@ > > +/* SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause */ > > +/* > > + * Definitions for virtio-pmem devices. > > + * > > + * Copyright (C) 2019 Red Hat, Inc. > > + * > > + * Author(s): Pankaj Gupta > > + */ > > + > > +#ifndef _UAPI_LINUX_VIRTIO_PMEM_H > > +#define _UAPI_LINUX_VIRTIO_PMEM_H > > + > > +#include > > +#include > > +#include > > +#include > > + > > +struct virtio_pmem_config { > > + __le64 start; > > + __le64 size; > > +}; > > + > > config generally should be __u64. > Are you sure sparse does not complain? I used this because VIRTIO 1.1 spec says: "The device configuration space uses the little-endian format for multi-byte fields. " and __le64 looks ok to me. Also, its used in other driver config as welle.g virtio-vsock > > > > +#define VIRTIO_PMEM_REQ_TYPE_FLUSH 0 > > + > > +struct virtio_pmem_resp { > > + /* Host return status corresponding to flush request */ > > + __virtio32 ret; > > +}; > > + > > +struct virtio_pmem_req { > > + /* command type */ > > + __virtio32 type; > > +}; > > + > > +#endif > > -- > > 2.20.1 > > Sorry why are these __virtio32 not __le32? I used __virtio32 for data fields for guest and host supporting different endianess. Thanks, Pankaj > > -- > MST > > _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm