From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C5A5F21250C96 for ; Wed, 15 May 2019 23:28:23 -0700 (PDT) Date: Thu, 16 May 2019 02:28:20 -0400 (EDT) From: Pankaj Gupta Message-ID: <1906905099.29162562.1557988100975.JavaMail.zimbra@redhat.com> In-Reply-To: References: <20190514145422.16923-1-pagupta@redhat.com> <20190514145422.16923-2-pagupta@redhat.com> Subject: Re: [PATCH v9 1/7] libnvdimm: nd_region flush callback support MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Dan Williams Cc: cohuck@redhat.com, Jan Kara , KVM list , "Michael S. Tsirkin" , Jason Wang , david , Qemu Developers , virtualization@lists.linux-foundation.org, Andreas Dilger , Ross Zwisler , Andrea Arcangeli , jstaron@google.com, linux-nvdimm , David Hildenbrand , Matthew Wilcox , Christoph Hellwig , Linux ACPI , linux-ext4 , Len Brown , Adam Borowski , Rik van Riel , yuval shaia , Stefan Hajnoczi , Paolo Bonzini , lcapitulino@redhat.com, Kevin Wolf , Nitesh Narayan Lal , Theodore Ts'o , Xiao Guangrong , "Darrick J. Wong" , "Rafael J. Wysocki" , Linux Kernel Mailing List , linux-xfs , linux-fsdevel , Igor Mammedov List-ID: Cj4gPgo+ID4gVGhpcyBwYXRjaCBhZGRzIGZ1bmN0aW9uYWxpdHkgdG8gcGVyZm9ybSBmbHVzaCBm cm9tIGd1ZXN0Cj4gPiB0byBob3N0IG92ZXIgVklSVElPLiBXZSBhcmUgcmVnaXN0ZXJpbmcgYSBj YWxsYmFjayBiYXNlZAo+ID4gb24gJ25kX3JlZ2lvbicgdHlwZS4gdmlydGlvX3BtZW0gZHJpdmVy IHJlcXVpcmVzIHRoaXMgc3BlY2lhbAo+ID4gZmx1c2ggZnVuY3Rpb24uIEZvciByZXN0IG9mIHRo ZSByZWdpb24gdHlwZXMgd2UgYXJlIHJlZ2lzdGVyaW5nCj4gPiBleGlzdGluZyBmbHVzaCBmdW5j dGlvbi4gUmVwb3J0IGVycm9yIHJldHVybmVkIGJ5IGhvc3QgZnN5bmMKPiA+IGZhaWx1cmUgdG8g dXNlcnNwYWNlLgo+ID4KPiA+IFNpZ25lZC1vZmYtYnk6IFBhbmthaiBHdXB0YSA8cGFndXB0YUBy ZWRoYXQuY29tPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9hY3BpL25maXQvY29yZS5jICAgICB8ICA0 ICsrLS0KPiA+ICBkcml2ZXJzL252ZGltbS9jbGFpbS5jICAgICAgIHwgIDYgKysrKy0tCj4gPiAg ZHJpdmVycy9udmRpbW0vbmQuaCAgICAgICAgICB8ICAxICsKPiA+ICBkcml2ZXJzL252ZGltbS9w bWVtLmMgICAgICAgIHwgMTMgKysrKysrKystLS0tLQo+ID4gIGRyaXZlcnMvbnZkaW1tL3JlZ2lv bl9kZXZzLmMgfCAyNiArKysrKysrKysrKysrKysrKysrKysrKystLQo+ID4gIGluY2x1ZGUvbGlu dXgvbGlibnZkaW1tLmggICAgfCAgOCArKysrKysrLQo+ID4gIDYgZmlsZXMgY2hhbmdlZCwgNDYg aW5zZXJ0aW9ucygrKSwgMTIgZGVsZXRpb25zKC0pCj4gPgo+ID4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvYWNwaS9uZml0L2NvcmUuYyBiL2RyaXZlcnMvYWNwaS9uZml0L2NvcmUuYwo+ID4gaW5kZXgg NWEzODlhNGY0ZjY1Li4wOGRkZTc2Y2Y0NTkgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2FjcGkv bmZpdC9jb3JlLmMKPiA+ICsrKyBiL2RyaXZlcnMvYWNwaS9uZml0L2NvcmUuYwo+ID4gQEAgLTI0 MzQsNyArMjQzNCw3IEBAIHN0YXRpYyB2b2lkIHdyaXRlX2Jsa19jdGwoc3RydWN0IG5maXRfYmxr ICpuZml0X2JsaywKPiA+IHVuc2lnbmVkIGludCBidywKPiA+ICAgICAgICAgICAgICAgICBvZmZz ZXQgPSB0b19pbnRlcmxlYXZlX29mZnNldChvZmZzZXQsIG1taW8pOwo+ID4KPiA+ICAgICAgICAg d3JpdGVxKGNtZCwgbW1pby0+YWRkci5iYXNlICsgb2Zmc2V0KTsKPiA+IC0gICAgICAgbnZkaW1t X2ZsdXNoKG5maXRfYmxrLT5uZF9yZWdpb24pOwo+ID4gKyAgICAgICBudmRpbW1fZmx1c2gobmZp dF9ibGstPm5kX3JlZ2lvbiwgTlVMTCk7Cj4gPgo+ID4gICAgICAgICBpZiAobmZpdF9ibGstPmRp bW1fZmxhZ3MgJiBORklUX0JMS19EQ1JfTEFUQ0gpCj4gPiAgICAgICAgICAgICAgICAgcmVhZHEo bW1pby0+YWRkci5iYXNlICsgb2Zmc2V0KTsKPiA+IEBAIC0yNDgzLDcgKzI0ODMsNyBAQCBzdGF0 aWMgaW50IGFjcGlfbmZpdF9ibGtfc2luZ2xlX2lvKHN0cnVjdCBuZml0X2Jsawo+ID4gKm5maXRf YmxrLAo+ID4gICAgICAgICB9Cj4gPgo+ID4gICAgICAgICBpZiAocncpCj4gPiAtICAgICAgICAg ICAgICAgbnZkaW1tX2ZsdXNoKG5maXRfYmxrLT5uZF9yZWdpb24pOwo+ID4gKyAgICAgICAgICAg ICAgIG52ZGltbV9mbHVzaChuZml0X2Jsay0+bmRfcmVnaW9uLCBOVUxMKTsKPiA+Cj4gPiAgICAg ICAgIHJjID0gcmVhZF9ibGtfc3RhdChuZml0X2JsaywgbGFuZSkgPyAtRUlPIDogMDsKPiA+ICAg ICAgICAgcmV0dXJuIHJjOwo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbnZkaW1tL2NsYWltLmMg Yi9kcml2ZXJzL252ZGltbS9jbGFpbS5jCj4gPiBpbmRleCBmYjY2N2JmNDY5YzcuLjEzNTEwYmFl MWU2ZiAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvbnZkaW1tL2NsYWltLmMKPiA+ICsrKyBiL2Ry aXZlcnMvbnZkaW1tL2NsYWltLmMKPiA+IEBAIC0yNjMsNyArMjYzLDcgQEAgc3RhdGljIGludCBu c2lvX3J3X2J5dGVzKHN0cnVjdCBuZF9uYW1lc3BhY2VfY29tbW9uCj4gPiAqbmRucywKPiA+ICAg ICAgICAgc3RydWN0IG5kX25hbWVzcGFjZV9pbyAqbnNpbyA9IHRvX25kX25hbWVzcGFjZV9pbygm bmRucy0+ZGV2KTsKPiA+ICAgICAgICAgdW5zaWduZWQgaW50IHN6X2FsaWduID0gQUxJR04oc2l6 ZSArIChvZmZzZXQgJiAoNTEyIC0gMSkpLCA1MTIpOwo+ID4gICAgICAgICBzZWN0b3JfdCBzZWN0 b3IgPSBvZmZzZXQgPj4gOTsKPiA+IC0gICAgICAgaW50IHJjID0gMDsKPiA+ICsgICAgICAgaW50 IHJjID0gMCwgcmV0ID0gMDsKPiA+Cj4gPiAgICAgICAgIGlmICh1bmxpa2VseSghc2l6ZSkpCj4g PiAgICAgICAgICAgICAgICAgcmV0dXJuIDA7Cj4gPiBAQCAtMzAxLDcgKzMwMSw5IEBAIHN0YXRp YyBpbnQgbnNpb19yd19ieXRlcyhzdHJ1Y3QgbmRfbmFtZXNwYWNlX2NvbW1vbgo+ID4gKm5kbnMs Cj4gPiAgICAgICAgIH0KPiA+Cj4gPiAgICAgICAgIG1lbWNweV9mbHVzaGNhY2hlKG5zaW8tPmFk ZHIgKyBvZmZzZXQsIGJ1Ziwgc2l6ZSk7Cj4gPiAtICAgICAgIG52ZGltbV9mbHVzaCh0b19uZF9y ZWdpb24obmRucy0+ZGV2LnBhcmVudCkpOwo+ID4gKyAgICAgICByZXQgPSBudmRpbW1fZmx1c2go dG9fbmRfcmVnaW9uKG5kbnMtPmRldi5wYXJlbnQpLCBOVUxMKTsKPiA+ICsgICAgICAgaWYgKHJl dCkKPiA+ICsgICAgICAgICAgICAgICByYyA9IHJldDsKPiA+Cj4gPiAgICAgICAgIHJldHVybiBy YzsKPiA+ICB9Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9udmRpbW0vbmQuaCBiL2RyaXZlcnMv bnZkaW1tL25kLmgKPiA+IGluZGV4IGE1YWMzYjI0MDI5My4uMGM3NGQyNDI4YmQ3IDEwMDY0NAo+ ID4gLS0tIGEvZHJpdmVycy9udmRpbW0vbmQuaAo+ID4gKysrIGIvZHJpdmVycy9udmRpbW0vbmQu aAo+ID4gQEAgLTE1OSw2ICsxNTksNyBAQCBzdHJ1Y3QgbmRfcmVnaW9uIHsKPiA+ICAgICAgICAg c3RydWN0IGJhZGJsb2NrcyBiYjsKPiA+ICAgICAgICAgc3RydWN0IG5kX2ludGVybGVhdmVfc2V0 ICpuZF9zZXQ7Cj4gPiAgICAgICAgIHN0cnVjdCBuZF9wZXJjcHVfbGFuZSBfX3BlcmNwdSAqbGFu ZTsKPiA+ICsgICAgICAgaW50ICgqZmx1c2gpKHN0cnVjdCBuZF9yZWdpb24gKm5kX3JlZ2lvbiwg c3RydWN0IGJpbyAqYmlvKTsKPiAKPiBTbyB0aGlzIHRyaWdnZXJzOgo+IAo+IEluIGZpbGUgaW5j bHVkZWQgZnJvbSBkcml2ZXJzL252ZGltbS9lODIwLmM6NzoKPiAuL2luY2x1ZGUvbGludXgvbGli bnZkaW1tLmg6MTQwOjUxOiB3YXJuaW5nOiDigJhzdHJ1Y3QgYmlv4oCZIGRlY2xhcmVkCj4gaW5z aWRlIHBhcmFtZXRlciBsaXN0IHdpbGwgbm90IGJlIHZpc2libGUgb3V0c2lkZSBvZiB0aGlzIGRl ZmluaXRpb24KPiBvciBkZWNsYXJhdGlvbgo+ICAgaW50ICgqZmx1c2gpKHN0cnVjdCBuZF9yZWdp b24gKm5kX3JlZ2lvbiwgc3RydWN0IGJpbyAqYmlvKTsKPiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBefn4KClNvcnJ5ISBmb3IgdGhpcy4gRml4ZWQg bm93LgoKPiBJIHdhcyBhbHJlYWR5IGZlZWxpbmcgdW5lYXN5IGFib3V0IHRyeWluZyB0byBzcXVl ZXplIHRoaXMgaW50byB2NS4yLAo+IGJ1dCB0aGlzIHdhcm5pbmcgYW5kIHRoZSBjb250aW51ZWQg ZHJpcCBvZiBjb21tZW50cyBsZWFkcyBtZSB0bwo+IGNvbmNsdWRlIHRoYXQgdGhpcyBkcml2ZXIg d291bGQgZG8gd2VsbCB0byB3YWl0IG9uZSBtb3JlIGRldmVsb3BtZW50Cj4gY3ljbGUuIExldHMg Y2xvc2Ugb3V0IHRoZSBmaW5hbCBmaXh1cHMgYW5kIGxldCB0aGlzIGRyaXZlciBzb2FrIGluCj4g LW5leHQuIFRoZW4gZm9yIHRoZSB2NS4zIGN5Y2xlIEknbGwgcmVkb3VibGUgbXkgZWZmb3J0cyB0 b3dhcmRzIHRoZQo+IGdvYWwgb2YgY2xvc2luZyBwYXRjaCBhY2NlcHRhbmNlIGF0IHRoZSAtcmM2 IC8gLXJjNyBkZXZlbG9wbWVudAo+IG1pbGVzdG9uZS4KCm8uay4gV2lsbCB3YWl0IGZvciBNaWtl J3MgQUNLIG9uIGRldmljZSBtYXBwZXIgcGF0Y2ggYW5kIHNlbmQgdGhlIHYxMAp3aXRoIGZpbmFs IGZpeC11cHMuIFRoYW5rIHlvdSBmb3IgeW91ciBoZWxwLgoKQmVzdCByZWdhcmRzLApQYW5rYWoK CgoKPiAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGlu dXgtbnZkaW1tIG1haWxpbmcgbGlzdApMaW51eC1udmRpbW1AbGlzdHMuMDEub3JnCmh0dHBzOi8v bGlzdHMuMDEub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbnZkaW1tCg==