Linux-NVDIMM Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Toshi Kani <toshi.kani@hpe.com>
Cc: Jan Kara <jack@suse.cz>,
	linux-nvdimm@lists.01.org, NeilBrown <neilb@suse.com>,
	brian.boylston@hpe.com, Wilcox,
Subject: Re: [RFC v2] [PATCH 0/10] DAX page fault locking
Date: Wed, 23 Mar 2016 08:15:15 +1100	[thread overview]
Message-ID: <20160322211515.GP11812@dastard> (raw)
In-Reply-To: <1458680853.6393.592.camel@hpe.com>

On Tue, Mar 22, 2016 at 03:07:33PM -0600, Toshi Kani wrote:
> On Tue, 2016-03-22 at 13:32 -0600, Ross Zwisler wrote:
> > On Mon, Mar 21, 2016 at 02:22:45PM +0100, Jan Kara wrote:
> > > [Sorry for repost but I accidentally sent initial email without
> > > patches]
> > > 
> > > Hello,
> > > 
> > > this is my second attempt at DAX page fault locking rewrite. Things now
> > > work reasonably well, it has survived full xfstests run on ext4. I
> > > guess I need to do more mmap targetted tests to unveil issues. Guys
> > > what do you used for DAX testing?
> > 
> > I typically use xfstests for regression testing.  If we can come up with
> > new generally useful regression tests, especially ones concerning mmap
> > races, that would be awesome.  I guess it's just a choice between adding
> > them somewhere in xfstests or somewhere else like with the unit tests in
> > ndctl.
> 
> Brian Boylston wrote a test for mmap race conditions and posted it before.
>  This test was very useful to fix the data corruption issue we had before.
> http://www.spinics.net/lists/linux-ext4/msg49876.html
> 
> If there is anything we can do to make this test useful as regression
> tests?

It's gplv2, so wrap it in a xfstests harness script and send it to
fstests@vger.kernel.org.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

  reply	other threads:[~2016-03-22 21:15 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-21 13:22 [RFC v2] [PATCH 0/10] DAX page fault locking Jan Kara
2016-03-21 13:22 ` [PATCH 01/10] DAX: move RADIX_DAX_ definitions to dax.c Jan Kara
2016-03-21 17:25   ` Matthew Wilcox
2016-03-21 13:22 ` [PATCH 02/10] radix-tree: make 'indirect' bit available to exception entries Jan Kara
2016-03-21 17:34   ` Matthew Wilcox
2016-03-22  9:12     ` Jan Kara
2016-03-22  9:27       ` Matthew Wilcox
2016-03-22 10:37         ` Jan Kara
2016-03-23 16:41           ` Ross Zwisler
2016-03-24 12:31             ` Jan Kara
2016-03-21 13:22 ` [PATCH 03/10] dax: Remove complete_unwritten argument Jan Kara
2016-03-23 17:12   ` Ross Zwisler
2016-03-24 12:32     ` Jan Kara
2016-03-21 13:22 ` [PATCH 04/10] dax: Fix data corruption for written and mmapped files Jan Kara
2016-03-23 17:39   ` Ross Zwisler
2016-03-24 12:51     ` Jan Kara
2016-03-29 15:17       ` Ross Zwisler
2016-03-21 13:22 ` [PATCH 05/10] dax: Allow DAX code to replace exceptional entries Jan Kara
2016-03-23 17:52   ` Ross Zwisler
2016-03-24 10:42     ` Jan Kara
2016-03-21 13:22 ` [PATCH 06/10] dax: Remove redundant inode size checks Jan Kara
2016-03-23 21:08   ` Ross Zwisler
2016-03-21 13:22 ` [PATCH 07/10] dax: Disable huge page handling Jan Kara
2016-03-23 20:50   ` Ross Zwisler
2016-03-24 12:56     ` Jan Kara
2016-03-21 13:22 ` [PATCH 08/10] dax: New fault locking Jan Kara
2016-03-29 21:57   ` Ross Zwisler
2016-03-31 16:27     ` Jan Kara
2016-03-21 13:22 ` [PATCH 09/10] dax: Use radix tree entry lock to protect cow faults Jan Kara
2016-03-21 19:11   ` Matthew Wilcox
2016-03-22  7:03     ` Jan Kara
2016-03-29 22:18   ` Ross Zwisler
2016-03-21 13:22 ` [PATCH 10/10] dax: Remove i_mmap_lock protection Jan Kara
2016-03-29 22:17   ` Ross Zwisler
2016-03-21 17:41 ` [RFC v2] [PATCH 0/10] DAX page fault locking Matthew Wilcox
2016-03-23 15:09   ` Jan Kara
2016-03-23 20:50     ` Matthew Wilcox
2016-03-24 10:00     ` Matthew Wilcox
2016-03-22 19:32 ` Ross Zwisler
2016-03-22 21:07   ` Toshi Kani
2016-03-22 21:15     ` Dave Chinner [this message]
2016-03-23  9:45     ` Jan Kara
2016-03-23 15:11       ` Toshi Kani
  -- strict thread matches above, loose matches on Subject: below --
2016-03-21 13:21 Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160322211515.GP11812@dastard \
    --to=david@fromorbit.com \
    --cc=brian.boylston@hpe.com \
    --cc=jack@suse.cz \
    --cc=linux-nvdimm@lists.01.org \
    --cc=neilb@suse.com \
    --cc=toshi.kani@hpe.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox