From: Ross Zwisler <ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Cc: linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-nvdimm-y27Ovi1pjclAfugRpC6u6w@public.gmane.org
Subject: Re: [PATCH 09/10] xfs: refactor xfs_setfilesize
Date: Tue, 13 Sep 2016 17:12:10 -0600 [thread overview]
Message-ID: <20160913231210.GG26002@linux.intel.com> (raw)
In-Reply-To: <1473438884-674-10-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
On Fri, Sep 09, 2016 at 06:34:43PM +0200, Christoph Hellwig wrote:
> Rename the current function to __xfs_setfilesize and add a non-static
> wrapper that also takes care of creating the transaction. This new
> helper will be used by the new iomap-based DAX path.
>
> Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
> ---
> fs/xfs/xfs_aops.c | 33 ++++++++++++++++++++++-----------
> fs/xfs/xfs_aops.h | 1 +
> 2 files changed, 23 insertions(+), 11 deletions(-)
>
> diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
> index 7575cfc..0bd3e27 100644
> --- a/fs/xfs/xfs_aops.c
> +++ b/fs/xfs/xfs_aops.c
> @@ -199,8 +199,8 @@ xfs_setfilesize_trans_alloc(
> /*
> * Update on-disk file size now that data has been written to disk.
> */
> -STATIC int
This can remain STATIC, as it is only used in this file.
> -xfs_setfilesize(
> +int
> +__xfs_setfilesize(
> struct xfs_inode *ip,
> struct xfs_trans *tp,
> xfs_off_t offset,
next prev parent reply other threads:[~2016-09-13 23:12 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 16:34 iomap based DAX path Christoph Hellwig
[not found] ` <1473438884-674-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-09-09 16:34 ` [PATCH 01/10] iomap: add IOMAP_F_NEW flag Christoph Hellwig
[not found] ` <1473438884-674-2-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-09-13 22:43 ` Ross Zwisler
2016-09-14 7:08 ` Christoph Hellwig
2016-09-09 16:34 ` [PATCH 02/10] iomap: expose iomap_apply outside iomap.c Christoph Hellwig
[not found] ` <1473438884-674-3-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-09-13 22:48 ` Ross Zwisler
2016-09-09 16:34 ` [PATCH 03/10] dax: don't pass buffer_head to dax_insert_mapping Christoph Hellwig
[not found] ` <1473438884-674-4-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-09-13 22:53 ` Ross Zwisler
2016-09-09 16:34 ` [PATCH 04/10] dax: don't pass buffer_head to copy_user_dax Christoph Hellwig
2016-09-13 22:54 ` Ross Zwisler
2016-09-09 16:34 ` [PATCH 05/10] dax: provide an iomap based dax read/write path Christoph Hellwig
[not found] ` <1473438884-674-6-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-09-13 23:00 ` Ross Zwisler
2016-09-09 16:34 ` [PATCH 06/10] dax: provide an iomap based fault handler Christoph Hellwig
[not found] ` <1473438884-674-7-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-09-09 22:55 ` Dave Chinner
2016-09-10 7:36 ` Christoph Hellwig
2016-09-13 15:51 ` Ross Zwisler
[not found] ` <20160913155126.GA10622-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-09-14 7:06 ` Christoph Hellwig
[not found] ` <20160914070633.GA17278-jcswGhMUV9g@public.gmane.org>
2016-09-14 9:53 ` Christoph Hellwig
2016-09-23 21:02 ` Ross Zwisler
[not found] ` <20160923210237.GA23346-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-09-26 0:08 ` Christoph Hellwig
[not found] ` <20160926000805.GA32252-jcswGhMUV9g@public.gmane.org>
2016-09-26 14:28 ` Jan Kara
2016-09-10 1:38 ` Elliott, Robert (Persistent Memory)
2016-09-13 23:10 ` Ross Zwisler
[not found] ` <20160913231039.GF26002-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-09-14 7:19 ` Christoph Hellwig
[not found] ` <20160914071910.GC17278-jcswGhMUV9g@public.gmane.org>
2016-09-14 17:07 ` Ross Zwisler
[not found] ` <20160914170759.GA14196-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-09-15 5:12 ` Christoph Hellwig
[not found] ` <20160915051229.GD6188-jcswGhMUV9g@public.gmane.org>
2016-09-15 5:30 ` Darrick J. Wong
2016-09-26 0:05 ` Christoph Hellwig
2016-09-09 16:34 ` [PATCH 07/10] xfs: fix locking for DAX writes Christoph Hellwig
2016-09-09 16:34 ` [PATCH 08/10] xfs: take the ilock shared if possible in xfs_file_iomap_begin Christoph Hellwig
2016-09-09 16:34 ` [PATCH 09/10] xfs: refactor xfs_setfilesize Christoph Hellwig
[not found] ` <1473438884-674-10-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-09-13 23:12 ` Ross Zwisler [this message]
2016-09-09 16:34 ` [PATCH 10/10] xfs: use iomap to implement DAX Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160913231210.GG26002@linux.intel.com \
--to=ross.zwisler-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=hch-jcswGhMUV9g@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nvdimm-y27Ovi1pjclAfugRpC6u6w@public.gmane.org \
--cc=linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox