From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 0/20 v3] dax: Clear dirty bits after flushing caches Date: Mon, 3 Oct 2016 01:03:37 -0700 Message-ID: <20161003080337.GA13688@infradead.org> References: <1474992504-20133-1-git-send-email-jack@suse.cz> <20160930091418.GC24352@infradead.org> <20161003075902.GG6457@quack2.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20161003075902.GG6457@quack2.suse.cz> Sender: owner-linux-mm@kvack.org To: Jan Kara Cc: Christoph Hellwig , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-nvdimm@ml01.01.org, Dan Williams , Ross Zwisler , "Kirill A. Shutemov" List-Id: linux-nvdimm@lists.01.org On Mon, Oct 03, 2016 at 09:59:02AM +0200, Jan Kara wrote: > IMO ->fault and ->pmd_fault can be merged, ->page_mkwrite and ->pfn_mkwrite > can be merged. There were even patches flying around for that. I want to do > that but it's not a priority now as the patch set it already large enough. > > I'm not sure whether merging ->fault and ->page_mkwrite would be really > helpful and it would certainly require some non-trivial changes in the > fault path. For example currently a write fault of a file mapping will > result in first ->fault being called which handles the read part of the > fault and then ->page_mkwrite is called to handle write-enabling of the > PTE. When the handlers would be merged, calling one handler twice would be > really strange. Except for the DAX path, where we apparently need to call out to the mkwrite handler from ->fault. Or at least used to, with some leftovers in XFS and not extN. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org