From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH 08/11] ext4: Convert DAX faults to iomap infrastructure Date: Fri, 4 Nov 2016 01:02:30 +0100 Message-ID: <20161104000230.GH24234@quack2.suse.cz> References: <1478034381-19037-1-git-send-email-jack@suse.cz> <1478034381-19037-9-git-send-email-jack@suse.cz> <20161102143006.GB18387@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20161102143006.GB18387-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: Christoph Hellwig Cc: Jan Kara , linux-nvdimm-y27Ovi1pjclAfugRpC6u6w@public.gmane.org, Dave Chinner , linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ted Tso , linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-nvdimm@lists.01.org On Wed 02-11-16 07:30:06, Christoph Hellwig wrote: > On Tue, Nov 01, 2016 at 10:06:18PM +0100, Jan Kara wrote: > > Convert DAX faults to use iomap infrastructure. We would not have to start > > transaction in ext4_dax_fault() anymore since ext4_iomap_begin takes > > care of that but so far we do that to avoid lock inversion of > > transaction start with DAX entry lock which gets acquired in > > dax_iomap_fault() before calling ->iomap_begin handler. > > So far I've tried to avoid the need to avoid having multiple iomap_ops > for the same fs. Would you be fine with a new IOMAP_FAULT flag for write > faults? Yes, that's another option. If that's better, I'll redo the patch like that. Honza -- Jan Kara SUSE Labs, CR