From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 54D9381EE4 for ; Tue, 15 Nov 2016 14:10:00 -0800 (PST) Received: by mail-wm0-x244.google.com with SMTP id g23so4711499wme.1 for ; Tue, 15 Nov 2016 14:10:05 -0800 (PST) Date: Wed, 16 Nov 2016 01:10:01 +0300 From: "Kirill A. Shutemov" Subject: Re: [PATCH 05/21] mm: Trim __do_fault() arguments Message-ID: <20161115221001.GE23021@node> References: <1478233517-3571-1-git-send-email-jack@suse.cz> <1478233517-3571-6-git-send-email-jack@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1478233517-3571-6-git-send-email-jack@suse.cz> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Jan Kara Cc: linux-nvdimm@lists.01.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Andrew Morton , "Kirill A. Shutemov" List-ID: On Fri, Nov 04, 2016 at 05:25:01AM +0100, Jan Kara wrote: > static int do_cow_fault(struct vm_fault *vmf) > { > struct vm_area_struct *vma = vmf->vma; > - struct page *fault_page, *new_page; > - void *fault_entry; > + struct page *new_page; Why not get rid of new_page too? Otherwise makes sense: Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm