From: Vishal Verma <vishal.l.verma@intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-nvdimm@lists.01.org
Subject: Re: [ndctl PATCH 0/7] introduce 'daxctl list', and 'ndctl list' updates
Date: Mon, 9 Jan 2017 14:56:37 -0700 [thread overview]
Message-ID: <20170109215636.GA5330@omniknight.lm.intel.com> (raw)
In-Reply-To: <148375332631.38836.5735184615585844571.stgit@dwillia2-desk3.amr.corp.intel.com>
On 01/06, Dan Williams wrote:
> * The 'ndctl list' command awkwardly prints out all the corresponding
> device-dax information when a namespace is in 'dax' mode. Conversely if
> someone is only interested in listing device-dax information they need to
> contend with libnvdimm data.
>
> Introduce a separate daxctl utility with its own 'list' command for this
> purpose, and make the listing of device-dax data through 'ndctl list'
> optional (new --device-dax option).
the 'rpmbuild' script was failing as the new daxctl utility wasn't
included in %files in the spec. The following patch fixes that.
8<-----
>From d26a582b4ae9e69a22e52908a5d4bbae0a79717f Mon Sep 17 00:00:00 2001
From: Vishal Verma <vishal.l.verma@intel.com>
Date: Mon, 9 Jan 2017 14:52:34 -0700
Subject: [PATCH] spec: add the new daxctl binary to the spec file
The missing binary was triggering the "installed but unpackaged file
found" check for rpmbuild. Add daxctl to the %files section as we do
want it to be packaged.
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
---
ndctl.spec.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/ndctl.spec.in b/ndctl.spec.in
index 6453edd..4a22597 100644
--- a/ndctl.spec.in
+++ b/ndctl.spec.in
@@ -114,6 +114,7 @@ make check
%defattr(-,root,root)
%license util/COPYING licenses/BSD-MIT licenses/CC0
%{_bindir}/ndctl
+%{_bindir}/daxctl
%{_mandir}/man1/*
%{bashcompdir}/
--
2.9.3
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2017-01-09 21:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-07 1:42 [ndctl PATCH 0/7] introduce 'daxctl list', and 'ndctl list' updates Dan Williams
2017-01-07 1:42 ` [ndctl PATCH 1/7] ndctl, daxctl: refactor main boilerplate for a new 'daxctl' utility Dan Williams
2017-01-07 1:42 ` [ndctl PATCH 2/7] ndctl, daxctl: move json helpers to be available across both utilities Dan Williams
2017-01-07 1:42 ` [ndctl PATCH 3/7] ndctl, list: add option to filter namespace by mode Dan Williams
2017-01-07 1:42 ` [ndctl PATCH 4/7] ndctl, list: add '--device-dax' option Dan Williams
2017-01-07 1:42 ` [ndctl PATCH 5/7] daxctl: add list command Dan Williams
2017-01-07 1:42 ` [ndctl PATCH 6/7] ndctl, {enable,disable}-region: filter by type Dan Williams
2017-01-07 1:42 ` [ndctl PATCH 7/7] ndctl, list: limit mappings when --dimm is specified Dan Williams
2017-01-09 21:56 ` Vishal Verma [this message]
2017-01-09 22:00 ` [ndctl PATCH 0/7] introduce 'daxctl list', and 'ndctl list' updates Dan Williams
2017-01-09 22:05 ` Verma, Vishal L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170109215636.GA5330@omniknight.lm.intel.com \
--to=vishal.l.verma@intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox