From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: tytso@mit.edu, mawilcox@microsoft.com, darrick.wong@oracle.com,
linux-mm@kvack.org, dave.hansen@intel.com, jack@suse.com,
linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org,
hch@lst.de, linux-nvdimm@lists.01.org
Subject: Re: [PATCH] mm, fs: reduce fault, page_mkwrite, and pfn_mkwrite to take only vmf
Date: Mon, 23 Jan 2017 14:36:14 -0700 [thread overview]
Message-ID: <20170123213614.GA27007@linux.intel.com> (raw)
In-Reply-To: <148495502151.58418.7078842737664999534.stgit@djiang5-desk3.ch.intel.com>
On Fri, Jan 20, 2017 at 04:33:08PM -0700, Dave Jiang wrote:
> ->fault(), ->page_mkwrite(), and ->pfn_mkwrite() calls do not need to take
> a vma and vmf parameter when the vma already resides in vmf. Remove the vma
> parameter to simplify things.
>
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> ---
>
> This patch has received a build success notification from the 0day-kbuild
> robot across 124 configs.
>
> ---
<>
> diff --git a/arch/x86/entry/vdso/vma.c b/arch/x86/entry/vdso/vma.c
> index 10820f6..b6661fd 100644
> --- a/arch/x86/entry/vdso/vma.c
> +++ b/arch/x86/entry/vdso/vma.c
> @@ -38,7 +38,7 @@ void __init init_vdso_image(const struct vdso_image *image)
> struct linux_binprm;
>
> static int vdso_fault(const struct vm_special_mapping *sm,
> - struct vm_area_struct *vma, struct vm_fault *vmf)
> + struct vm_area_struct *vma, struct vm_fault *vmf)
Unneeded spacing change.
Other than that, this looks good to me. I agree with Jan's observation that
it creates a lot of thrash, but I personally like the change because it
eliminates the question of what to do when the 'vma' you're passed in doesn't
match 'vmf->vma'. Having one source of truth seems good, and it reduces the
amount of args we are passing around.
Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
prev parent reply other threads:[~2017-01-23 21:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-20 23:33 [PATCH] mm, fs: reduce fault, page_mkwrite, and pfn_mkwrite to take only vmf Dave Jiang
2017-01-21 14:33 ` Jan Kara
2017-01-23 21:36 ` Ross Zwisler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170123213614.GA27007@linux.intel.com \
--to=ross.zwisler@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=darrick.wong@oracle.com \
--cc=dave.hansen@intel.com \
--cc=dave.jiang@intel.com \
--cc=hch@lst.de \
--cc=jack@suse.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=mawilcox@microsoft.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox