From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-x242.google.com (mail-pg0-x242.google.com [IPv6:2607:f8b0:400e:c05::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B91BB82166 for ; Thu, 23 Feb 2017 00:37:07 -0800 (PST) Received: by mail-pg0-x242.google.com with SMTP id 5so3806648pgj.0 for ; Thu, 23 Feb 2017 00:37:07 -0800 (PST) Date: Thu, 23 Feb 2017 00:37:03 -0800 From: Dmitry Torokhov Subject: Re: [PATCH 03/14] input: utilize new device_add_cdev helper function Message-ID: <20170223083703.GF18639@dtor-ws> References: <1487653253-11497-1-git-send-email-logang@deltatee.com> <1487653253-11497-4-git-send-email-logang@deltatee.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1487653253-11497-4-git-send-email-logang@deltatee.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Logan Gunthorpe Cc: Alessandro Zummo , Jan Kara , linux-iio@vger.kernel.org, linux-pci@vger.kernel.org, Linus Walleij , Jarkko Sakkinen , Alexandre Bounine , Alexandre Belloni , Peter Meerwald-Stadler , linux-scsi@vger.kernel.org, Sean Hefty , Parav Pandit , Peter Huewe , Alexandre Courbot , Lars-Peter Clausen , "James E.J. Bottomley" , rtc-linux@googlegroups.com, Leon Romanovsky , linux-nvdimm@lists.01.org, linux-rdma@vger.kernel.org, Richard Weinberger , Jason Gunthorpe , Marek Vasut , Doug Ledford , tpmdd-devel@lists.sourceforge.net, Hans Verkuil , Matt Porter , Hal Rosenstock , linux-media@vger.kernel.org, Boaz Harrosh , Arnd Bergmann , Boris Brezillon , Sajjan Vikas C , linux-input@vger.kernel.org, Marcel Selhorst , Vladimir Zapolskiy , Joe Perches , Cyrille Pitchen , Benny Halevy , Alexander Viro , Bjorn Helgaas , Mauro Carvalho Chehab , Dmitry Vyukov , Haggai Eran , Lorenzo Stoakes , "Martin K. Petersen" , Artem Bityutskiy , Greg Kroah-Hartman , linux-gpio@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Bates , Hartmut Knaack , Olof Johansson , linux-mtd@lists.infradead.org, Andrew Morton , Brian Norris , David Woodhouse , Jonathan Cameron , osd-dev@open-osd.org List-ID: On Mon, Feb 20, 2017 at 10:00:42PM -0700, Logan Gunthorpe wrote: > Signed-off-by: Logan Gunthorpe > --- Please add some more verbage, otherwise Acked-by: Dmitry Torokhov > drivers/input/evdev.c | 3 +-- > drivers/input/joydev.c | 3 +-- > drivers/input/mousedev.c | 3 +-- > 3 files changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c > index e9ae3d5..a3407ea 100644 > --- a/drivers/input/evdev.c > +++ b/drivers/input/evdev.c > @@ -1416,8 +1416,7 @@ static int evdev_connect(struct input_handler *handler, struct input_dev *dev, > goto err_free_evdev; > > cdev_init(&evdev->cdev, &evdev_fops); > - evdev->cdev.kobj.parent = &evdev->dev.kobj; > - error = cdev_add(&evdev->cdev, evdev->dev.devt, 1); > + error = device_add_cdev(&evdev->dev, &evdev->cdev); > if (error) > goto err_unregister_handle; > > diff --git a/drivers/input/joydev.c b/drivers/input/joydev.c > index abd18f3..012e06f 100644 > --- a/drivers/input/joydev.c > +++ b/drivers/input/joydev.c > @@ -905,8 +905,7 @@ static int joydev_connect(struct input_handler *handler, struct input_dev *dev, > goto err_free_joydev; > > cdev_init(&joydev->cdev, &joydev_fops); > - joydev->cdev.kobj.parent = &joydev->dev.kobj; > - error = cdev_add(&joydev->cdev, joydev->dev.devt, 1); > + error = device_add_cdev(&joydev->dev, &joydev->cdev); > if (error) > goto err_unregister_handle; > > diff --git a/drivers/input/mousedev.c b/drivers/input/mousedev.c > index b604564..efd8666 100644 > --- a/drivers/input/mousedev.c > +++ b/drivers/input/mousedev.c > @@ -901,8 +901,7 @@ static struct mousedev *mousedev_create(struct input_dev *dev, > } > > cdev_init(&mousedev->cdev, &mousedev_fops); > - mousedev->cdev.kobj.parent = &mousedev->dev.kobj; > - error = cdev_add(&mousedev->cdev, mousedev->dev.devt, 1); > + error = device_add_cdev(&mousedev->dev, &mousedev->cdev); > if (error) > goto err_unregister_handle; > > -- > 2.1.4 > -- Dmitry _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm