From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 28 Feb 2017 06:31:02 +0100 From: Greg Kroah-Hartman Subject: Re: [PATCH v2 01/16] chardev: add helper function to register char devs with a struct device Message-ID: <20170228053102.GA14688@kroah.com> References: <1488091097-12328-1-git-send-email-logang@deltatee.com> <1488091097-12328-2-git-send-email-logang@deltatee.com> <20170227165618.GE5891@obsidianresearch.com> <7df6e57b-531c-1b23-05bf-c368df2d20f3@deltatee.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Dan Williams Cc: Alessandro Zummo , Jan Kara , linux-iio@vger.kernel.org, linux-pci@vger.kernel.org, Linus Walleij , Jarkko Sakkinen , Alexandre Bounine , Alexandre Belloni , Peter Meerwald-Stadler , linux-scsi , Peter Huewe , Parav Pandit , Sean Hefty , Alexandre Courbot , Lars-Peter Clausen , "James E.J. Bottomley" , rtc-linux@googlegroups.com, Leon Romanovsky , linux-rdma@vger.kernel.org, Richard Weinberger , Jason Gunthorpe , Marek Vasut , Doug Ledford , Hans Verkuil , Matt Porter , Hal Rosenstock , linux-fsdevel , "Linux-media@vger.kernel.org" , Boaz Harrosh , Arnd Bergmann , Boris Brezillon , Sajjan Vikas C , linux-input@vger.kernel.org, Marcel Selhorst , Vladimir Zapolskiy , Joe Perches , Cyrille Pitchen , Alexander Viro , Bjorn Helgaas , Mauro Carvalho Chehab , Dmitry Vyukov , "linux-nvdimm@lists.01.org" , Haggai Eran , Lorenzo Stoakes , "Martin K. Petersen" , Artem Bityutskiy , David Woodhouse , linux-gpio@vger.kernel.org, Dmitry Torokhov , "linux-kernel@vger.kernel.org" , Stephen Bates , Hartmut Knaack , Olof Johansson , linux-mtd@lists.infradead.org, Andrew Morton , Brian Norris List-ID: On Mon, Feb 27, 2017 at 07:36:09PM -0800, Dan Williams wrote: > On Mon, Feb 27, 2017 at 7:27 PM, Logan Gunthorpe wrote: > > > > > > On 27/02/17 09:56 AM, Jason Gunthorpe wrote: > >> Yes please, that is way too subtle. Suggest: > >> > >> NOTE: Callers must assume that userspace was able to open the cdev and > >> can call cdev fops callbacks at any time, even if this function fails. > >> > >> I would also add a note to cdev_device_del: > >> > >> NOTE: This guarantees that associated sysfs callbacks are not running > >> or runnable, however any open cdevs will remain and their fops remain > >> callable even after this returns. > >> > >> Since I have seen a lot of confusion on that point as well.. > > > > Sure, I'll add that verbiage to a v3 sometime after rc1. > > It would also be great to patch1 into a stable non-rebasing git tree > so it can be used as a baseline for other 4.12 targeted development. > The device-dax patches in particular collide with some pending > development. I'll do that once -rc1 is out, I can't take any new patches right now :) thanks, greg k-h _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm