From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from deadmen.hmeau.com (unknown [128.1.224.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1C08321A0480F for ; Fri, 28 Apr 2017 10:52:26 -0700 (PDT) Date: Sat, 29 Apr 2017 01:51:47 +0800 From: Herbert Xu Subject: Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function Message-ID: <20170428175147.GA9596@gondor.apana.org.au> References: <1493144468-22493-1-git-send-email-logang@deltatee.com> <1493144468-22493-8-git-send-email-logang@deltatee.com> <20170427035603.GA32212@gondor.apana.org.au> <94123cbf-3287-f05e-7267-0bcf08ab0a8b@deltatee.com> <20170428063039.GB6817@gondor.apana.org.au> <5a08708b-c3b8-41fe-96de-607a109eacbd@deltatee.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5a08708b-c3b8-41fe-96de-607a109eacbd@deltatee.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Logan Gunthorpe Cc: dri-devel@lists.freedesktop.org, dm-devel@redhat.com, target-devel@vger.kernel.org, Christoph Hellwig , devel@driverdev.osuosl.org, "James E.J. Bottomley" , linux-scsi@vger.kernel.org, linux-nvdimm@lists.01.org, linux-rdma@vger.kernel.org, Sumit Semwal , open-iscsi@googlegroups.com, linux-media@vger.kernel.org, intel-gfx@lists.freedesktop.org, sparmaintainer@unisys.com, linux-raid@vger.kernel.org, megaraidlinux.pdl@broadcom.com, Jens Axboe , "Martin K. Petersen" , netdev@vger.kernel.org, Matthew Wilcox , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, Greg Kroah-Hartman , "David S. Miller" List-ID: On Fri, Apr 28, 2017 at 10:53:45AM -0600, Logan Gunthorpe wrote: > > > On 28/04/17 12:30 AM, Herbert Xu wrote: > > You are right. Indeed the existing code looks buggy as they > > don't take sg->offset into account when doing the kmap. Could > > you send me some patches that fix these problems first so that > > they can be easily backported? > > Ok, I think the only buggy one in crypto is hifn_795x. Shash and caam > both do have the sg->offset accounted for. I'll send a patch for the > buggy one shortly. I think they're all buggy when sg->offset is greater than PAGE_SIZE. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm