From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from newverein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2B36221A16E57 for ; Thu, 11 May 2017 00:58:28 -0700 (PDT) Date: Thu, 11 May 2017 09:58:25 +0200 From: Christoph Hellwig Subject: Re: [PATCH 16/16] fs: switch ->s_uuid to uuid_t Message-ID: <20170511075825.GB19837@lst.de> References: <20170510180214.16852-1-hch@lst.de> <20170510180214.16852-17-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Amir Goldstein Cc: linux-xfs , linux-raid@vger.kernel.org, linux-nvdimm@lists.01.org, Mimi Zohar , linux-kernel , Steven Whitehouse , David Howells , linux-fsdevel , Andy Shevchenko , Shaohua Li , Christoph Hellwig List-ID: On Wed, May 10, 2017 at 10:08:25PM +0300, Amir Goldstein wrote: > On Wed, May 10, 2017 at 9:02 PM, Christoph Hellwig wrote: > > For some file systems we still memcpy into it, but in various places this > > already allows us to use the proper uuid helpers. More to come.. > > Signed-off-by: Christoph Hellwig > > --- > > Series looks good! > > My main concern is that filesystems with char uuid[16] are here to stay, > or maybe, will be converted slowly. I'll take a stab to convert them ASAP, and add s_uuid support for you to more file systems once this initial series is done. > > Considering this, perhaps we should have a helper/macro to copy from > char[16] to *uuid_t and maybe BUILD_BUG_ON the size comparison? > #define bytes_to_uuid(dst, src) ... If the mix of proper types and u8 arrays was to stay that'd be the way to go, but I'd rather fix things up in a merge window or two instead of leaving us in a transitionary state forever. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm