From: Mike Snitzer <snitzer@redhat.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: dm-devel@redhat.com, linux-nvdimm@lists.01.org
Subject: Re: dm,dax: Make sure dm_dax_flush() is called if device supports it
Date: Tue, 25 Jul 2017 16:46:09 -0400 [thread overview]
Message-ID: <20170725204608.GA27693@redhat.com> (raw)
In-Reply-To: <20170725194337.GA20979@redhat.com>
On Tue, Jul 25 2017 at 3:43pm -0400,
Vivek Goyal <vgoyal@redhat.com> wrote:
> Right now, dm_dax_flush() is not being called and I think it is not being
> called becuase DAXDEV_WRITE_CACHE is not set on dm dax device.
>
> If underlying dax device supports write cache, set DAXDEV_WRITE_CACHE on
> dm dax device. This will get dm_dax_flush() being called.
>
> Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
In general this looks mostly OK.. but it seems a bit weird to on the one
hand: test if DAXDEV_WRITE_CACHE is set on underlying device. And on
the other: say it is a write cache because it is "flush_capable". Kind
of blurring things a bit.
Why not s/device_dax_flush_capable/device_dax_write_cache_enabled/ ?
Mike
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2017-07-25 20:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 19:43 [PATCH] dm,dax: Make sure dm_dax_flush() is called if device supports it Vivek Goyal
2017-07-25 20:43 ` Dan Williams
2017-07-25 20:51 ` Vivek Goyal
2017-07-25 20:46 ` Mike Snitzer [this message]
2017-07-25 20:54 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170725204608.GA27693@redhat.com \
--to=snitzer@redhat.com \
--cc=dm-devel@redhat.com \
--cc=linux-nvdimm@lists.01.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox