From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Cc: Jens Axboe <axboe@kernel.dk>,
Jerome Marchand <jmarchan@redhat.com>,
linux-nvdimm@lists.01.org, Dave Chinner <david@fromorbit.com>,
Matthew Wilcox <willy@infradead.org>,
Christoph Hellwig <hch@lst.de>, Minchan Kim <minchan@kernel.org>,
Jan Kara <jack@suse.cz>, "karam . lee" <karam.lee@lge.com>,
seungho1.park@lge.com, Nitin Gupta <ngupta@vflare.org>
Subject: [PATCH 1/3] btt: remove btt_rw_page()
Date: Fri, 28 Jul 2017 10:56:02 -0600 [thread overview]
Message-ID: <20170728165604.10455-2-ross.zwisler@linux.intel.com> (raw)
In-Reply-To: <20170728165604.10455-1-ross.zwisler@linux.intel.com>
The rw_page() interface doesn't provide a clear performance benefit for the
BTT and has had a nonzero maintenance burden, so remove it.
Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Suggested-by: Dan Williams <dan.j.williams@intel.com>
Suggested-by: Christoph Hellwig <hch@infradead.org>
Cc: Matthew Wilcox <willy@infradead.org>
---
drivers/nvdimm/btt.c | 15 ---------------
1 file changed, 15 deletions(-)
diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c
index 14323fa..e10d330 100644
--- a/drivers/nvdimm/btt.c
+++ b/drivers/nvdimm/btt.c
@@ -1236,20 +1236,6 @@ static blk_qc_t btt_make_request(struct request_queue *q, struct bio *bio)
return BLK_QC_T_NONE;
}
-static int btt_rw_page(struct block_device *bdev, sector_t sector,
- struct page *page, bool is_write)
-{
- struct btt *btt = bdev->bd_disk->private_data;
- int rc;
-
- rc = btt_do_bvec(btt, NULL, page, PAGE_SIZE, 0, is_write, sector);
- if (rc == 0)
- page_endio(page, is_write, 0);
-
- return rc;
-}
-
-
static int btt_getgeo(struct block_device *bd, struct hd_geometry *geo)
{
/* some standard values */
@@ -1261,7 +1247,6 @@ static int btt_getgeo(struct block_device *bd, struct hd_geometry *geo)
static const struct block_device_operations btt_fops = {
.owner = THIS_MODULE,
- .rw_page = btt_rw_page,
.getgeo = btt_getgeo,
.revalidate_disk = nvdimm_revalidate_disk,
};
--
2.9.4
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2017-07-28 16:56 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-28 16:56 [PATCH 0/3] remove rw_page() from brd, pmem and btt Ross Zwisler
2017-07-28 16:56 ` Ross Zwisler [this message]
2017-08-03 16:15 ` [PATCH 1/3] btt: remove btt_rw_page() kbuild test robot
2017-07-28 16:56 ` [PATCH 2/3] pmem: remove pmem_rw_page() Ross Zwisler
2017-07-28 16:56 ` [PATCH 3/3] brd: remove brd_rw_page() Ross Zwisler
2017-07-28 17:31 ` [PATCH 0/3] remove rw_page() from brd, pmem and btt Matthew Wilcox
2017-07-28 21:21 ` Andrew Morton
2017-07-30 22:16 ` Minchan Kim
2017-07-30 22:38 ` Minchan Kim
2017-07-31 7:17 ` Christoph Hellwig
2017-07-31 7:36 ` Minchan Kim
2017-07-31 7:42 ` Christoph Hellwig
2017-07-31 7:44 ` Christoph Hellwig
2017-08-01 6:23 ` Minchan Kim
2017-08-02 22:13 ` Ross Zwisler
2017-08-03 0:13 ` Minchan Kim
2017-08-03 0:34 ` Dan Williams
2017-08-03 8:05 ` Christoph Hellwig
2017-08-04 0:57 ` Minchan Kim
2017-08-03 21:13 ` Ross Zwisler
2017-08-03 21:17 ` Jens Axboe
2017-08-04 3:54 ` Minchan Kim
2017-08-04 8:17 ` Minchan Kim
2017-08-04 18:01 ` Dan Williams
2017-08-04 18:21 ` Ross Zwisler
2017-08-04 18:24 ` Dan Williams
2017-08-07 8:23 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170728165604.10455-2-ross.zwisler@linux.intel.com \
--to=ross.zwisler@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jmarchan@redhat.com \
--cc=karam.lee@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=seungho1.park@lge.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox