From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2A02A21CE7490 for ; Fri, 28 Jul 2017 09:59:44 -0700 (PDT) From: Ross Zwisler Subject: [PATCH 3/3] brd: remove brd_rw_page() Date: Fri, 28 Jul 2017 10:56:04 -0600 Message-Id: <20170728165604.10455-4-ross.zwisler@linux.intel.com> In-Reply-To: <20170728165604.10455-1-ross.zwisler@linux.intel.com> References: <20170728165604.10455-1-ross.zwisler@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Andrew Morton , linux-kernel@vger.kernel.org Cc: Jens Axboe , Jerome Marchand , linux-nvdimm@lists.01.org, Dave Chinner , Matthew Wilcox , Christoph Hellwig , Minchan Kim , Jan Kara , "karam . lee" , seungho1.park@lge.com, Nitin Gupta List-ID: The rw_page() interface doesn't provide a clear performance benefit for BRD and has had a nonzero maintenance burden, so remove it. Signed-off-by: Ross Zwisler Suggested-by: Dan Williams Suggested-by: Christoph Hellwig Cc: Matthew Wilcox --- drivers/block/brd.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/block/brd.c b/drivers/block/brd.c index 104b71c..29325058 100644 --- a/drivers/block/brd.c +++ b/drivers/block/brd.c @@ -322,15 +322,6 @@ static blk_qc_t brd_make_request(struct request_queue *q, struct bio *bio) return BLK_QC_T_NONE; } -static int brd_rw_page(struct block_device *bdev, sector_t sector, - struct page *page, bool is_write) -{ - struct brd_device *brd = bdev->bd_disk->private_data; - int err = brd_do_bvec(brd, page, PAGE_SIZE, 0, is_write, sector); - page_endio(page, is_write, err); - return err; -} - #ifdef CONFIG_BLK_DEV_RAM_DAX static long __brd_direct_access(struct brd_device *brd, pgoff_t pgoff, long nr_pages, void **kaddr, pfn_t *pfn) @@ -370,7 +361,6 @@ static const struct dax_operations brd_dax_ops = { static const struct block_device_operations brd_fops = { .owner = THIS_MODULE, - .rw_page = brd_rw_page, }; /* -- 2.9.4 _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm