[PATCH 3/3] brd: remove brd_rw_page()

Ross Zwisler
2017-07-28T16:59:44Z

The rw_page() interface doesn't provide a clear performance benefit for
BRD and has had a nonzero maintenance burden, so remove it.

Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Suggested-by: Dan Williams <dan.j.williams@intel.com>
Suggested-by: Christoph Hellwig <hch@infradead.org>
Cc: Matthew Wilcox <willy@infradead.org>
---
drivers/block/brd.c | 10 ----------
1 file changed, 10 deletions(-)

diff --git a/drivers/block/brd.c b/drivers/block/brd.c
index 104b71c..29325058 100644
--- a/drivers/block/brd.c
+++ b/drivers/block/brd.c
@@ -322,15 +322,6 @@ static blk_qc_t brd_make_request(struct request_queue *q, struct bio *bio)
return BLK_QC_T_NONE;
}

-static int brd_rw_page(struct block_device *bdev, sector_t sector,
- struct page *page, bool is_write)
-{
- struct brd_device *brd = bdev->bd_disk->private_data;
- int err = brd_do_bvec(brd, page, PAGE_SIZE, 0, is_write, sector);
- page_endio(page, is_write, err);
- return err;
-}
-
#ifdef CONFIG_BLK_DEV_RAM_DAX
static long __brd_direct_access(struct brd_device *brd, pgoff_t pgoff,
long nr_pages, void **kaddr, pfn_t *pfn)
@@ -370,7 +361,6 @@ static const struct dax_operations brd_dax_ops = {

static const struct block_device_operations brd_fops = {
.owner = THIS_MODULE,
- .rw_page = brd_rw_page,
};

/*
--
2.9.4